BFacetedParameter - Code Metrics - Inspection of "Chg: Обновлена сборка js" - shogodev/argilla - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 951ad1...29ba67 )

by Alexey

created 2016-04-25 14:57 UTC

BFacetedParameter A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	55
Duplicated Lines	29.09 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

42.11%

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	7
c	1
b	0
f	0
lcom	0
cbo	2
dl	16
loc	55
ccs	8
cts	19
cp	0.4211
rs	10

5 Methods

Rating	Name	Duplication	Size	Complexity
A	tableName()	0	4	1
A	model()	0	4	1
A	getProperties()	8	8	2
A	getParameters()	8	8	2
A	isPropertyValid()	0	7	1

How to fix Duplicated Code

<?php
/**
 * @author Sergey Glagolev <[email protected]>
 * @link https://github.com/shogodev/argilla/
 * @copyright Copyright &copy; 2003-2014 Shogo
 * @license http://argilla.ru/LICENSE
 * @package backend.modules.product
 *
 * @property integer $id
 * @property string $parameter
 */
class BFacetedParameter extends CActiveRecord
{
  public function tableName()
  {
    return '{{faceted_parameter}}';
  }


  /**
   * @param string $className
   *
   * @return static BFacetedParameter
   */
  public static function model($className = __CLASS__)
  {
    return parent::model(get_called_class());
  }

  /**
   * @return array
   */
  public function getProperties()

  {
    return array_reduce($this->findAll(), function($result, $parameter) {
      if( $this->isPropertyValid($parameter->parameter) )
        $result[] = $parameter->parameter;
      return $result;
    }, []);
  }

  /**
   * @return array
   */
  public function getParameters()

  {
    return array_reduce($this->findAll(), function($result, $parameter) {
      if( is_numeric($parameter->parameter) )
        $result[] = $parameter->parameter;
      return $result;
    }, []);
  }

  /**
   * @param string $property
   *
   * @return bool
   */
  protected function isPropertyValid($property)
  {
    return in_array($property, CMap::mergeArray(
      array_keys(BProduct::model()->tableSchema->columns),
      array_keys(BProductAssignment::model()->tableSchema->columns)
    ));
  }
}

1			<?php
2			/**
3			* @author Sergey Glagolev <[email protected]>
4			* @link https://github.com/shogodev/argilla/
5			* @copyright Copyright © 2003-2014 Shogo
6			* @license http://argilla.ru/LICENSE
7			* @package backend.modules.product
8			*
9			* @property integer $id
10			* @property string $parameter
11			*/
12			class BFacetedParameter extends CActiveRecord
13			{
14	1		public function tableName()
15			{
16	1		return '{{faceted_parameter}}';
17			}
18
19
20			/**
21			* @param string $className
22			*
23			* @return static BFacetedParameter
24			*/
25	4		public static function model($className = __CLASS__)
26			{
27	4		return parent::model(get_called_class());
28			}
29
30			/**
31			* @return array
32			*/
33	4	View Code Duplication	public function getProperties()
			0 ignored issues – show Duplication introduced 2015-11-25 11:59 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
34			{
35			return array_reduce($this->findAll(), function($result, $parameter) {
36			if( $this->isPropertyValid($parameter->parameter) )
37			$result[] = $parameter->parameter;
38			return $result;
39	4		}, []);
40			}
41
42			/**
43			* @return array
44			*/
45		View Code Duplication	public function getParameters()
			0 ignored issues – show Duplication introduced 2015-11-25 11:59 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
46			{
47	4		return array_reduce($this->findAll(), function($result, $parameter) {
48			if( is_numeric($parameter->parameter) )
49			$result[] = $parameter->parameter;
50			return $result;
51	4		}, []);
52			}
53
54			/**
55			* @param string $property
56			*
57			* @return bool
58			*/
59			protected function isPropertyValid($property)
60			{
61			return in_array($property, CMap::mergeArray(
62			array_keys(BProduct::model()->tableSchema->columns),
63			array_keys(BProductAssignment::model()->tableSchema->columns)
64			));
65			}
66			}

shogodev / argilla

GitHub Access Token became invalid

Push — master ( 951ad1...29ba67 )

BFacetedParameter A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like