AbstractImportCommand - Code Metrics - Inspection of "Chg: Обновлена сборка js" - shogodev/argilla - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 951ad1...29ba67 )

by Alexey

created 2016-04-25 14:57 UTC

AbstractImportCommand A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	49
Duplicated Lines	28.57 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	9
c	1
b	0
f	0
lcom	1
cbo	2
dl	14
loc	49
rs	10

4 Methods

Rating	Name	Duplication	Size	Complexity
A	behaviors()	0	9	1
A	beginTransaction()	14	14	4
A	commitTransaction()	0	8	2
A	rollbackTransaction()	0	8	2

How to fix Duplicated Code

<?php
/**
 * @author Alexey Tatarinov <[email protected]>
 * @link https://github.com/shogodev/argilla/
 * @copyright Copyright &copy; 2003-2015 Shogo
 * @license http://argilla.ru/LICENSE
 */

/**
 * Class AbstractImportCommand
 * @mixin CurrentTransactionBehavior
 */
class AbstractImportCommand extends LoggingCommand
{
  public $logFileName = 'import.log';

  protected $useCurrentTransaction;

  public function behaviors()
  {
    return CMap::mergeArray(
      parent::behaviors(),
      array(
        'currentTransactionBehavior' => array('class' => 'fronted.share.behaviors.CurrentTransactionBehavior')
      )
    );
  }

  public function beginTransaction()

  {
    if( Yii::app()->db->getCurrentTransaction() && is_null($this->useCurrentTransaction) )
    {
      $this->useCurrentTransaction = false;
      return;
    }

    if( is_null($this->useCurrentTransaction) )
    {
      Yii::app()->db->beginTransaction();
      $this->useCurrentTransaction = true;
    }
  }

  public function commitTransaction()
  {
    if( $this->useCurrentTransaction )
    {
      Yii::app()->db->currentTransaction->commit();
      $this->useCurrentTransaction = null;
    }
  }

  public function rollbackTransaction()
  {
    if( $this->useCurrentTransaction )
    {
      Yii::app()->db->currentTransaction->rollback();
      $this->useCurrentTransaction = null;
    }
  }
}

1		<?php
2		/**
3		* @author Alexey Tatarinov <[email protected]>
4		* @link https://github.com/shogodev/argilla/
5		* @copyright Copyright © 2003-2015 Shogo
6		* @license http://argilla.ru/LICENSE
7		*/
8
9		/**
10		* Class AbstractImportCommand
11		* @mixin CurrentTransactionBehavior
12		*/
13		class AbstractImportCommand extends LoggingCommand
14		{
15		public $logFileName = 'import.log';
16
17		protected $useCurrentTransaction;
18
19		public function behaviors()
20		{
21		return CMap::mergeArray(
22		parent::behaviors(),
23		array(
24		'currentTransactionBehavior' => array('class' => 'fronted.share.behaviors.CurrentTransactionBehavior')
25		)
26		);
27		}
28
29	View Code Duplication	public function beginTransaction()
		0 ignored issues – show Duplication introduced 2016-04-25 15:05 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
30		{
31		if( Yii::app()->db->getCurrentTransaction() && is_null($this->useCurrentTransaction) )
32		{
33		$this->useCurrentTransaction = false;
34		return;
35		}
36
37		if( is_null($this->useCurrentTransaction) )
38		{
39		Yii::app()->db->beginTransaction();
40		$this->useCurrentTransaction = true;
41		}
42		}
43
44		public function commitTransaction()
45		{
46		if( $this->useCurrentTransaction )
47		{
48		Yii::app()->db->currentTransaction->commit();
49		$this->useCurrentTransaction = null;
50		}
51		}
52
53		public function rollbackTransaction()
54		{
55		if( $this->useCurrentTransaction )
56		{
57		Yii::app()->db->currentTransaction->rollback();
58		$this->useCurrentTransaction = null;
59		}
60		}
61		}

shogodev / argilla

GitHub Access Token became invalid

Push — master ( 951ad1...29ba67 )

AbstractImportCommand A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like