Client::makeRequest() - Code Metrics - Inspection of "New: Добавлено расширение retailCrm (для выгрузки..." - shogodev/argilla - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 61aacd...05f06e )

by Alexey

created 2016-03-02 12:02 UTC

Client::makeRequest() B

↳ Parent: Client

Complexity

Conditions	6
Paths	9

Size

Total Lines	53
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	53
rs	8.7155
cc	6
eloc	37
nc	9
nop	6

How to fix Long Method

<?php

namespace RetailCrm\Http;

use RetailCrm\Exception\CurlException;
use RetailCrm\Response\ApiResponse;

/**
 * HTTP client
 */
class Client
{
    const METHOD_GET = 'GET';
    const METHOD_POST = 'POST';

    protected $url;
    protected $defaultParameters;
    protected $retry;

    public function __construct($url, array $defaultParameters = array())
    {
        if (false === stripos($url, 'https://')) {
            throw new \InvalidArgumentException('API schema requires HTTPS protocol');
        }

        $this->url = $url;
        $this->defaultParameters = $defaultParameters;
        $this->retry = 0;
    }

    /**
     * Make HTTP request
     *
     * @param string $path
     * @param string $method (default: 'GET')
     * @param array $parameters (default: array())
     * @param int $timeout
     * @param bool $verify
     * @param bool $debug
     * @return ApiResponse
     */
    public function makeRequest(
        $path,
        $method,
        array $parameters = array(),
        $timeout = 30,
        $verify = false,
        $debug = false

    ) {
        $allowedMethods = array(self::METHOD_GET, self::METHOD_POST);
        if (!in_array($method, $allowedMethods)) {
            throw new \InvalidArgumentException(sprintf(
                'Method "%s" is not valid. Allowed methods are %s',
                $method,
                implode(', ', $allowedMethods)
            ));
        }

        $parameters = array_merge($this->defaultParameters, $parameters);

        $path = $this->url . $path;

        if (self::METHOD_GET === $method && sizeof($parameters)) {
            $path .= '?' . http_build_query($parameters, '', '&');
        }

        $ch = curl_init();
        curl_setopt($ch, CURLOPT_URL, $path);
        curl_setopt($ch, CURLOPT_TIMEOUT, (int) $timeout);
        curl_setopt($ch, CURLOPT_CONNECTTIMEOUT, (int) $timeout);
        curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
        curl_setopt($ch, CURLOPT_FOLLOWLOCATION, 1);
        curl_setopt($ch, CURLOPT_FAILONERROR, false);
        curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, $verify);
        curl_setopt($ch, CURLOPT_SSL_VERIFYHOST, $verify);

        if (self::METHOD_POST === $method) {
            curl_setopt($ch, CURLOPT_POST, true);
            curl_setopt($ch, CURLOPT_POSTFIELDS, $parameters);
        }

        $responseBody = curl_exec($ch);
        $statusCode = curl_getinfo($ch, CURLINFO_HTTP_CODE);
        $errno = curl_errno($ch);
        $error = curl_error($ch);

        curl_close($ch);

        if ($errno) {
            throw new CurlException($error, $errno);
        }

        return new ApiResponse($statusCode, $responseBody);
    }
}


1			<?php
2
3			namespace RetailCrm\Http;
4
5			use RetailCrm\Exception\CurlException;
6			use RetailCrm\Response\ApiResponse;
7
8			/**
9			* HTTP client
10			*/
11			class Client
12			{
13			const METHOD_GET = 'GET';
14			const METHOD_POST = 'POST';
15
16			protected $url;
17			protected $defaultParameters;
18			protected $retry;
19
20			public function __construct($url, array $defaultParameters = array())
21			{
22			if (false === stripos($url, 'https://')) {
23			throw new \InvalidArgumentException('API schema requires HTTPS protocol');
24			}
25
26			$this->url = $url;
27			$this->defaultParameters = $defaultParameters;
28			$this->retry = 0;
29			}
30
31			/**
32			* Make HTTP request
33			*
34			* @param string $path
35			* @param string $method (default: 'GET')
36			* @param array $parameters (default: array())
37			* @param int $timeout
38			* @param bool $verify
39			* @param bool $debug
40			* @return ApiResponse
41			*/
42			public function makeRequest(
43			$path,
44			$method,
45			array $parameters = array(),
46			$timeout = 30,
47			$verify = false,
48			$debug = false
			0 ignored issues – show Unused Code introduced 2016-03-02 12:20 UTC by Report Bug Copy Issue Report The parameter `$debug` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
49			) {
50			$allowedMethods = array(self::METHOD_GET, self::METHOD_POST);
51			if (!in_array($method, $allowedMethods)) {
52			throw new \InvalidArgumentException(sprintf(
53			'Method "%s" is not valid. Allowed methods are %s',
54			$method,
55			implode(', ', $allowedMethods)
56			));
57			}
58
59			$parameters = array_merge($this->defaultParameters, $parameters);
60
61			$path = $this->url . $path;
62
63			if (self::METHOD_GET === $method && sizeof($parameters)) {
64			$path .= '?' . http_build_query($parameters, '', '&');
65			}
66
67			$ch = curl_init();
68			curl_setopt($ch, CURLOPT_URL, $path);
69			curl_setopt($ch, CURLOPT_TIMEOUT, (int) $timeout);
70			curl_setopt($ch, CURLOPT_CONNECTTIMEOUT, (int) $timeout);
71			curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
72			curl_setopt($ch, CURLOPT_FOLLOWLOCATION, 1);
73			curl_setopt($ch, CURLOPT_FAILONERROR, false);
74			curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, $verify);
75			curl_setopt($ch, CURLOPT_SSL_VERIFYHOST, $verify);
76
77			if (self::METHOD_POST === $method) {
78			curl_setopt($ch, CURLOPT_POST, true);
79			curl_setopt($ch, CURLOPT_POSTFIELDS, $parameters);
80			}
81
82			$responseBody = curl_exec($ch);
83			$statusCode = curl_getinfo($ch, CURLINFO_HTTP_CODE);
84			$errno = curl_errno($ch);
85			$error = curl_error($ch);
86
87			curl_close($ch);
88
89			if ($errno) {
90			throw new CurlException($error, $errno);
91			}
92
93			return new ApiResponse($statusCode, $responseBody);
94			}
95			}
96

shogodev / argilla

GitHub Access Token became invalid

Push — master ( 61aacd...05f06e )

Client::makeRequest() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like