UserProfileController - Code Metrics - shogodev/argilla - Measure and Improve Code Quality continuously with Scrutinizer

UserProfileController A
last analyzed 2020-09-24 13:50 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	182
Duplicated Lines	7.14 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

60.18%

Importance

Changes

Metric	Value
dl	13
loc	182
ccs	68
cts	113
cp	0.6018
rs	10
c	0
b	0
f	0
wmc	23
lcom	1
cbo	7

9 Methods

Rating	Name	Duplication	Size	Complexity
A	filters()	0	4	1
A	accessRules()	0	8	1
A	actionProfile()	13	13	1
B	actionData()	0	37	7
A	actionChangePassword()	0	23	3
A	actionHistoryOrders()	0	11	1
A	actionSocial()	0	11	1
B	actionBindSocial()	0	40	7
A	getMenu()	0	23	1

How to fix Duplicated Code

<?php
/**
 * @author Alexey Tatarinov <[email protected]>
 * @link https://github.com/shogodev/argilla/
 * @copyright Copyright &copy; 2003-2014 Shogo
 * @license http://argilla.ru/LICENSE
 * @package frontend.controllers
 */
class UserProfileController extends FController
{
  public $pageSize = 10;

  public function filters()
  {
    return array('accessControl');
  }

  public function accessRules()
  {
    return array(
      array('deny',
        'users' => array('?'),
      ),
    );
  }

  public function actionProfile()

  {
    $this->breadcrumbs = array(
      'Личный кабинет',
      'Мой профиль',
    );

    $model = User::model()->findByPk(Yii::app()->user->getId());

    $this->render('profile', array(
      'model' => $model,
    ));
  }

  public function actionData()
  {
    $this->breadcrumbs = array(
      'Личный кабинет',
      'Личные данные',
    );

    if( empty(Yii::app()->user->data->login) )
    {
      Yii::app()->user->data->scenario = User::SCENARIO_REGISTRATION;
      if( !empty(Yii::app()->user->data->socials) )
      {
        if( empty(Yii::app()->user->data->email) )
          Yii::app()->user->data->email = Yii::app()->user->getEmail();

        if( empty(Yii::app()->user->profile->name) )
          Yii::app()->user->profile->name = Yii::app()->user->getName();
      }
    }
    else
      Yii::app()->user->data->scenario = User::SCENARIO_CHANGE_EMAIL;

    $userForm = new FForm('UserData', Yii::app()->user->data);
    $userForm['profile']->model = Yii::app()->user->profile;
    $userForm['profile']->elements['birthday']->form = $userForm['profile'];
    $userForm->ajaxValidation();

    if( Yii::app()->request->isAjaxRequest && $userForm->save() )
    {
      $userForm->responseSuccess(Yii::app()->controller->textBlockRegister(
        'Успешное изменение пользовательских данных',
        'Изменения сохранены'
      ));
    }

    $this->render('data', array('form' => $userForm));
  }

  public function actionChangePassword()
  {
    $this->breadcrumbs = array(
      'Личный кабинет',
      'Сменить пароль',
    );
    $model = User::model()->findByPk(Yii::app()->user->getId());
    $model->scenario = User::SCENARIO_CHANGE_PASSWORD;

    $form = new FForm('UserChangePassword', $model);
    $form->ajaxValidation();

    if( Yii::app()->request->isAjaxRequest && $form->save() )
    {
      Yii::app()->notification->send('UserChangePassword', array('model' => $form->model), $form->model->email);
      $form->responseSuccess(Yii::app()->controller->textBlockRegister(
        'Успешное изменение пароля',
        'Изменения сохранены'
      ));
    }

    $this->render('change_password', array('form' => $form));
  }

  public function actionHistoryOrders()
  {
    $this->breadcrumbs = array(
      'Личный кабинет',
      'История заказов',
    );

    $orderDataProvider = new FActiveDataProvider('OrderHistory');

    $this->render('history_orders', array('orderDataProvider' => $orderDataProvider));
  }

  public function actionSocial()
  {
    $this->breadcrumbs = array(
      'Мой профиль',
      'Мои социальные сети',
    );

    $socialManager = new SocialManager();

    $this->render('social', array('socials' => $socialManager->getSocialList()));
  }

  public function actionBindSocial($service)
  {
    if( isset($service) )
    {
      /**
       * @var $eauth EAuthServiceBase
       */
      $eauth = Yii::app()->eauth->getIdentity($service);
      $eauth->redirectUrl = $this->createAbsoluteUrl('userProfile/social');

      $eauth->cancelUrl = $this->createAbsoluteUrl('userProfile/social');


      try
      {
        if( $eauth->authenticate() )
        {
          if( $eauth->isAuthenticated )
          {
            $socialManager = new SocialManager();

            if( $socialManager->isAllowedUnbind() && $socialManager->isBinded($eauth) )
              $socialManager->unbindSocial($eauth);
            else
              $socialManager->bingSocial($eauth);
          }
          else
          {
            $eauth->cancel();
          }
        }

        $this->redirect($this->createAbsoluteUrl('userProfile/social'));
      }
      catch(EAuthException $e)
      {
        Yii::app()->user->setFlash('error', 'EAuthException: '.$e->getMessage());

        $eauth->redirect($eauth->getCancelUrl());
      }
    }
  }
  public function getMenu()
  {
    $menu = array(
      array(
        'label' => 'Личные данные',
        'url' => array('userProfile/data')
      ),
      array(
        'label' => 'История заказов',
        'url' => array('userProfile/historyOrders')
      ),
          array(
            'label' => 'Мои социальный сети',
            'url' => array('userProfile/social')
          ),
      array(
        'label' => 'Сменить пароль',
        'url' => array('userProfile/changePassword')
      ),
    );

    return $menu;
  }
}

1			<?php
2			/**
3			* @author Alexey Tatarinov <[email protected]>
4			* @link https://github.com/shogodev/argilla/
5			* @copyright Copyright © 2003-2014 Shogo
6			* @license http://argilla.ru/LICENSE
7			* @package frontend.controllers
8			*/
9			class UserProfileController extends FController
10			{
11			public $pageSize = 10;
12
13	12		public function filters()
14			{
15	12		return array('accessControl');
16			}
17
18	12		public function accessRules()
19			{
20			return array(
21	12		array('deny',
22	12		'users' => array('?'),
23	12		),
24	12		);
25			}
26
27	1	View Code Duplication	public function actionProfile()
			0 ignored issues – show Duplication introduced 2017-10-20 12:47 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
28			{
29	1		$this->breadcrumbs = array(
30	1		'Личный кабинет',
31	1		'Мой профиль',
32			);
33
34	1		$model = User::model()->findByPk(Yii::app()->user->getId());
35
36	1		$this->render('profile', array(
37	1		'model' => $model,
38	1		));
39	1		}
40
41	3		public function actionData()
42			{
43	3		$this->breadcrumbs = array(
44	3		'Личный кабинет',
45	3		'Личные данные',
46			);
47
48	3		if( empty(Yii::app()->user->data->login) )
49	3		{
50	3		Yii::app()->user->data->scenario = User::SCENARIO_REGISTRATION;
51	3		if( !empty(Yii::app()->user->data->socials) )
52	3		{
53			if( empty(Yii::app()->user->data->email) )
54			Yii::app()->user->data->email = Yii::app()->user->getEmail();
55
56			if( empty(Yii::app()->user->profile->name) )
57			Yii::app()->user->profile->name = Yii::app()->user->getName();
58			}
59	3		}
60			else
61			Yii::app()->user->data->scenario = User::SCENARIO_CHANGE_EMAIL;
62
63	3		$userForm = new FForm('UserData', Yii::app()->user->data);
64	3		$userForm['profile']->model = Yii::app()->user->profile;
65	3		$userForm['profile']->elements['birthday']->form = $userForm['profile'];
66	3		$userForm->ajaxValidation();
67
68	3		if( Yii::app()->request->isAjaxRequest && $userForm->save() )
69	2		{
70	1		$userForm->responseSuccess(Yii::app()->controller->textBlockRegister(
71	1		'Успешное изменение пользовательских данных',
72			'Изменения сохранены'
73	1		));
74			}
75
76	1		$this->render('data', array('form' => $userForm));
77	1		}
78
79	3		public function actionChangePassword()
80			{
81	3		$this->breadcrumbs = array(
82	3		'Личный кабинет',
83	3		'Сменить пароль',
84			);
85	3		$model = User::model()->findByPk(Yii::app()->user->getId());
86	3		$model->scenario = User::SCENARIO_CHANGE_PASSWORD;
87
88	3		$form = new FForm('UserChangePassword', $model);
89	3		$form->ajaxValidation();
90
91	3		if( Yii::app()->request->isAjaxRequest && $form->save() )
92	2		{
93	1		Yii::app()->notification->send('UserChangePassword', array('model' => $form->model), $form->model->email);
94	1		$form->responseSuccess(Yii::app()->controller->textBlockRegister(
95	1		'Успешное изменение пароля',
96			'Изменения сохранены'
97	1		));
98			}
99
100	1		$this->render('change_password', array('form' => $form));
101	1		}
102
103			public function actionHistoryOrders()
104			{
105			$this->breadcrumbs = array(
106			'Личный кабинет',
107			'История заказов',
108			);
109
110			$orderDataProvider = new FActiveDataProvider('OrderHistory');
111
112			$this->render('history_orders', array('orderDataProvider' => $orderDataProvider));
113			}
114
115			public function actionSocial()
116			{
117			$this->breadcrumbs = array(
118			'Мой профиль',
119			'Мои социальные сети',
120			);
121
122			$socialManager = new SocialManager();
123
124			$this->render('social', array('socials' => $socialManager->getSocialList()));
125			}
126
127			public function actionBindSocial($service)
128			{
129			if( isset($service) )
130			{
131			/**
132			* @var $eauth EAuthServiceBase
133			*/
134			$eauth = Yii::app()->eauth->getIdentity($service);
135			$eauth->redirectUrl = $this->createAbsoluteUrl('userProfile/social');
			0 ignored issues – show Bug introduced 2015-11-25 11:59 UTC by Report Bug Copy Issue Report The property `redirectUrl` cannot be accessed from this context as it is declared `private` in class `EAuthServiceBase`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
136			$eauth->cancelUrl = $this->createAbsoluteUrl('userProfile/social');
			0 ignored issues – show Bug introduced 2015-11-25 11:59 UTC by Report Bug Copy Issue Report The property `cancelUrl` cannot be accessed from this context as it is declared `private` in class `EAuthServiceBase`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
137
138			try
139			{
140			if( $eauth->authenticate() )
141			{
142			if( $eauth->isAuthenticated )
143			{
144			$socialManager = new SocialManager();
145
146			if( $socialManager->isAllowedUnbind() && $socialManager->isBinded($eauth) )
147			$socialManager->unbindSocial($eauth);
148			else
149			$socialManager->bingSocial($eauth);
150			}
151			else
152			{
153			$eauth->cancel();
154			}
155			}
156
157			$this->redirect($this->createAbsoluteUrl('userProfile/social'));
158			}
159			catch(EAuthException $e)
160			{
161			Yii::app()->user->setFlash('error', 'EAuthException: '.$e->getMessage());
162
163			$eauth->redirect($eauth->getCancelUrl());
164			}
165			}
166			}
167	3		public function getMenu()
168			{
169			$menu = array(
170			array(
171	3		'label' => 'Личные данные',
172	3		'url' => array('userProfile/data')
173	3		),
174			array(
175	3		'label' => 'История заказов',
176	3		'url' => array('userProfile/historyOrders')
177	3		),
178			array(
179	3		'label' => 'Мои социальный сети',
180	3		'url' => array('userProfile/social')
181	3		),
182			array(
183	3		'label' => 'Сменить пароль',
184	3		'url' => array('userProfile/changePassword')
185	3		),
186	3		);
187
188	3		return $menu;
189			}
190			}

shogodev / argilla

GitHub Access Token became invalid

UserProfileController A last analyzed 2020-09-24 13:50 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

9 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

UserProfileController A
last analyzed 2020-09-24 13:50 UTC