BController - Code Metrics - shogodev/argilla - Measure and Improve Code Quality continuously with Scrutinizer

BController F
last analyzed 2020-09-24 13:50 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	465
Duplicated Lines	1.08 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

60.19%

Importance

Changes

Metric	Value
dl	5
loc	465
rs	2.48
c	0
b	0
f	0
ccs	130
cts	216
cp	0.6019
wmc	74
lcom	1
cbo	5

25 Methods

Rating	Name	Duplication	Size	Complexity
A	behaviors()	0	7	1
A	getViewPath()	0	12	4
A	filters()	0	6	1
B	beforeAction()	0	32	6
A	getBackUrl()	0	8	2
A	actions()	0	13	1
A	redirect()	0	11	2
A	render()	0	11	2
A	loadModel()	0	10	3
A	actionIndex()	0	9	1
A	actionCreate()	0	6	1
A	actionUpdate()	0	4	1
A	isUpdate()	0	4	2
B	actionAutocomplete()	0	25	7
A	createFilterModel()	0	11	2
A	saveModel()	0	15	3
B	saveModels()	5	41	9
A	validateModels()	0	13	5
A	validateRelatedModels()	0	18	4
A	redirectAfterSave()	0	14	3
A	actionSave()	0	5	1
A	performAjaxValidation()	0	8	2
A	performAjaxValidationForSeveralModels()	0	16	3
B	saveMaximumPostData()	0	21	7
A	getModelsAllowedForSave()	0	4	1

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like BController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use BController, and based on these observations, apply Extract Interface, too.

<?php
/**
 * @author Sergey Glagolev <[email protected]>, Nikita Melnikov <[email protected]>
 * @link https://github.com/shogodev/argilla/
 * @copyright Copyright &copy; 2003-2014 Shogo
 * @license http://argilla.ru/LICENSE
 * @package backend.controllers
 *
 * @property BModule $module
 * @mixin TextBlockBehavior
 * @mixin CommonBehavior
 */
abstract class BController extends CController
{
  public $enabled = true;

  public $position = 0;

  public $name = '[Не задано]';

  public $layout = '//layouts/column1';

  /**
   * @var array
   */
  public $breadcrumbs = array();

  public $modelClass = 'BActiveRecord';

  public $popup = false;

  public $moduleMenu;

  public $showInMenu = true;

  public function behaviors()
  {
    return array(
      'textBlock' => array('class' => 'TextBlockBehavior'),
      'common' => array('class' => 'CommonBehavior'),
    );
  }

  public function getViewPath()
  {
    if( ($module = $this->getModule()) === null )
      $module = Yii::app();

    $mappedId = array_search(get_class($this), $module->controllerMap);
    $id = $mappedId ? $mappedId : $this->getId();

    $submoduleViewPath = $module->getViewPath().DIRECTORY_SEPARATOR.$id;

    return file_exists($submoduleViewPath) ? $submoduleViewPath : $module->getViewPath();
  }

  public function filters()
  {
    return array(
      'postOnly + delete',
    );
  }

  public function beforeAction($action)
  {
    if( !AccessHelper::checkAccessByClasses($this->module, $this) )
    {
      if( !Yii::app()->user->isGuest )
        throw new CHttpException(403, 'Доступ запрещен.');
      else
      {
        if( Yii::app()->request->isAjaxRequest )
          throw new CHttpException(401, 'Требуется авторизация');

        Yii::app()->user->setReturnUrl(Yii::app()->request->requestUri);
        $this->redirect(Yii::app()->baseUrl . '/base');
      }
    }

    if( in_array($action->id, array('index')) )
    {
      $url = Yii::app()->request->url;
      Yii::app()->user->setState($this->uniqueId, $url);
    }

    if( Yii::app()->request->getQuery('popup', false) )
    {
      $this->popup  = true;
      $this->layout = '//layouts/popup';
    }

    Yii::app()->registerAjaxUpdateError();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

    return parent::beforeAction($action);
  }

  public function getBackUrl()
  {
    $url = Yii::app()->user->getState($this->uniqueId);
    if( !$url )
      $url = Yii::app()->createUrl($this->module->id.'/'.$this->id);

    return Utils::cutQueryParams($url, array('ajax'));
  }

  public function actions()
  {
    return array(
      'delete' => 'BDefaultActionDelete',
      'deleteRelated' => 'BRelatedActionDelete',
      'association' => 'BSaveAssociationAction',
      'switch' => 'ext.jtogglecolumn.SwitchAction',
      'toggle' => 'ext.jtogglecolumn.ToggleAction',
      'onflyedit' => 'ext.onflyedit.OnFlyEditAction',
      'upload' => 'upload.actions.UploadAction',
      'directory' => 'backend.modules.directory.actions.DirectoryAction',
    );
  }

  /**
   * Делаем редирект.
   * Если приложение запущено с тестовым конфигом, то бросаем эксепшн
   *
   * @param mixed $url
   * @param bool $terminate
   * @param integer $statusCode
   *
   * @throws BTestRedirectException
   */
  public function redirect($url, $terminate = true, $statusCode = 302)
  {
    if( Yii::app()->params['mode'] === 'test' )
    {
      throw new BTestRedirectException(200, 'Location: '.$url, $statusCode);
    }
    else
    {
      parent::redirect($url, $terminate, $statusCode);
    }
  }

  /**
   * @param string $view
   * @param null   $data
   * @param bool   $return
   *
   * @return string|void
   */
  public function render($view, $data = null, $return = false)
  {
    if( Yii::app()->params['mode'] === 'test' )
    {
      Yii::app()->user->setFlash('render', $data);
    }
    else
    {
      parent::render($view, $data, $return);
    }
  }

  /**
   * @param $id
   * @param string $modelClass
   *
   * @return mixed
   * @throws CHttpException
   */
  public function loadModel($id, $modelClass = null)
  {
    $class = $modelClass ? $modelClass : $this->modelClass;
    $model = $class::model()->findByPk($id);

    if( $model === null )
      throw new CHttpException(404, 'The requested page does not exist.');

    return $model;
  }

  public function actionIndex()
  {
    $model = $this->createFilterModel();

    $this->render('index', array(
      'model' => $model,
      'dataProvider' => $model->search(),
    ));
  }

  public function actionCreate()
  {
    $model = new $this->modelClass;
    $model->attributes = Yii::app()->request->getQuery(get_class($model));
    $this->actionSave($model);
  }

  /**
   * @param $id
   */
  public function actionUpdate($id)
  {
    $this->actionSave($this->loadModel($id));
  }

  public function isUpdate()
  {
    return $this->action->id == 'update' ? true : false;
  }

  /**
   * Стандартный автокомплит для моделей
   *
   * $_GET['model'] - название модели для поиска
   * $_GET['field'] - поле для поиска
   * $_GET['q']     - значение
   *
   * @return void
   */
  public function actionAutocomplete()
  {
    if( !Yii::app()->request->isAjaxRequest )
      return;

    $modelClass = Yii::app()->request->getParam('model');
    $field      = Yii::app()->request->getParam('field');
    $value      = Yii::app()->request->getParam('q');

    if( $modelClass && $field && $value )
    {
      $criteria = new CDbCriteria();
      $criteria->addSearchCondition($field, $value);
      $criteria->limit = 10;

      $data   = $modelClass::model()->findAll($criteria);
      $answer = array();

      foreach( $data as $item )
        if( !in_array($item->$field, $answer) )
          $answer[] = $item->$field;

      echo implode("\n", $answer);
    }
  }

  /**
   * @return BActiveRecord
   */
  protected function createFilterModel()
  {
    $attributes = Yii::app()->request->getQuery($this->modelClass);
    $model = new $this->modelClass('search');
    $model->unsetAttributes();

    if( !empty($attributes) )
      $model->attributes = $attributes;

    return $model;
  }

  /**
   * @param BActiveRecord $model
   */
  protected function saveModel($model)
  {
    $this->performAjaxValidation($model);
    $attributes = Yii::app()->request->getPost(get_class($model));

    if( isset($attributes) )
    {
      $model->setAttributes($attributes);

      if( $model->save() )
      {
        $this->redirectAfterSave($model);
      }
    }
  }

  /**
   * Проводим валидацию и сохраняем несколько связанных моделей
   * Все модели должны быть связаны по первичному ключу
   *
   * @param BActiveRecord[] $models
   * @param bool $extendedSave пытаемся сохранить все данные post, вызывая соответствующие методы контроллера
   * @param bool $redirectToUpdate перенаправление на action update
   *
   * @throws CDbException
   * @throws CHttpException
   */
  protected function saveModels($models, $extendedSave = true, $redirectToUpdate = true)
  {
    $this->performAjaxValidationForSeveralModels($models);

    if( Yii::app()->request->isPostRequest && $this->validateModels($models) )
    {
      Yii::app()->db->beginTransaction();

      $modelNames   = array_map(function($data){return get_class($data);}, $models);
      $unsavedKeys  = array_diff(array_keys($_POST), $modelNames);
      $primaryModel = $models[0];

      foreach($models as $key => $model)
      {
        if( $key !== 0 )
          $model->setPrimaryKey($primaryModel->getPrimaryKey());

        if( !$model->save(false) )

        {
          Yii::app()->db->currentTransaction->rollback();
          throw new CHttpException(500, 'Can`t save '.get_class($model).' model');
        }
      }

      if( $extendedSave )
      {
        $resultSaveMaximumPostData = $this->saveMaximumPostData($unsavedKeys, $primaryModel);

        if( !$resultSaveMaximumPostData )
        {
          Yii::app()->db->currentTransaction->rollback();
          return;
        }
      }

      Yii::app()->db->currentTransaction->commit();

      if( $redirectToUpdate )
        $this->redirectAfterSave($primaryModel);
    }
  }

  /**
   * @param BActiveRecord[] $models
   *
   * @return bool
   */
  protected function validateModels($models)
  {
    $valid = !empty($models);

    foreach($models as $model)
    {
      $post = Yii::app()->request->getPost(get_class($model));
      $model->setAttributes($post);
      $valid = $model->validate() && $valid && !empty($post) && $this->validateRelatedModels($model);
    }

    return $valid;
  }

  /**
   * @param BActiveRecord $model
   *
   * @return bool
   */
  protected function validateRelatedModels($model)
  {
    $success = true;

    foreach($this->getModelsAllowedForSave() as $relationName => $modelName)
    {
      if( !($postData = Yii::app()->request->getPost($modelName, null)) )
        continue;

      $models = $model->prepareModels($relationName, $postData);
      $success = $model->validateRelatedModels($models);

      if( !$success )
        break;
    }

    return $success;
  }

  /**
   * @param BActiveRecord $model
   */
  protected function redirectAfterSave($model)
  {
    Yii::app()->user->setFlash('success', 'Запись успешно '.($model->isNewRecord ? 'создана' : 'сохранена').'.');

    if( Yii::app()->request->getParam('action') )
      $this->redirect($this->getBackUrl());
    else
    {
      $redirectData = CMap::mergeArray(array('id' => $model->getPrimaryKey()), $_GET);
      $redirectUrl  = $this->createUrl($this->id.'/update', $redirectData);

      $this->redirect($redirectUrl);
    }
  }

  /**
   * @param BActiveRecord $model
   */
  protected function actionSave($model)
  {
    $this->saveModels(array($model));
    $this->render('_form', array('model' => $model));
  }

  /**
   * Performs the AJAX validation.
   *
   * @param BActiveRecord $model the model to be validated
   */
  protected function performAjaxValidation($model)
  {
    if( Yii::app()->request->getPost('ajax') === $model->getFormId() )
    {
      echo CActiveForm::validate($model);
      Yii::app()->end();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
  }

  /**
   * @param BActiveRecord[] $models
   */
  protected function performAjaxValidationForSeveralModels($models)
  {
    if( Yii::app()->request->getPost('ajax') === $models[0]->getFormId() )
    {
      $result = array();

      foreach($models as $model)
      {
        $errors = CJavaScript::jsonDecode(CActiveForm::validate($model));
        $result = CMap::mergeArray($result, $errors);
      }

      echo CJavaScript::jsonEncode($result);
      Yii::app()->end();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
  }

  /**
   * Проверям наличие в контроллере методов, чтобы сохранить данные из post
   *
   * @param array $unsavedKeys
   * @param BActiveRecord $primaryModel
   *
   * @return bool
   */
  protected function saveMaximumPostData(array $unsavedKeys, BActiveRecord $primaryModel)
  {
    foreach($unsavedKeys as $key)
    {
      $method = 'save'.$key;
      $data = Yii::app()->request->getPost($key);

      if( empty($data) || !is_array($data) || !in_array($key, $this->getModelsAllowedForSave()) )
        continue;

      if( method_exists($this, $method) )
        $result = call_user_func_array(array($this, $method), array($data, $primaryModel));
      else
        $result = $primaryModel->saveRelatedModels(array_search($key, $this->getModelsAllowedForSave()), $data);

      if( !$result )
        return false;
    }

    return true;
  }

  /**
   * Возвращает массив разрешенных для сохнанеия релейшенов в формате 'relationName' => 'postPrefix'
   * пример: array('variants' => 'BProductParamVariant').
   * Если в котроллере есть метод с именем save{postPrefix}($data, BActiveRecord $parentModel),
   * то для сохнания данных $_POST[{postPrefix}} будет вызван он.
   *
   * @return array
   */
  protected function getModelsAllowedForSave()
  {
    return array();
  }
}

GitHub Access Token became invalid

BController F
last analyzed 2020-09-24 13:50 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

25 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

Available Fixes

1			<?php
2			/**
3			* @author Sergey Glagolev <[email protected]>, Nikita Melnikov <[email protected]>
4			* @link https://github.com/shogodev/argilla/
5			* @copyright Copyright © 2003-2014 Shogo
6			* @license http://argilla.ru/LICENSE
7			* @package backend.controllers
8			*
9			* @property BModule $module
10			* @mixin TextBlockBehavior
11			* @mixin CommonBehavior
12			*/
13			abstract class BController extends CController
14			{
15			public $enabled = true;
16
17			public $position = 0;
18
19			public $name = '[Не задано]';
20
21			public $layout = '//layouts/column1';
22
23			/**
24			* @var array
25			*/
26			public $breadcrumbs = array();
27
28			public $modelClass = 'BActiveRecord';
29
30			public $popup = false;
31
32			public $moduleMenu;
33
34			public $showInMenu = true;
35
36	40		public function behaviors()
37			{
38			return array(
39	40		'textBlock' => array('class' => 'TextBlockBehavior'),
40	40		'common' => array('class' => 'CommonBehavior'),
41	40		);
42			}
43
44			public function getViewPath()
45			{
46			if( ($module = $this->getModule()) === null )
47			$module = Yii::app();
48
49			$mappedId = array_search(get_class($this), $module->controllerMap);
50			$id = $mappedId ? $mappedId : $this->getId();
51
52			$submoduleViewPath = $module->getViewPath().DIRECTORY_SEPARATOR.$id;
53
54			return file_exists($submoduleViewPath) ? $submoduleViewPath : $module->getViewPath();
55			}
56
57			public function filters()
58			{
59			return array(
60			'postOnly + delete',
61			);
62			}
63
64	1		public function beforeAction($action)
65			{
66	1		if( !AccessHelper::checkAccessByClasses($this->module, $this) )
67	1		{
68	1		if( !Yii::app()->user->isGuest )
69	1		throw new CHttpException(403, 'Доступ запрещен.');
70			else
71			{
72	1		if( Yii::app()->request->isAjaxRequest )
73	1		throw new CHttpException(401, 'Требуется авторизация');
74
75	1		Yii::app()->user->setReturnUrl(Yii::app()->request->requestUri);
76	1		$this->redirect(Yii::app()->baseUrl . '/base');
77			}
78			}
79
80			if( in_array($action->id, array('index')) )
81			{
82			$url = Yii::app()->request->url;
83			Yii::app()->user->setState($this->uniqueId, $url);
84			}
85
86			if( Yii::app()->request->getQuery('popup', false) )
87			{
88			$this->popup = true;
89			$this->layout = '//layouts/popup';
90			}
91
92			Yii::app()->registerAjaxUpdateError();
			0 ignored issues – show Bug introduced 2016-08-17 11:45 UTC by Report Bug Copy Issue Report The method `registerAjaxUpdateError` does only exist in `BApplication and BTestApplication`, but not in `FApplication and FTestApplication`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
93
94			return parent::beforeAction($action);
95			}
96
97	1		public function getBackUrl()
98			{
99	1		$url = Yii::app()->user->getState($this->uniqueId);
100	1		if( !$url )
101	1		$url = Yii::app()->createUrl($this->module->id.'/'.$this->id);
102
103	1		return Utils::cutQueryParams($url, array('ajax'));
104			}
105
106	6		public function actions()
107			{
108			return array(
109	6		'delete' => 'BDefaultActionDelete',
110	6		'deleteRelated' => 'BRelatedActionDelete',
111	6		'association' => 'BSaveAssociationAction',
112	6		'switch' => 'ext.jtogglecolumn.SwitchAction',
113	6		'toggle' => 'ext.jtogglecolumn.ToggleAction',
114	6		'onflyedit' => 'ext.onflyedit.OnFlyEditAction',
115	6		'upload' => 'upload.actions.UploadAction',
116	6		'directory' => 'backend.modules.directory.actions.DirectoryAction',
117	6		);
118			}
119
120			/**
121			* Делаем редирект.
122			* Если приложение запущено с тестовым конфигом, то бросаем эксепшн
123			*
124			* @param mixed $url
125			* @param bool $terminate
126			* @param integer $statusCode
127			*
128			* @throws BTestRedirectException
129			*/
130	4		public function redirect($url, $terminate = true, $statusCode = 302)
131			{
132	4		if( Yii::app()->params['mode'] === 'test' )
133	4		{
134	4		throw new BTestRedirectException(200, 'Location: '.$url, $statusCode);
135			}
136			else
137			{
138			parent::redirect($url, $terminate, $statusCode);
139			}
140			}
141
142			/**
143			* @param string $view
144			* @param null $data
145			* @param bool $return
146			*
147			* @return string\|void
148			*/
149	1		public function render($view, $data = null, $return = false)
150			{
151	1		if( Yii::app()->params['mode'] === 'test' )
152	1		{
153	1		Yii::app()->user->setFlash('render', $data);
154	1		}
155			else
156			{
157			parent::render($view, $data, $return);
158			}
159	1		}
160
161			/**
162			* @param $id
163			* @param string $modelClass
164			*
165			* @return mixed
166			* @throws CHttpException
167			*/
168	8		public function loadModel($id, $modelClass = null)
169			{
170	8		$class = $modelClass ? $modelClass : $this->modelClass;
171	8		$model = $class::model()->findByPk($id);
172
173	8		if( $model === null )
174	8		throw new CHttpException(404, 'The requested page does not exist.');
175
176	7		return $model;
177			}
178
179	1		public function actionIndex()
180			{
181	1		$model = $this->createFilterModel();
182
183	1		$this->render('index', array(
184	1		'model' => $model,
185	1		'dataProvider' => $model->search(),
186	1		));
187	1		}
188
189			public function actionCreate()
190			{
191			$model = new $this->modelClass;
192			$model->attributes = Yii::app()->request->getQuery(get_class($model));
193			$this->actionSave($model);
194			}
195
196			/**
197			* @param $id
198			*/
199			public function actionUpdate($id)
200			{
201			$this->actionSave($this->loadModel($id));
202			}
203
204			public function isUpdate()
205			{
206			return $this->action->id == 'update' ? true : false;
207			}
208
209			/**
210			* Стандартный автокомплит для моделей
211			*
212			* $_GET['model'] - название модели для поиска
213			* $_GET['field'] - поле для поиска
214			* $_GET['q'] - значение
215			*
216			* @return void
217			*/
218			public function actionAutocomplete()
219			{
220			if( !Yii::app()->request->isAjaxRequest )
221			return;
222
223			$modelClass = Yii::app()->request->getParam('model');
224			$field = Yii::app()->request->getParam('field');
225			$value = Yii::app()->request->getParam('q');
226
227			if( $modelClass && $field && $value )
228			{
229			$criteria = new CDbCriteria();
230			$criteria->addSearchCondition($field, $value);
231			$criteria->limit = 10;
232
233			$data = $modelClass::model()->findAll($criteria);
234			$answer = array();
235
236			foreach( $data as $item )
237			if( !in_array($item->$field, $answer) )
238			$answer[] = $item->$field;
239
240			echo implode("\n", $answer);
241			}
242			}
243
244			/**
245			* @return BActiveRecord
246			*/
247	1		protected function createFilterModel()
248			{
249	1		$attributes = Yii::app()->request->getQuery($this->modelClass);
250	1		$model = new $this->modelClass('search');
251	1		$model->unsetAttributes();
252
253	1		if( !empty($attributes) )
254	1		$model->attributes = $attributes;
255
256	1		return $model;
257			}
258
259			/**
260			* @param BActiveRecord $model
261			*/
262	1		protected function saveModel($model)
263			{
264	1		$this->performAjaxValidation($model);
265	1		$attributes = Yii::app()->request->getPost(get_class($model));
266
267	1		if( isset($attributes) )
268	1		{
269	1		$model->setAttributes($attributes);
270
271	1		if( $model->save() )
272	1		{
273	1		$this->redirectAfterSave($model);
274			}
275			}
276			}
277
278			/**
279			* Проводим валидацию и сохраняем несколько связанных моделей
280			* Все модели должны быть связаны по первичному ключу
281			*
282			* @param BActiveRecord[] $models
283			* @param bool $extendedSave пытаемся сохранить все данные post, вызывая соответствующие методы контроллера
284			* @param bool $redirectToUpdate перенаправление на action update
285			*
286			* @throws CDbException
287			* @throws CHttpException
288			*/
289	1		protected function saveModels($models, $extendedSave = true, $redirectToUpdate = true)
290			{
291	1		$this->performAjaxValidationForSeveralModels($models);
292
293	1		if( Yii::app()->request->isPostRequest && $this->validateModels($models) )
294	1		{
295	1		Yii::app()->db->beginTransaction();
296
297			$modelNames = array_map(function($data){return get_class($data);}, $models);
298	1		$unsavedKeys = array_diff(array_keys($_POST), $modelNames);
299	1		$primaryModel = $models[0];
300
301	1		foreach($models as $key => $model)
302			{
303	1		if( $key !== 0 )
304	1		$model->setPrimaryKey($primaryModel->getPrimaryKey());
305
306	1	View Code Duplication	if( !$model->save(false) )
			0 ignored issues – show Duplication introduced 2015-11-25 11:59 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
307	1		{
308			Yii::app()->db->currentTransaction->rollback();
309			throw new CHttpException(500, 'Can`t save '.get_class($model).' model');
310			}
311	1		}
312
313			if( $extendedSave )
314	1		{
315	1		$resultSaveMaximumPostData = $this->saveMaximumPostData($unsavedKeys, $primaryModel);
316
317	1		if( !$resultSaveMaximumPostData )
318	1		{
319			Yii::app()->db->currentTransaction->rollback();
320			return;
321			}
322	1		}
323
324	1		Yii::app()->db->currentTransaction->commit();
325
326			if( $redirectToUpdate )
327	1		$this->redirectAfterSave($primaryModel);
328			}
329			}
330
331			/**
332			* @param BActiveRecord[] $models
333			*
334			* @return bool
335			*/
336	2		protected function validateModels($models)
337			{
338	2		$valid = !empty($models);
339
340	2		foreach($models as $model)
341			{
342	2		$post = Yii::app()->request->getPost(get_class($model));
343	2		$model->setAttributes($post);
344	2		$valid = $model->validate() && $valid && !empty($post) && $this->validateRelatedModels($model);
345	2		}
346
347	2		return $valid;
348			}
349
350			/**
351			* @param BActiveRecord $model
352			*
353			* @return bool
354			*/
355	2		protected function validateRelatedModels($model)
356			{
357	2		$success = true;
358
359	2		foreach($this->getModelsAllowedForSave() as $relationName => $modelName)
360			{
361			if( !($postData = Yii::app()->request->getPost($modelName, null)) )
362			continue;
363
364			$models = $model->prepareModels($relationName, $postData);
365			$success = $model->validateRelatedModels($models);
366
367			if( !$success )
368			break;
369	2		}
370
371	2		return $success;
372			}
373
374			/**
375			* @param BActiveRecord $model
376			*/
377	2		protected function redirectAfterSave($model)
378			{
379	2		Yii::app()->user->setFlash('success', 'Запись успешно '.($model->isNewRecord ? 'создана' : 'сохранена').'.');
380
381	2		if( Yii::app()->request->getParam('action') )
382	2		$this->redirect($this->getBackUrl());
383			else
384			{
385	2		$redirectData = CMap::mergeArray(array('id' => $model->getPrimaryKey()), $_GET);
386	2		$redirectUrl = $this->createUrl($this->id.'/update', $redirectData);
387
388	2		$this->redirect($redirectUrl);
389			}
390			}
391
392			/**
393			* @param BActiveRecord $model
394			*/
395			protected function actionSave($model)
396			{
397			$this->saveModels(array($model));
398			$this->render('_form', array('model' => $model));
399			}
400
401			/**
402			* Performs the AJAX validation.
403			*
404			* @param BActiveRecord $model the model to be validated
405			*/
406	3		protected function performAjaxValidation($model)
407			{
408	3		if( Yii::app()->request->getPost('ajax') === $model->getFormId() )
409	3		{
410	2		echo CActiveForm::validate($model);
411	2		Yii::app()->end();
			0 ignored issues – show Bug introduced 2016-08-17 11:45 UTC by Report Bug Copy Issue Report The method `end` does only exist in `BTestApplication and FTestApplication`, but not in `BApplication and FApplication`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
412			}
413	1		}
414
415			/**
416			* @param BActiveRecord[] $models
417			*/
418	3		protected function performAjaxValidationForSeveralModels($models)
419			{
420	3		if( Yii::app()->request->getPost('ajax') === $models[0]->getFormId() )
421	3		{
422	2		$result = array();
423
424	2		foreach($models as $model)
425			{
426	2		$errors = CJavaScript::jsonDecode(CActiveForm::validate($model));
427	2		$result = CMap::mergeArray($result, $errors);
428	2		}
429
430	2		echo CJavaScript::jsonEncode($result);
431	2		Yii::app()->end();
			0 ignored issues – show Bug introduced 2016-08-17 11:45 UTC by Report Bug Copy Issue Report The method `end` does only exist in `BTestApplication and FTestApplication`, but not in `BApplication and FApplication`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
432			}
433	1		}
434
435			/**
436			* Проверям наличие в контроллере методов, чтобы сохранить данные из post
437			*
438			* @param array $unsavedKeys
439			* @param BActiveRecord $primaryModel
440			*
441			* @return bool
442			*/
443	1		protected function saveMaximumPostData(array $unsavedKeys, BActiveRecord $primaryModel)
444			{
445	1		foreach($unsavedKeys as $key)
446			{
447			$method = 'save'.$key;
448			$data = Yii::app()->request->getPost($key);
449
450			if( empty($data) \|\| !is_array($data) \|\| !in_array($key, $this->getModelsAllowedForSave()) )
451			continue;
452
453			if( method_exists($this, $method) )
454			$result = call_user_func_array(array($this, $method), array($data, $primaryModel));
455			else
456			$result = $primaryModel->saveRelatedModels(array_search($key, $this->getModelsAllowedForSave()), $data);
457
458			if( !$result )
459			return false;
460	1		}
461
462	1		return true;
463			}
464
465			/**
466			* Возвращает массив разрешенных для сохнанеия релейшенов в формате 'relationName' => 'postPrefix'
467			* пример: array('variants' => 'BProductParamVariant').
468			* Если в котроллере есть метод с именем save{postPrefix}($data, BActiveRecord $parentModel),
469			* то для сохнания данных $_POST[{postPrefix}} будет вызван он.
470			*
471			* @return array
472			*/
473	2		protected function getModelsAllowedForSave()
474			{
475	2		return array();
476			}
477			}

shogodev / argilla

GitHub Access Token became invalid

BController F last analyzed 2020-09-24 13:50 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

25 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

BController F
last analyzed 2020-09-24 13:50 UTC