Passed
Pull Request — master (#1)
by Max
04:22
created
src/Type/Definition/UserErrorsType.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
         GraphQL\Utils\Utils::invariant($config['type'] instanceof Type, 'Must provide type.');
27 27
 
28 28
         if (isset($config['errorCodes'])) {
29
-        	if(isset($config['validate'])) {
29
+        	if (isset($config['validate'])) {
30 30
 		        /** code property */
31 31
 		        $finalFields['code'] = [
32 32
 			        'type' => $this->_set(new EnumType([
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 				        'values' => $config['errorCodes'],
36 36
 			        ]), $config),
37 37
 			        'description' => 'An error code',
38
-			        'resolve' => static function ($value) {
38
+			        'resolve' => static function($value) {
39 39
 				        return $value['error'][0] ?? null;
40 40
 			        },
41 41
 		        ];
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
 		        $finalFields['msg'] = [
47 47
 			        'type' => Type::string(),
48 48
 			        'description' => 'A natural language description of the issue',
49
-			        'resolve' => static function ($value) {
49
+			        'resolve' => static function($value) {
50 50
 				        return $value['error'][1] ?? null;
51 51
 			        },
52 52
 		        ];
@@ -60,18 +60,18 @@  discard block
 block discarded – undo
60 60
             $fields = [];
61 61
             foreach ($type->getFields() as $key => $field) {
62 62
                 $newType = static::create(
63
-                    $field->config + ['typeSetter' => $config['typeSetter'] ?? null],
63
+                    $field->config+['typeSetter' => $config['typeSetter'] ?? null],
64 64
                     array_merge($path, [$key])
65 65
                 );
66 66
 
67
-                if (! $newType) {
67
+                if (!$newType) {
68 68
                     continue;
69 69
                 }
70 70
 
71 71
                 $fields[$key] = [
72 72
                     'description' => 'Error for ' . $key,
73 73
                     'type' => $newType,
74
-                    'resolve' => static function ($value) use ($key) {
74
+                    'resolve' => static function($value) use ($key) {
75 75
                         return $value[$key] ?? null;
76 76
                     },
77 77
                 ];
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
                         'fields' => $fields,
89 89
                     ]), $config),
90 90
                     'description' => 'Suberrors for ' . ucfirst($path[count($path)-1]),
91
-                    'resolve' => static function (array $value) {
91
+                    'resolve' => static function(array $value) {
92 92
                         return $value['suberrors'] ?? null;
93 93
                     },
94 94
                 ];
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
                 $finalFields['suberrors'] = [
113 113
                     'description' => 'Suberrors for the list of ' . $type->ofType . ' items',
114 114
                     'type' => $newType,
115
-                    'resolve' => static function ($value) {
115
+                    'resolve' => static function($value) {
116 116
                         return $value['suberrors'] ?? null;
117 117
                     },
118 118
                 ];
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
             $finalFields['path'] = [
127 127
                 'type' => Type::listOf(Type::int()),
128 128
                 'description' => 'A path describing this items\'s location in the nested array',
129
-                'resolve' => static function ($value) {
129
+                'resolve' => static function($value) {
130 130
                     return $value['path'];
131 131
                 },
132 132
             ];
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
             $config['fields']['code'] = $config['fields']['code'] ?? [
164 164
                 'type' => Type::int(),
165 165
                 'description' => 'A numeric error code. 0 on success, non-zero on failure.',
166
-                'resolve' => static function ($value) {
166
+                'resolve' => static function($value) {
167 167
                     $error = $value['error'] ?? null;
168 168
                     switch (gettype($error)) {
169 169
                         case 'integer':
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
             $config['fields']['msg'] = $config['fields']['msg'] ?? [
177 177
                 'type' => Type::string(),
178 178
                 'description' => 'An error message.',
179
-                'resolve' => static function ($value) {
179
+                'resolve' => static function($value) {
180 180
                     $error = $value['error'] ?? null;
181 181
                     switch (gettype($error)) {
182 182
                         case 'integer':
Please login to merge, or discard this patch.
tests/Utils.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
         }
23 23
 
24 24
         // Toss out the first and last lines.
25
-        $lines = array_slice($lines, 1, count($lines) - 2);
25
+        $lines = array_slice($lines, 1, count($lines)-2);
26 26
 
27 27
         // take the tabs from the first line, and subtract them from all lines
28 28
         $matches = [];
Please login to merge, or discard this patch.
tests/Type/UserErrorsType/InputObjectTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@  discard block
 block discarded – undo
17 17
 {
18 18
     public function testFieldsWithNoErrorCodes()
19 19
     {
20
-        $type  = new UserErrorsType([
20
+        $type = new UserErrorsType([
21 21
             'type' => new InputObjectType([
22 22
                 'name' => 'bookInput',
23 23
                 'fields' => [
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
     {
48 48
 	    $this->expectExceptionMessage("If you specify errorCodes, you must also provide a validate callback");
49 49
 
50
-	    $type  = new UserErrorsType([
50
+	    $type = new UserErrorsType([
51 51
             'type' => new InputObjectType([
52 52
                 'name' => 'bookInput',
53 53
                 'fields' => [
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
 
64 64
 	public function testFieldsWithValidate()
65 65
 	{
66
-		$type  = new UserErrorsType([
66
+		$type = new UserErrorsType([
67 67
 			'type' => new InputObjectType([
68 68
 				'name' => 'bookInput',
69 69
 				'fields' => [
Please login to merge, or discard this patch.
tests/Type/UserErrorsType/ScalarTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
     {
38 38
         $type = new UserErrorsType([
39 39
             'errorCodes' => ['invalidColor'],
40
-            'validate' => static function ($value) {
40
+            'validate' => static function($value) {
41 41
                 return 0;
42 42
             },
43 43
             'type' => new IDType(['name' => 'Color']),
Please login to merge, or discard this patch.
tests/Type/ValidatedFieldDefinition/ListOfScalarValidationTest.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
             'query' => $this->query,
32 32
             'mutation' => new ObjectType([
33 33
                 'name' => 'Mutation',
34
-                'fields' => static function () {
34
+                'fields' => static function() {
35 35
                     return [
36 36
                         'setPhoneNumbers' => new ValidatedFieldDefinition([
37 37
                             'name' => 'setPhoneNumbers',
@@ -40,20 +40,20 @@  discard block
 block discarded – undo
40 40
                                 'phoneNumbers' => [
41 41
                                     'type' => Type::listOf(Type::listOf(Type::string())),
42 42
                                     'errorCodes' => ['maxNumExceeded'],
43
-                                    'validate' => static function (array $phoneNumbers) {
43
+                                    'validate' => static function(array $phoneNumbers) {
44 44
                                         if (count($phoneNumbers) > 2) {
45 45
                                             return ['maxNumExceeded', 'You may not submit more than 2 lists of phone numbers'];
46 46
                                         }
47 47
                                         return 0;
48 48
                                     },
49 49
                                     'suberrorCodes' => ['invalidPhoneNumber'],
50
-                                    'validateItem' => static function ($phoneNumber) {
50
+                                    'validateItem' => static function($phoneNumber) {
51 51
                                         $res = preg_match('/^[0-9\-]+$/', $phoneNumber) === 1;
52
-                                        return ! $res ? ['invalidPhoneNumber', 'That does not seem to be a valid phone number'] : 0;
52
+                                        return !$res ? ['invalidPhoneNumber', 'That does not seem to be a valid phone number'] : 0;
53 53
                                     },
54 54
                                 ],
55 55
                             ],
56
-                            'resolve' => static function (array $phoneNumbers, $args) : bool {
56
+                            'resolve' => static function(array $phoneNumbers, $args) : bool {
57 57
                                 // ...
58 58
                                 // stash them somewhere
59 59
                                 // ...
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
                             [
111 111
                                 'suberrors' =>
112 112
 	                                [
113
-	                                    'path' => [0,1],
113
+	                                    'path' => [0, 1],
114 114
 	                                    'code' => 'invalidPhoneNumber',
115 115
 	                                ]
116 116
                             ],
@@ -164,18 +164,18 @@  discard block
 block discarded – undo
164 164
 
165 165
         static::assertEmpty($res->errors);
166 166
         static::assertEquals(
167
-	        array (
167
+	        array(
168 168
 		        'valid' => false,
169 169
 		        'suberrors' =>
170
-			        array (
170
+			        array(
171 171
 				        'phoneNumbers' =>
172
-					        array (
172
+					        array(
173 173
 						        'code' => NULL,
174 174
 						        'msg' => NULL,
175 175
 						        'suberrors' =>
176
-							        array (
176
+							        array(
177 177
 								        'path' =>
178
-									        array (
178
+									        array(
179 179
 										        0 => 1,
180 180
 										        1 => 1,
181 181
 									        ),
Please login to merge, or discard this patch.
tests/Type/ValidatedFieldDefinition/ListOfInputObjectValidationTest.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
                 'title' => [
63 63
                     'type' => Type::string(),
64 64
                     'description' => 'Enter a book title, no more than 10 characters in length',
65
-                    'validate' => static function (string $title) {
65
+                    'validate' => static function(string $title) {
66 66
                         if (strlen($title) > 10) {
67 67
                             return [1, 'book title must be less than 10 chaacters'];
68 68
                         }
@@ -76,8 +76,8 @@  discard block
 block discarded – undo
76 76
                         'unknownAuthor',
77 77
                         'authorDeceased',
78 78
                     ],
79
-                    'validate' => function (string $authorId) {
80
-                        if (! isset($this->data['people'][$authorId])) {
79
+                    'validate' => function(string $authorId) {
80
+                        if (!isset($this->data['people'][$authorId])) {
81 81
                             return ['unknownAuthor', 'We have no record of that author'];
82 82
                         }
83 83
                         return 0;
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
             'query' => $this->query,
93 93
             'mutation' => new ObjectType([
94 94
                 'name' => 'Mutation',
95
-                'fields' => function () {
95
+                'fields' => function() {
96 96
                     return [
97 97
                         'updateBooks' => new ValidatedFieldDefinition([
98 98
                             'name' => 'updateBooks',
@@ -104,12 +104,12 @@  discard block
 block discarded – undo
104 104
                         	            $i = 5;
105 105
 	                                },
106 106
 	                                'validateItem' => static function($book) {
107
-                        	            $res = isset($book['author']) || isset($book['title']) ? 0: 1;
107
+                        	            $res = isset($book['author']) || isset($book['title']) ? 0 : 1;
108 108
                         	            return $res;
109 109
 	                                }
110 110
                                 ],
111 111
                             ],
112
-                            'resolve' => static function ($value) : bool {
112
+                            'resolve' => static function($value) : bool {
113 113
                                 // ...
114 114
                                 // do update
115 115
                                 // ...
@@ -169,21 +169,21 @@  discard block
 block discarded – undo
169 169
 	    static::assertEmpty($res->errors);
170 170
 
171 171
         static::assertEquals(
172
-	        array (
172
+	        array(
173 173
 		        'valid' => false,
174 174
 		        'result' => NULL,
175 175
 		        'suberrors' =>
176
-			        array (
176
+			        array(
177 177
 				        'bookAttributes' =>
178
-					        array (
178
+					        array(
179 179
 						        'code' => NULL,
180 180
 						        'msg' => NULL,
181 181
 						        'suberrors' =>
182
-							        array (
182
+							        array(
183 183
 								        'code' => 1,
184 184
 								        'msg' => '',
185 185
 								        'path' =>
186
-									        array (
186
+									        array(
187 187
 										        0 => 1,
188 188
 									        ),
189 189
 							        ),
Please login to merge, or discard this patch.
src/Type/Definition/ValidatedFieldDefinition.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
 
29 29
         $this->typeSetter = $config['typeSetter'] ?? null;
30 30
 
31
-        if (! isset($config['type'])) {
31
+        if (!isset($config['type'])) {
32 32
             throw new Exception('You must specify a type for your field');
33 33
         }
34 34
 
@@ -38,14 +38,14 @@  discard block
 block discarded – undo
38 38
                 'result' => [
39 39
                     'type' => $config['type'],
40 40
                     'description' => 'The payload, if any',
41
-                    'resolve' => static function ($value) {
41
+                    'resolve' => static function($value) {
42 42
                         return $value['result'] ?? null;
43 43
                     },
44 44
                 ],
45 45
                 'valid' => [
46 46
                     'type' => Type::nonNull(Type::boolean()),
47 47
                     'description' => 'Whether all validation passed. True for yes, false for no.',
48
-                    'resolve' => static function ($value) {
48
+                    'resolve' => static function($value) {
49 49
                         return $value['valid'];
50 50
                     },
51 51
                 ],
@@ -62,17 +62,17 @@  discard block
 block discarded – undo
62 62
             'type' => $type,
63 63
             'args' => $args,
64 64
             'name' => $name,
65
-            'resolve' => function ($value, $args1, $context, $info) use ($config, $args) {
65
+            'resolve' => function($value, $args1, $context, $info) use ($config, $args) {
66 66
                 // validate inputs
67
-                $config['type']  = new InputObjectType([
67
+                $config['type'] = new InputObjectType([
68 68
                     'name'=>'',
69 69
                     'fields' => $args,
70 70
                 ]);
71 71
                 $errors          = $this->_validate($config, $args1);
72 72
                 $result          = $errors;
73
-                $result['valid'] = ! $errors;
73
+                $result['valid'] = !$errors;
74 74
 
75
-                if (! isset($result['error']) && ! isset($result['suberrors'])) {
75
+                if (!isset($result['error']) && !isset($result['suberrors'])) {
76 76
                     $result['result'] = $config['resolve']($value, $args1, $context, $info);
77 77
                 }
78 78
 
@@ -84,19 +84,19 @@  discard block
 block discarded – undo
84 84
 	protected function _isAssoc(array $arr)
85 85
 	{
86 86
 		if (array() === $arr) return false;
87
-		return array_keys($arr) !== range(0, count($arr) - 1);
87
+		return array_keys($arr) !== range(0, count($arr)-1);
88 88
 	}
89 89
 
90 90
     protected function _validateItems($value, array $path, callable $validate) {
91 91
         foreach ($value as $idx => $subValue) {
92
-            if(is_array($subValue) && !$this->_isAssoc($subValue)) {
92
+            if (is_array($subValue) && !$this->_isAssoc($subValue)) {
93 93
                 $path[count($path)-1] = $idx;
94 94
                 $newPath = $path;
95 95
                 $newPath[] = 0;
96 96
                 $this->_validateItems($subValue, $newPath, $validate);
97 97
             }
98 98
             else {
99
-                $path[count($path) - 1] = $idx;
99
+                $path[count($path)-1] = $idx;
100 100
                 $err = $validate($subValue);
101 101
 
102 102
                 if ($err) {
@@ -124,11 +124,11 @@  discard block
 block discarded – undo
124 124
                     }
125 125
                 }
126 126
 
127
-                if(isset($arg['validateItem'])) {
127
+                if (isset($arg['validateItem'])) {
128 128
                     try {
129 129
                         $this->_validateItems($value, [0], $arg['validateItem']);
130 130
                     }
131
-                    catch(ValidateItemsError $e) {
131
+                    catch (ValidateItemsError $e) {
132 132
                         $res['suberrors'] = [
133 133
                             'error' => $e->error,
134 134
                             'path' => $e->path
Please login to merge, or discard this patch.
tests/Type/UserErrorsType/ListOfTest.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
         $type = new UserErrorsType([
39 39
             'type' => Type::listOf(Type::id()),
40 40
             'errorCodes'=> ['atLeastOneRequired'],
41
-            'validate' => static function ($value) {
41
+            'validate' => static function($value) {
42 42
                 return 0;
43 43
             },
44 44
         ], ['users']);
@@ -70,10 +70,10 @@  discard block
 block discarded – undo
70 70
         $type = new UserErrorsType([
71 71
             'type' => Type::listOf(Type::listOf(Type::listOf(Type::id()))),
72 72
             'errorCodes'=> ['atLeastOneRequired'],
73
-            'validate' => static function ($value) {
73
+            'validate' => static function($value) {
74 74
                 return 0;
75 75
             },
76
-            'validateItem' => static function ($value) {
76
+            'validateItem' => static function($value) {
77 77
                 return 0;
78 78
             }
79 79
         ], ['users']);
@@ -117,9 +117,9 @@  discard block
 block discarded – undo
117 117
 
118 118
     public function testListOfInputObjectWithValidationOnSelf()
119 119
     {
120
-        $type  = new UserErrorsType([
120
+        $type = new UserErrorsType([
121 121
 	        'validate' => static function(array $authors) {
122
-        	    if(count($authors) < 1) {
122
+        	    if (count($authors) < 1) {
123 123
         	    	return ['atLeastOneAuthorRequired', "You must submit at least one author"];
124 124
 	            }
125 125
 	        },
@@ -161,10 +161,10 @@  discard block
 block discarded – undo
161 161
 
162 162
 	public function testListOfInputObjectWithValidationOnWrappedSelf()
163 163
 	{
164
-		$type  = new UserErrorsType([
164
+		$type = new UserErrorsType([
165 165
 			'suberrorCodes' => ['firstNameOrLastNameRequired'],
166 166
 			'validateItem' => static function(array $author) {
167
-				if(!isset($author['firstName']) && !isset($author['lastName'])) {
167
+				if (!isset($author['firstName']) && !isset($author['lastName'])) {
168 168
 					return ['atLeastOneAuthorRequired', "You must submit a first name or a last name"];
169 169
 				}
170 170
 			},
Please login to merge, or discard this patch.