Failed Conditions
Pull Request — master (#1)
by Max
04:36
created
src/Type/Definition/UserErrorsType.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -20,18 +20,18 @@  discard block
 block discarded – undo
20 20
      * @param mixed[]  $config
21 21
      * @param string[] $path
22 22
      */
23
-    public function __construct(array $config, array $path, $isParentList = false)
23
+    public function __construct (array $config, array $path, $isParentList = false)
24 24
     {
25 25
         $finalFields = $config['fields'] ?? [];
26 26
 
27
-        if (! isset($config['type'])) {
27
+        if (!isset($config['type'])) {
28 28
             throw new Exception('You must specify a type for your field');
29 29
         }
30 30
 
31 31
         GraphQL\Utils\Utils::invariant($config['type'] instanceof Type, 'Must provide type.');
32 32
 
33 33
         if (isset($config['errorCodes'])) {
34
-            if (! isset($config['validate'])) {
34
+            if (!isset($config['validate'])) {
35 35
                 throw new Exception('If you specify errorCodes, you must also provide a validate callback');
36 36
             }
37 37
 
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
                     'values' => $config['errorCodes'],
44 44
                 ]), $config),
45 45
                 'description' => 'An error code',
46
-                'resolve' => static function ($value) {
46
+                'resolve' => static function($value) {
47 47
                     return $value['error'][0] ?? null;
48 48
                 },
49 49
             ];
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
             $finalFields['msg'] = [
55 55
                 'type' => Type::string(),
56 56
                 'description' => 'A natural language description of the issue',
57
-                'resolve' => static function ($value) {
57
+                'resolve' => static function($value) {
58 58
                     return $value['error'][1] ?? null;
59 59
                 },
60 60
             ];
@@ -65,18 +65,18 @@  discard block
 block discarded – undo
65 65
             $fields = [];
66 66
             foreach ($type->getFields() as $key => $field) {
67 67
                 $newType = static::create(
68
-                    $field->config + ['typeSetter' => $config['typeSetter'] ?? null],
68
+                    $field->config+['typeSetter' => $config['typeSetter'] ?? null],
69 69
                     array_merge($path, [$key])
70 70
                 );
71 71
 
72
-                if (! $newType) {
72
+                if (!$newType) {
73 73
                     continue;
74 74
                 }
75 75
 
76 76
                 $fields[$key] = [
77 77
                     'description' => 'Error for ' . $key,
78 78
                     'type' => $newType,
79
-                    'resolve' => static function ($value) use ($key) {
79
+                    'resolve' => static function($value) use ($key) {
80 80
                         return $value[$key] ?? null;
81 81
                     },
82 82
                 ];
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
                         'fields' => $fields,
94 94
                     ]), $config),
95 95
                     'description' => 'Suberrors for ' . ucfirst($path[count($path)-1]),
96
-                    'resolve' => static function (array $value) {
96
+                    'resolve' => static function(array $value) {
97 97
                         return $value['suberrors'] ?? null;
98 98
                     },
99 99
                 ];
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
                 $finalFields['suberrors'] = [
118 118
                     'description' => 'Suberrors for the list of ' . $type->ofType . ' items',
119 119
                     'type' => $newType,
120
-                    'resolve' => static function ($value) {
120
+                    'resolve' => static function($value) {
121 121
                         return $value['suberrors'] ?? null;
122 122
                     },
123 123
                 ];
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
             $finalFields['path'] = [
132 132
                 'type' => Type::listOf(Type::int()),
133 133
                 'description' => 'A path describing this items\'s location in the nested array',
134
-                'resolve' => static function ($value) {
134
+                'resolve' => static function($value) {
135 135
                     return $value['path'];
136 136
                 },
137 137
             ];
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
      *
150 150
      * @return mixed
151 151
      */
152
-    protected function _set(Type $type, array $config)
152
+    protected function _set (Type $type, array $config)
153 153
     {
154 154
         if (is_callable($config['typeSetter'] ?? null)) {
155 155
             $config['typeSetter']($type);
@@ -166,14 +166,14 @@  discard block
 block discarded – undo
166 166
      *
167 167
      * @throws Exception
168 168
      */
169
-    public static function create(array $config, array $path, bool $isParentList = false, $name = '') : ?self
169
+    public static function create (array $config, array $path, bool $isParentList = false, $name = '') : ?self
170 170
     {
171 171
         $config['fields'] = $config['fields'] ?? [];
172 172
         if (isset($config['validate']) && is_callable($config['validate'])) {
173 173
             $config['fields']['code'] = $config['fields']['code'] ?? [
174 174
                 'type' => Type::int(),
175 175
                 'description' => 'A numeric error code. 0 on success, non-zero on failure.',
176
-                'resolve' => static function ($value) {
176
+                'resolve' => static function($value) {
177 177
                     $error = $value['error'] ?? null;
178 178
                     switch (gettype($error)) {
179 179
                         case 'integer':
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
             $config['fields']['msg'] = $config['fields']['msg'] ?? [
187 187
                 'type' => Type::string(),
188 188
                 'description' => 'An error message.',
189
-                'resolve' => static function ($value) {
189
+                'resolve' => static function($value) {
190 190
                     $error = $value['error'] ?? null;
191 191
                     switch (gettype($error)) {
192 192
                         case 'integer':
@@ -211,7 +211,7 @@  discard block
 block discarded – undo
211 211
     /**
212 212
      * @param string[] $path
213 213
      */
214
-    protected function _nameFromPath(array $path) : string
214
+    protected function _nameFromPath (array $path) : string
215 215
     {
216 216
         return implode('_', array_map('ucfirst', $path));
217 217
     }
Please login to merge, or discard this patch.
src/Type/Definition/ValidatedFieldDefinition.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -183,7 +183,7 @@
 block discarded – undo
183 183
     }
184 184
 
185 185
     /**
186
-     * @return mixed|string|string[]|null
186
+     * @return string
187 187
      *
188 188
      * @throws ReflectionException
189 189
      */
Please login to merge, or discard this patch.
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
     /**
25 25
      * @param mixed[] $config
26 26
      */
27
-    public function __construct($config)
27
+    public function __construct ($config)
28 28
     {
29 29
         $args = $config['args'];
30 30
         $name = $config['name'] ?? lcfirst($this->tryInferName());
@@ -37,14 +37,14 @@  discard block
 block discarded – undo
37 37
                 'result' => [
38 38
                     'type' => $config['type'],
39 39
                     'description' => 'The payload, if any',
40
-                    'resolve' => static function ($value) {
40
+                    'resolve' => static function($value) {
41 41
                         return $value['result'] ?? null;
42 42
                     },
43 43
                 ],
44 44
                 'valid' => [
45 45
                     'type' => Type::nonNull(Type::boolean()),
46 46
                     'description' => 'Whether all validation passed. True for yes, false for no.',
47
-                    'resolve' => static function ($value) {
47
+                    'resolve' => static function($value) {
48 48
                         return $value['valid'];
49 49
                     },
50 50
                 ],
@@ -61,17 +61,17 @@  discard block
 block discarded – undo
61 61
             'type' => $type,
62 62
             'args' => $args,
63 63
             'name' => $name,
64
-            'resolve' => function ($value, $args1, $context, $info) use ($config, $args) {
64
+            'resolve' => function($value, $args1, $context, $info) use ($config, $args) {
65 65
                 // validate inputs
66
-                $config['type']  = new InputObjectType([
66
+                $config['type'] = new InputObjectType([
67 67
                     'name'=>'',
68 68
                     'fields' => $args,
69 69
                 ]);
70 70
                 $errors          = $this->_validate($config, $args1);
71 71
                 $result          = $errors;
72
-                $result['valid'] = ! $errors;
72
+                $result['valid'] = !$errors;
73 73
 
74
-                if (! isset($result['error']) && ! isset($result['suberrors'])) {
74
+                if (!isset($result['error']) && !isset($result['suberrors'])) {
75 75
                     $result['result'] = $config['resolve']($value, $args1, $context, $info);
76 76
                 }
77 77
 
@@ -83,12 +83,12 @@  discard block
 block discarded – undo
83 83
     /**
84 84
      * @param   mixed[] $arr
85 85
      */
86
-    protected function _isAssoc(array $arr) : bool
86
+    protected function _isAssoc (array $arr) : bool
87 87
     {
88 88
         if ($arr === []) {
89 89
             return false;
90 90
         }
91
-        return array_keys($arr) !== range(0, count($arr) - 1);
91
+        return array_keys($arr) !== range(0, count($arr)-1);
92 92
     }
93 93
 
94 94
     /**
@@ -97,16 +97,16 @@  discard block
 block discarded – undo
97 97
      *
98 98
      * @throws  ValidateItemsError
99 99
      */
100
-    protected function _validateItems(array $value, array $path, callable $validate)
100
+    protected function _validateItems (array $value, array $path, callable $validate)
101 101
     {
102 102
         foreach ($value as $idx => $subValue) {
103
-            if (is_array($subValue) && ! $this->_isAssoc($subValue)) {
103
+            if (is_array($subValue) && !$this->_isAssoc($subValue)) {
104 104
                 $path[count($path)-1] = $idx;
105 105
                 $newPath              = $path;
106 106
                 $newPath[]            = 0;
107 107
                 $this->_validateItems($subValue, $newPath, $validate);
108 108
             } else {
109
-                $path[count($path) - 1] = $idx;
109
+                $path[count($path)-1] = $idx;
110 110
                 $err                    = $validate($subValue);
111 111
 
112 112
                 if ($err) {
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
     /**
120 120
      * @return mixed[]
121 121
      */
122
-    protected function _validate($arg, $value)
122
+    protected function _validate ($arg, $value)
123 123
     {
124 124
         $res = [];
125 125
 
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
187 187
      *
188 188
      * @throws ReflectionException
189 189
      */
190
-    protected function tryInferName()
190
+    protected function tryInferName ()
191 191
     {
192 192
         // If class is extended - infer name from className
193 193
         // QueryType -> Type
Please login to merge, or discard this patch.
tests/Type/ValidatedFieldDefinition/ScalarValidationTest.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
     /** @var Schema */
40 40
     protected $schema;
41 41
 
42
-    protected function setUp()
42
+    protected function setUp ()
43 43
     {
44 44
         $this->personType = new ObjectType([
45 45
             'name' => 'Person',
@@ -55,13 +55,13 @@  discard block
 block discarded – undo
55 55
             'fields' => [
56 56
                 'title' => [
57 57
                     'type' => Type::string(),
58
-                    'resolve' => static function ($book) {
58
+                    'resolve' => static function($book) {
59 59
                         return $book['title'];
60 60
                     },
61 61
                 ],
62 62
                 'author' => [
63 63
                     'type' => $this->personType,
64
-                    'resolve' => static function ($book) {
64
+                    'resolve' => static function($book) {
65 65
                         return $book['author'];
66 66
                     },
67 67
                 ],
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
             'query' => $this->query,
75 75
             'mutation' => new ObjectType([
76 76
                 'name' => 'Mutation',
77
-                'fields' => function () {
77
+                'fields' => function() {
78 78
                     return [
79 79
                         'updateBook' => new ValidatedFieldDefinition([
80 80
                             'name' => 'updateBook',
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
                                 'bookId' => [
84 84
                                     'type' => Type::id(),
85 85
                                     'errorCodes' => ['bookNotFound'],
86
-                                    'validate' => function ($bookId) {
86
+                                    'validate' => function($bookId) {
87 87
                                         if (isset($this->data['books'][$bookId])) {
88 88
                                             return 0;
89 89
                                         }
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
                                     },
93 93
                                 ],
94 94
                             ],
95
-                            'resolve' => static function ($value) : bool {
95
+                            'resolve' => static function($value) : bool {
96 96
                                 return !!$value;
97 97
                             },
98 98
                         ]),
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
         ]);
103 103
     }
104 104
 
105
-    public function testNullableScalarValidationOnNullValueSuccess()
105
+    public function testNullableScalarValidationOnNullValueSuccess ()
106 106
     {
107 107
         $res = GraphQL::executeQuery(
108 108
             $this->schema,
Please login to merge, or discard this patch.
tests/Type/ValidatedFieldDefinition/ListOfInputObjectValidationTest.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
     /** @var Schema */
43 43
     protected $schema;
44 44
 
45
-    protected function setUp()
45
+    protected function setUp ()
46 46
     {
47 47
         $this->personType = new ObjectType([
48 48
             'name' => 'Person',
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
                 'title' => [
63 63
                     'type' => Type::string(),
64 64
                     'description' => 'Enter a book title, no more than 10 characters in length',
65
-                    'validate' => static function (string $title) {
65
+                    'validate' => static function(string $title) {
66 66
                         if (strlen($title) > 10) {
67 67
                             return [1, 'book title must be less than 10 chaacters'];
68 68
                         }
@@ -76,8 +76,8 @@  discard block
 block discarded – undo
76 76
                         'unknownAuthor',
77 77
                         'authorDeceased',
78 78
                     ],
79
-                    'validate' => function (string $authorId) {
80
-                        if (! isset($this->data['people'][$authorId])) {
79
+                    'validate' => function(string $authorId) {
80
+                        if (!isset($this->data['people'][$authorId])) {
81 81
                             return ['unknownAuthor', 'We have no record of that author'];
82 82
                         }
83 83
                         return 0;
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
             'query' => $this->query,
93 93
             'mutation' => new ObjectType([
94 94
                 'name' => 'Mutation',
95
-                'fields' => function () {
95
+                'fields' => function() {
96 96
                     return [
97 97
                         'updateBooks' => new ValidatedFieldDefinition([
98 98
                             'name' => 'updateBooks',
@@ -100,15 +100,15 @@  discard block
 block discarded – undo
100 100
                             'args' => [
101 101
                                 'bookAttributes' => [
102 102
                                     'type' => Type::listOf($this->bookAttributesInputType),
103
-                                    'validate' => static function ($var) {
104
-                                        return $var ? 0: 1;
103
+                                    'validate' => static function($var) {
104
+                                        return $var ? 0 : 1;
105 105
                                     },
106
-                                    'validateItem' => static function ($book) {
107
-                                        return isset($book['author']) || isset($book['title']) ? 0: 1;
106
+                                    'validateItem' => static function($book) {
107
+                                        return isset($book['author']) || isset($book['title']) ? 0 : 1;
108 108
                                     },
109 109
                                 ],
110 110
                             ],
111
-                            'resolve' => static function ($value) : bool {
111
+                            'resolve' => static function($value) : bool {
112 112
                                 return !!$value;
113 113
                             },
114 114
                         ]),
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
         ]);
119 119
     }
120 120
 
121
-    public function testValidationFail()
121
+    public function testValidationFail ()
122 122
     {
123 123
         $res = GraphQL::executeQuery(
124 124
             $this->schema,
Please login to merge, or discard this patch.
tests/Type/ValidatedFieldDefinition/BasicTest.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@  discard block
 block discarded – undo
9 9
 
10 10
 final class BasicTest extends TestCase
11 11
 {
12
-    public function testInferName()
12
+    public function testInferName ()
13 13
     {
14 14
         $def = new NamelessDef([
15 15
             'type' => Type::boolean(),
@@ -17,12 +17,12 @@  discard block
 block discarded – undo
17 17
                 'bookId' => [
18 18
                     'type' => Type::id(),
19 19
                     'errorCodes' => ['bookNotFound'],
20
-                    'validate' => static function ($bookId) {
20
+                    'validate' => static function($bookId) {
21 21
                         return $bookId ? 0 : 1;
22 22
                     },
23 23
                 ],
24 24
             ],
25
-            'resolve' => static function ($value) : bool {
25
+            'resolve' => static function($value) : bool {
26 26
                 return !!$value;
27 27
             },
28 28
         ]);
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
         static::assertEquals('namelessDef', $def->name);
31 31
     }
32 32
 
33
-    public function testInferNameNameAlreadyExists()
33
+    public function testInferNameNameAlreadyExists ()
34 34
     {
35 35
         $def = new NamelessDef([
36 36
             'name' => 'FooDef',
@@ -39,12 +39,12 @@  discard block
 block discarded – undo
39 39
                 'bookId' => [
40 40
                     'type' => Type::id(),
41 41
                     'errorCodes' => ['bookNotFound'],
42
-                    'validate' => static function ($bookId) {
42
+                    'validate' => static function($bookId) {
43 43
                         return $bookId ? 0 : 1;
44 44
                     },
45 45
                 ],
46 46
             ],
47
-            'resolve' => static function ($value) : bool {
47
+            'resolve' => static function($value) : bool {
48 48
                 return !!$value;
49 49
             },
50 50
         ]);
Please login to merge, or discard this patch.