GraphQL\Tests\Type\ValidatedFieldDefinition\ScalarValidationTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	121
Duplicated Lines	30.58 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	setUp()	7	62	2
A	testNullableScalarValidationOnNullValueSuccess()	30	30	1

<?php

declare(strict_types=1);

namespace GraphQL\Tests\Type\ValidatedFieldDefinition;

use GraphQL\GraphQL;
use GraphQL\Tests\Utils;
use GraphQL\Type\Definition\ObjectType;
use GraphQL\Type\Definition\Type;
use GraphQL\Type\Definition\ValidatedFieldDefinition;
use GraphQL\Type\Schema;
use PHPUnit\Framework\TestCase;

final class ScalarValidationTest extends TestCase
{
    /** @var Type */
    protected $bookType;

    /** @var Type */
    protected $personType;

    /** @var mixed[] */
    protected $data = [
        'people' => [
            1 => ['firstName' => 'Wilson'],
        ],
        'books' => [
            1 => [
                'title' => 'Where the Red Fern Grows',
                'author' => 1,
            ],
        ],
    ];

    /** @var ObjectType */
    protected $query;

    /** @var Schema */
    protected $schema;

    protected function setUp()
    {
        $this->personType = new ObjectType([

It seems like new \GraphQL\Type\Definition\ObjectType(array('name' => 'Person', 'fields' => array('firstName' => array('type' => \GraphQL\Type\Definition\Type::string())))) of type object<GraphQL\Type\Definition\ObjectType> is incompatible with the declared type object<GraphQL\Type\Definition\Type> of property $personType.

            'name' => 'Person',
            'fields' => [
                'firstName' => [
                    'type' => Type::string(),
                ],
            ],
        ]);

        $this->bookType = new ObjectType([

It seems like new \GraphQL\Type\Definition\ObjectType(array('name' => 'Book', 'fields' => array('title' => array('type' => \GraphQL\Type\Definition\Type::string(), 'resolve' => static function ($book) { return $book['title']; }), 'author' => array('type' => $this->personType, 'resolve' => static function ($book) { return $book['author']; })))) of type object<GraphQL\Type\Definition\ObjectType> is incompatible with the declared type object<GraphQL\Type\Definition\Type> of property $bookType.

            'name' => 'Book',
            'fields' => [
                'title' => [
                    'type' => Type::string(),
                    'resolve' => static function ($book) {
                        return $book['title'];
                    },
                ],
                'author' => [
                    'type' => $this->personType,
                    'resolve' => static function ($book) {
                        return $book['author'];
                    },
                ],
            ],
        ]);

        $this->query = new ObjectType(['name' => 'Query']);

        $this->schema = new Schema([
            'query' => $this->query,
            'mutation' => new ObjectType([
                'name' => 'Mutation',
                'fields' => function () {
                    return [
                        'updateBook' => new ValidatedFieldDefinition([
                            'name' => 'updateBook',
                            'type' => $this->bookType,
                            'args' => [
                                'bookId' => [
                                    'type' => Type::id(),
                                    'errorCodes' => ['bookNotFound'],
                                    'validate' => function ($bookId) {

This code seems to be duplicated across your project.

                                        if (isset($this->data['books'][$bookId])) {
                                            return 0;
                                        }

                                        return ['bookNotFound', 'Unknown book!'];
                                    },
                                ],
                            ],
                            'resolve' => static function ($value) : bool {
                                return !!$value;
                            },
                        ]),
                    ];
                },
            ]),
        ]);
    }

    public function testNullableScalarValidationOnNullValueSuccess()

This method seems to be duplicated in your project.

    {
        $res = GraphQL::executeQuery(
            $this->schema,
            Utils::nowdoc('
                mutation UpdateBook(
                    $bookId:ID
                ) {
                    updateBook (bookId: $bookId) {
                        valid
                        suberrors {
                            bookId {
                                code
                                msg
                            }
                        }
                        result {
                            title
                        }
                    }
                }
            '),
            [],
            null,
            ['bookId' => null]
        );

        static::assertEmpty($res->errors);
        static::assertTrue($res->data['updateBook']['valid']);
    }
}