InputObjectValidationTest::testValidationInputObjectFieldFail() - Code Metrics - Inspection of "Refactor listOf processing" - shmax/graphql-php-validation-toolkit - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Pull Request — master (#1)

by Max
created 2019-10-05 16:59 UTC
testValidationInputObjectFieldFail() A

↳ Parent: InputObjectValidationTest
Complexity

Conditions	1
Paths	1
Size

Total Lines	68
Code Lines	21
Duplication

Lines	0
Ratio	0 %
Importance

Changes	1
Bugs	0	Features	0
Metric	Value
cc	1
eloc	21
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	68
rs	9.584
How to fix Long Method

<?php

declare(strict_types=1);

namespace GraphQL\Tests\Type\ValidatedFieldDefinition;

use GraphQL\GraphQL;
use GraphQL\Tests\Utils;
use GraphQL\Type\Definition\InputObjectType;
use GraphQL\Type\Definition\ObjectType;
use GraphQL\Type\Definition\Type;
use GraphQL\Type\Definition\UserErrorsType;
use GraphQL\Type\Definition\ValidatedFieldDefinition;
use GraphQL\Type\Schema;
use PHPUnit\Framework\TestCase;
use function strlen;

final class InputObjectValidationTest extends TestCase
{
    /** @var Type */
    protected $bookType;

    /** @var InputObjectType */
    protected $bookAttributesInputType;

    /** @var Type */
    protected $personType;

    /** @var mixed[] */
    protected $data = [
        'people' => [
            1 => ['firstName' => 'Wilson'],
            2 => ['firstName' => 'J.D.'],
            3 => ['firstName' => 'Diana'],
        ],
    ];

    /** @var ObjectType */
    protected $query;

    /** @var Schema */
    protected $schema;

    protected function setUp()
    {
        $this->personType = new ObjectType([
            'name' => 'Person',
            'fields' => [
                'firstName' => [
                    'type' => Type::string(),
                    'phoneNumbers' => [
                        'type' => Type::listOf(Type::string()),
                    ],
                ],
            ],
        ]);

        $this->bookAttributesInputType = new InputObjectType([
            'name' => 'BookAttributes',
            'fields' => [
                'title' => [
                    'type' => Type::string(),
                    'description' => 'Enter a book title, no more than 10 characters in length',
                    'validate' => static function (string $title) {
                        if (strlen($title) > 10) {
                            return [1, 'book title must be less than 10 chaacters'];
                        }
                        return 0;
                    },
                ],
                'author' => [
                    'type' => Type::id(),
                    'description' => 'Provide a valid author id',
                    'errorCodes' => [
                        'unknownAuthor',
                        'authorDeceased',
                    ],
                    'validate' => function (string $authorId) {
                        if (! isset($this->data['people'][$authorId])) {
                            return ['unknownAuthor', 'We have no record of that author'];
                        }
                        return 0;
                    },
                ],
            ],
        ]);

        $this->query = new ObjectType(['name' => 'Query']);

        $this->schema = new Schema([
            'query' => $this->query,
            'mutation' => new ObjectType([
                'name' => 'Mutation',
                'fields' => function () {
                    return [
                        'updateBook' => new ValidatedFieldDefinition([
                            'name' => 'updateBook',
                            'type' => Type::boolean(),
                            'args' => [
                                'bookAttributes' => [
                                    'type' => $this->bookAttributesInputType,
	                                'errorCodes' => [
										'titleOrIdRequired'
	                                ],
	                                'validate' => static function(?array $bookAttributes) {
                        	            if(is_null($bookAttributes)) {

                        	                return 0;
	                                    }
                        	            
                        	            return (isset($bookAttributes['title']) || isset($bookAttributes['author'])) ? 0 : [
                        	            	'titleOrIdRequired', 'You must supply at least one of title or author'
	                                    ];
	                                }
                                ],
                            ],
                            'resolve' => static function ($value, $args) : bool {
                            'resolve' => static function ($value, /** @scrutinizer ignore-unused */ $args) : bool {
                                // ...
                                // do update
                                // ...

                                return true;
                            },
                        ]),
                    ];
                },
            ]),
        ]);
    }

    public function testValidationInputObjectFieldFail()
    {
        $res = GraphQL::executeQuery(
            $this->schema,
            Utils::nowdoc('
				mutation UpdateBook(
						$bookAttributes: BookAttributes
					) {
					updateBook (
						bookAttributes: $bookAttributes
					) {
						valid
						suberrors {
							bookAttributes {
								suberrors {
									title {
										code
										msg
									}
									author {
										code
										msg
									}
								}
							}
						}
						result
					}
				}
			'),
            [],
            null,
            [
                'bookAttributes' => [
                    'title' => 'The Catcher in the Rye',
                    'author' => 4,
                ],
            ]
        );

        static::assertEquals(
            [
                'valid' => false,
                'suberrors' =>
                    [
                        'bookAttributes' =>
                            [
                                'suberrors' =>
                                    [
                                        'title' =>
                                            [
                                                'code' => 1,
                                                'msg' => 'book title must be less than 10 chaacters',
                                            ],
                                        'author' =>
                                            [
                                                'code' => 'unknownAuthor',
                                                'msg' => 'We have no record of that author',
                                            ],
                                    ],
                            ],
                    ],
                'result' => null,
            ],
            $res->data['updateBook']
        );

        static::assertFalse($res->data['updateBook']['valid']);
    }

	public function testValidationInputObjectSelfFail()
	{
		$res = GraphQL::executeQuery(
			$this->schema,
			Utils::nowdoc('
				mutation UpdateBook(
						$bookAttributes: BookAttributes
					) {
					updateBook (
						bookAttributes: $bookAttributes
					) {
						valid
						suberrors {
							bookAttributes {
								code
								msg
								suberrors {
									title {
										code
										msg
									}
									author {
										code
										msg
									}
								}
							}
						}
						result
					}
				}
			'),
			[],
			null,
			[
				'bookAttributes' => [
					'title' => null,
					'author' => null,
				],
			]
		);

		static::assertEquals(
			array (
				'valid' => false,
				'suberrors' =>
					array (
						'bookAttributes' =>
							array (
								'code' => 'titleOrIdRequired',
								'msg' => 'You must supply at least one of title or author',
								'suberrors' => NULL,
							),
					),
				'result' => NULL,
			),
			$res->data['updateBook']
		);

		static::assertFalse($res->data['updateBook']['valid']);
	}

    public function testValidationSuccess()
    {
        $res = GraphQL::executeQuery(
            $this->schema,
            Utils::nowdoc('
				mutation UpdateBook(
					$bookAttributes: BookAttributes
				) {
					updateBook (
						bookAttributes: $bookAttributes
					) {
						valid
						suberrors {
							bookAttributes {
								suberrors {
									title {
										code
										msg
									}
									author {
										code
										msg
									}
								}
							}
						}
						result
					}
				}
			'),
            [],
            null,
            [
                'bookAttributes' => [
                    'title' => 'Dogsbody',
                    'author' => 3,
                ],
            ]
        );

        static::assertEmpty($res->errors);
        static::assertEquals(
            [
                'valid' => true,
                'suberrors' => null,
                'result' => true,
            ],
            $res->data['updateBook']
        );

        static::assertTrue($res->data['updateBook']['valid']);
    }

    public function testValidationEmptyInput()
    {
        $res = GraphQL::executeQuery(
            $this->schema,
            Utils::nowdoc('
				mutation UpdateBook(
						$bookAttributes: BookAttributes
					) {
					updateBook (
						bookAttributes: $bookAttributes
					) {
						valid
						suberrors {
							bookAttributes {
								suberrors {
									title {
										code
										msg
									}
									author {
										code
										msg
									}
								}
							}
						}
						result
					}
				}
			'),
            [],
            null,
            [
                'bookAttributes' => null,
            ]
        );

        static::assertEmpty($res->errors);
        static::assertEquals(
	        array (
		        'valid' => true,
		        'suberrors' => NULL,
		        'result' => true,
	        ),
            $res->data['updateBook']
        );

        static::assertTrue($res->data['updateBook']['valid']);
    }
}

shmax / graphql-php-validation-toolkit

Pull Request — master (#1)

testValidationInputObjectFieldFail() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
