ShlinkioTest\Shlink\Core\ShortUrl\Resolver\SimpleShortUrlRelationResolverTest

Complexity

Total Complexity

6

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	3	1
A	provideKeys()	0	4	1
A	resolvesExpectedDomain()	0	9	2
A	alwaysReturnsNullForApiKeys()	0	3	1
A	provideDomains()	0	4	1

<?php

declare(strict_types=1);

namespace ShlinkioTest\Shlink\Core\ShortUrl\Resolver;

use PHPUnit\Framework\TestCase;
use Shlinkio\Shlink\Core\Entity\Domain;
use Shlinkio\Shlink\Core\ShortUrl\Resolver\SimpleShortUrlRelationResolver;

class SimpleShortUrlRelationResolverTest extends TestCase
{
    private SimpleShortUrlRelationResolver $resolver;

    public function setUp(): void
    {
        $this->resolver = new SimpleShortUrlRelationResolver();
    }

    /**
     * @test
     * @dataProvider provideDomains
     */
    public function resolvesExpectedDomain(?string $domain): void
    {
        $result = $this->resolver->resolveDomain($domain);

        if ($domain === null) {
            self::assertNull($result);
        } else {
            self::assertInstanceOf(Domain::class, $result);
            self::assertEquals($domain, $result->getAuthority());
        }
    }

    public function provideDomains(): iterable
    {
        yield 'empty domain' => [null];
        yield 'non-empty domain' => ['domain.com'];
    }

    /**
     * @test
     * @dataProvider provideKeys
     */
    public function alwaysReturnsNullForApiKeys(?string $key): void
    {
        self::assertNull($this->resolver->resolveApiKey($key));

Are you sure the usage of $this->resolver->resolveApiKey($key) targeting Shlinkio\Shlink\Core\ShortUrl\Resolver\SimpleShortUrlRelationResolver::resolveApiKey() seems to always return null.

    }

    public function provideKeys(): iterable
    {
        yield 'empty api key' => [null];
        yield 'non-empty api key' => ['abc123'];
    }
}