DeleteShortUrlService::deleteByShortCode() - Code Metrics - Inspection of "Delete short URLs" - shlinkio/shlink - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#199)

by Alejandro

created 2018-09-15 16:04 UTC

DeleteShortUrlService::deleteByShortCode() A

↳ Parent: DeleteShortUrlService

Complexity

Conditions	3
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
nc	2
nop	2
dl	0
loc	13
rs	9.8333
c	0
b	0
f	0
ccs	9
cts	9
cp	1
crap	3

<?php
declare(strict_types=1);

namespace Shlinkio\Shlink\Core\Service\ShortUrl;

use Doctrine\ORM\EntityManagerInterface;
use Shlinkio\Shlink\Core\Entity\ShortUrl;
use Shlinkio\Shlink\Core\Exception;
use Shlinkio\Shlink\Core\Options\DeleteShortUrlsOptions;

class DeleteShortUrlService implements DeleteShortUrlServiceInterface
{
    use FindShortCodeTrait;

    /**
     * @var EntityManagerInterface
     */
    private $em;
    /**
     * @var DeleteShortUrlsOptions
     */
    private $deleteShortUrlsOptions;

    public function __construct(EntityManagerInterface $em, DeleteShortUrlsOptions $deleteShortUrlsOptions)
    {
        $this->em = $em;
        $this->deleteShortUrlsOptions = $deleteShortUrlsOptions;
    }

    /**
     * @throws Exception\InvalidShortCodeException
     * @throws Exception\DeleteShortUrlException
     */
    public function deleteByShortCode(string $shortCode, bool $ignoreThreshold = false): void
    {
        $shortUrl = $this->findByShortCode($this->em, $shortCode);
        if (! $ignoreThreshold && $this->isThresholdReached($shortUrl)) {
            throw Exception\DeleteShortUrlException::fromVisitsThreshold(
                $this->deleteShortUrlsOptions->getVisitsThreshold(),
                $shortUrl->getShortCode()
            );
        }

        $this->em->remove($shortUrl);
        $this->em->flush();
    }

    private function isThresholdReached(ShortUrl $shortUrl): bool
    {
        if (! $this->deleteShortUrlsOptions->doCheckVisitsThreshold()) {
            return false;
        }

        return $shortUrl->getVisitsCount() >= $this->deleteShortUrlsOptions->getVisitsThreshold();
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace Shlinkio\Shlink\Core\Service\ShortUrl;
5
6		use Doctrine\ORM\EntityManagerInterface;
7		use Shlinkio\Shlink\Core\Entity\ShortUrl;
8		use Shlinkio\Shlink\Core\Exception;
9		use Shlinkio\Shlink\Core\Options\DeleteShortUrlsOptions;
10
11		class DeleteShortUrlService implements DeleteShortUrlServiceInterface
12		{
13		use FindShortCodeTrait;
14
15		/**
16		* @var EntityManagerInterface
17		*/
18		private $em;
19		/**
20		* @var DeleteShortUrlsOptions
21		*/
22		private $deleteShortUrlsOptions;
23
24	4	public function __construct(EntityManagerInterface $em, DeleteShortUrlsOptions $deleteShortUrlsOptions)
25		{
26	4	$this->em = $em;
27	4	$this->deleteShortUrlsOptions = $deleteShortUrlsOptions;
28	4	}
29
30		/**
31		* @throws Exception\InvalidShortCodeException
32		* @throws Exception\DeleteShortUrlException
33		*/
34	4	public function deleteByShortCode(string $shortCode, bool $ignoreThreshold = false): void
35		{
36	4	$shortUrl = $this->findByShortCode($this->em, $shortCode);
37	4	if (! $ignoreThreshold && $this->isThresholdReached($shortUrl)) {
38	1	throw Exception\DeleteShortUrlException::fromVisitsThreshold(
39	1	$this->deleteShortUrlsOptions->getVisitsThreshold(),
40	1	$shortUrl->getShortCode()
41		);
42		}
43
44	3	$this->em->remove($shortUrl);
45	3	$this->em->flush();
46	3	}
47
48	3	private function isThresholdReached(ShortUrl $shortUrl): bool
49		{
50	3	if (! $this->deleteShortUrlsOptions->doCheckVisitsThreshold()) {
51	1	return false;
52		}
53
54	2	return $shortUrl->getVisitsCount() >= $this->deleteShortUrlsOptions->getVisitsThreshold();
55		}
56		}
57

shlinkio / shlink

Pull Request — master (#199)

DeleteShortUrlService::deleteByShortCode() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like