IpAddress::fromString() - Code Metrics - Inspection of "Fix GDPR compliance" - shlinkio/shlink - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#195)

by Alejandro

created 2018-09-13 21:52 UTC

IpAddress::fromString() A

↳ Parent: IpAddress

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2.0185

Importance

Changes

Metric	Value
cc	2
nc	2
nop	1
dl	0
loc	10
rs	9.9332
c	0
b	0
f	0
ccs	5
cts	6
cp	0.8333
crap	2.0185

<?php
declare(strict_types=1);

namespace Shlinkio\Shlink\Common\Util;

use Shlinkio\Shlink\Common\Exception\WrongIpException;

final class IpAddress
{
    private const IPV4_PARTS_COUNT = 4;
    private const OBFUSCATED_OCTET = '0';
    public const LOCALHOST = '127.0.0.1';

    /**
     * @var string
     */
    private $firstOctet;
    /**
     * @var string
     */
    private $secondOctet;
    /**
     * @var string
     */
    private $thirdOctet;
    /**
     * @var string
     */
    private $fourthOctet;

    private function __construct(string $firstOctet, string $secondOctet, string $thirdOctet, string $fourthOctet)
    {
        $this->firstOctet = $firstOctet;
        $this->secondOctet = $secondOctet;
        $this->thirdOctet = $thirdOctet;
        $this->fourthOctet = $fourthOctet;
    }

    /**
     * @param string $address
     * @return IpAddress
     * @throws WrongIpException
     */
    public static function fromString(string $address): self
    {
        $address = \trim($address);
        $parts = \explode('.', $address);
        if (\count($parts) !== self::IPV4_PARTS_COUNT) {
            throw WrongIpException::fromIpAddress($address);
        }

        return new self(...$parts);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function getObfuscatedCopy(): self
    {
        return new self(
            $this->firstOctet,
            $this->secondOctet,
            $this->thirdOctet,
            self::OBFUSCATED_OCTET
        );
    }

    public function __toString(): string
    {
        return \implode('.', [
            $this->firstOctet,
            $this->secondOctet,
            $this->thirdOctet,
            $this->fourthOctet,
        ]);
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace Shlinkio\Shlink\Common\Util;
5
6		use Shlinkio\Shlink\Common\Exception\WrongIpException;
7
8		final class IpAddress
9		{
10		private const IPV4_PARTS_COUNT = 4;
11		private const OBFUSCATED_OCTET = '0';
12		public const LOCALHOST = '127.0.0.1';
13
14		/**
15		* @var string
16		*/
17		private $firstOctet;
18		/**
19		* @var string
20		*/
21		private $secondOctet;
22		/**
23		* @var string
24		*/
25		private $thirdOctet;
26		/**
27		* @var string
28		*/
29		private $fourthOctet;
30
31	5	private function __construct(string $firstOctet, string $secondOctet, string $thirdOctet, string $fourthOctet)
32		{
33	5	$this->firstOctet = $firstOctet;
34	5	$this->secondOctet = $secondOctet;
35	5	$this->thirdOctet = $thirdOctet;
36	5	$this->fourthOctet = $fourthOctet;
37	5	}
38
39		/**
40		* @param string $address
41		* @return IpAddress
42		* @throws WrongIpException
43		*/
44	5	public static function fromString(string $address): self
45		{
46	5	$address = \trim($address);
47	5	$parts = \explode('.', $address);
48	5	if (\count($parts) !== self::IPV4_PARTS_COUNT) {
49		throw WrongIpException::fromIpAddress($address);
50		}
51
52	5	return new self(...$parts);
		0 ignored issues – show Bug introduced 2018-09-13 22:03 UTC by Report Bug Copy Issue Report The call to `IpAddress::__construct()` misses some required arguments starting with `$secondOctet`. Loading history... Documentation introduced 2018-09-13 22:03 UTC by Report Bug Copy Issue Report `$parts` is of type `array`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
53		}
54
55	5	public function getObfuscatedCopy(): self
56		{
57	5	return new self(
58	5	$this->firstOctet,
59	5	$this->secondOctet,
60	5	$this->thirdOctet,
61	5	self::OBFUSCATED_OCTET
62		);
63		}
64
65	5	public function __toString(): string
66		{
67	5	return \implode('.', [
68	5	$this->firstOctet,
69	5	$this->secondOctet,
70	5	$this->thirdOctet,
71	5	$this->fourthOctet,
72		]);
73		}
74		}
75

shlinkio / shlink

Pull Request — master (#195)

IpAddress::fromString() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like