Shlinkio\Shlink\Rest\Middleware\ShortUrl\DropDefaultDomainFromRequestMiddleware

Complexity

Total Complexity

5

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	sanitizeDomainFromPayload()	0	7	3
A	process()	0	6	1

<?php

declare(strict_types=1);

namespace Shlinkio\Shlink\Rest\Middleware\ShortUrl;

use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\MiddlewareInterface;
use Psr\Http\Server\RequestHandlerInterface;

class DropDefaultDomainFromRequestMiddleware implements MiddlewareInterface
{
    private string $defaultDomain;

    public function __construct(string $defaultDomain)
    {
        $this->defaultDomain = $defaultDomain;
    }

    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        $request = $request->withQueryParams($this->sanitizeDomainFromPayload($request->getQueryParams()))
                           ->withParsedBody($this->sanitizeDomainFromPayload($request->getParsedBody()));

It seems like $request->getParsedBody() can also be of type null and object; however, parameter $payload of Shlinkio\Shlink\Rest\Middleware\ShortUrl\DropDefaultDomainFromRequestMiddleware::sanitizeDomainFromPayload() does only seem to accept array, maybe add an additional type check?

        return $handler->handle($request);
    }

    private function sanitizeDomainFromPayload(array $payload): array
    {
        if (isset($payload['domain']) && $payload['domain'] === $this->defaultDomain) {
            unset($payload['domain']);
        }

        return $payload;
    }
}