ShlinkioTest\Shlink\Core\Service\ShortUrl\DeleteShortUrlServiceTest

Complexity

Total Complexity

6

Size/Duplication

Total Lines	96
Duplicated Lines	37.5 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	13	1
A	deleteByShortCodeThrowsExceptionWhenThresholdIsReached()	0	11	1
A	deleteByShortCodeDeletesUrlWhenThresholdIsReachedButExplicitlyIgnored()	12	12	1
A	deleteByShortCodeDeletesUrlWhenThresholdIsReachedButCheckIsDisabled()	12	12	1
A	deleteByShortCodeDeletesUrlWhenThresholdIsNotReached()	12	12	1
A	createService()	0	7	1

<?php
declare(strict_types=1);

namespace ShlinkioTest\Shlink\Core\Service\ShortUrl;

use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\ORM\EntityManagerInterface;
use PHPUnit\Framework\TestCase;
use Prophecy\Argument;
use Prophecy\Prophecy\ObjectProphecy;
use Shlinkio\Shlink\Core\Entity\ShortUrl;
use Shlinkio\Shlink\Core\Entity\Visit;
use Shlinkio\Shlink\Core\Exception\DeleteShortUrlException;
use Shlinkio\Shlink\Core\Options\DeleteShortUrlsOptions;
use Shlinkio\Shlink\Core\Repository\ShortUrlRepositoryInterface;
use Shlinkio\Shlink\Core\Service\ShortUrl\DeleteShortUrlService;

class DeleteShortUrlServiceTest extends TestCase
{
    /**
     * @var DeleteShortUrlService
     */
    private $service;
    /**
     * @var ObjectProphecy
     */
    private $em;

    public function setUp()
    {
        $shortUrl = (new ShortUrl())->setShortCode('abc123')
                                    ->setVisits(new ArrayCollection(\array_map(function () {
                                        return new Visit();
                                    }, \range(0, 10))));

        $this->em = $this->prophesize(EntityManagerInterface::class);

        $repo = $this->prophesize(ShortUrlRepositoryInterface::class);
        $repo->findOneBy(Argument::type('array'))->willReturn($shortUrl);
        $this->em->getRepository(ShortUrl::class)->willReturn($repo->reveal());
    }

    /**
     * @test
     */
    public function deleteByShortCodeThrowsExceptionWhenThresholdIsReached()
    {
        $service = $this->createService();

        $this->expectException(DeleteShortUrlException::class);
        $this->expectExceptionMessage(
            'Impossible to delete short URL with short code "abc123" since it has more than "5" visits.'
        );

        $service->deleteByShortCode('abc123');
    }

    /**
     * @test
     */
    public function deleteByShortCodeDeletesUrlWhenThresholdIsReachedButExplicitlyIgnored()

This method seems to be duplicated in your project.

    {
        $service = $this->createService();

        $remove = $this->em->remove(Argument::type(ShortUrl::class))->willReturn(null);
        $flush = $this->em->flush()->willReturn(null);

        $service->deleteByShortCode('abc123', true);

        $remove->shouldHaveBeenCalledTimes(1);
        $flush->shouldHaveBeenCalledTimes(1);
    }

    /**
     * @test
     */
    public function deleteByShortCodeDeletesUrlWhenThresholdIsReachedButCheckIsDisabled()

This method seems to be duplicated in your project.

    {
        $service = $this->createService(false);

        $remove = $this->em->remove(Argument::type(ShortUrl::class))->willReturn(null);
        $flush = $this->em->flush()->willReturn(null);

        $service->deleteByShortCode('abc123');

        $remove->shouldHaveBeenCalledTimes(1);
        $flush->shouldHaveBeenCalledTimes(1);
    }

    /**
     * @test
     */
    public function deleteByShortCodeDeletesUrlWhenThresholdIsNotReached()

This method seems to be duplicated in your project.

    {
        $service = $this->createService(true, 100);

        $remove = $this->em->remove(Argument::type(ShortUrl::class))->willReturn(null);
        $flush = $this->em->flush()->willReturn(null);

        $service->deleteByShortCode('abc123');

        $remove->shouldHaveBeenCalledTimes(1);
        $flush->shouldHaveBeenCalledTimes(1);
    }

    private function createService(bool $checkVisitsThreshold = true, int $visitsThreshold = 5): DeleteShortUrlService
    {
        return new DeleteShortUrlService($this->em->reveal(), new DeleteShortUrlsOptions([
            'visitsThreshold' => $visitsThreshold,
            'checkVisitsThreshold' => $checkVisitsThreshold,
        ]));
    }
}