StringUtilsTrait::generateV4Uuid() - Code Metrics - Inspection of "Merge branch 'develop'" - shlinkio/shlink - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9ab4b9...065cdd )

by Alejandro

created 2016-08-09 17:06 UTC

StringUtilsTrait::generateV4Uuid() A

↳ Parent: StringUtilsTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	22
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	11
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	22
ccs	12
cts	12
cp	1
crap	1
rs	9.2

<?php
namespace Shlinkio\Shlink\Common\Util;

trait StringUtilsTrait
{
    protected function generateRandomString($length = 10)
    {
        $characters = '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
        $charactersLength = strlen($characters);
        $randomString = '';
        for ($i = 0; $i < $length; $i++) {
            $randomString .= $characters[rand(0, $charactersLength - 1)];
        }

        return $randomString;
    }

    protected function generateV4Uuid()
    {
        return sprintf(
            '%04x%04x-%04x-%04x-%04x-%04x%04x%04x',
            // 32 bits for "time_low"

            mt_rand(0, 0xffff),
            mt_rand(0, 0xffff),
            // 16 bits for "time_mid"

            mt_rand(0, 0xffff),
            // 16 bits for "time_hi_and_version",

            // four most significant bits holds version number 4
            mt_rand(0, 0x0fff) | 0x4000,
            // 16 bits, 8 bits for "clk_seq_hi_res",

            // 8 bits for "clk_seq_low",

            // two most significant bits holds zero and one for variant DCE1.1
            mt_rand(0, 0x3fff) | 0x8000,
            // 48 bits for "node"

            mt_rand(0, 0xffff),
            mt_rand(0, 0xffff),
            mt_rand(0, 0xffff)
        );
    }
}


1		<?php
2		namespace Shlinkio\Shlink\Common\Util;
3
4		trait StringUtilsTrait
5		{
6		protected function generateRandomString($length = 10)
7		{
8		$characters = '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
9		$charactersLength = strlen($characters);
10		$randomString = '';
11		for ($i = 0; $i < $length; $i++) {
12		$randomString .= $characters[rand(0, $charactersLength - 1)];
13		}
14
15		return $randomString;
16		}
17
18	11	protected function generateV4Uuid()
19		{
20	11	return sprintf(
21	11	'%04x%04x-%04x-%04x-%04x-%04x%04x%04x',
22		// 32 bits for "time_low"
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-08-01 19:52 UTC by Report Bug Copy Issue Report `38%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
23	11	mt_rand(0, 0xffff),
24	11	mt_rand(0, 0xffff),
25		// 16 bits for "time_mid"
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-08-01 19:52 UTC by Report Bug Copy Issue Report `38%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
26	11	mt_rand(0, 0xffff),
27		// 16 bits for "time_hi_and_version",
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-08-01 19:52 UTC by Report Bug Copy Issue Report `45%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
28		// four most significant bits holds version number 4
29	11	mt_rand(0, 0x0fff) \| 0x4000,
30		// 16 bits, 8 bits for "clk_seq_hi_res",
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-08-01 19:52 UTC by Report Bug Copy Issue Report `43%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
31		// 8 bits for "clk_seq_low",
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-08-01 19:52 UTC by Report Bug Copy Issue Report `45%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
32		// two most significant bits holds zero and one for variant DCE1.1
33	11	mt_rand(0, 0x3fff) \| 0x8000,
34		// 48 bits for "node"
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-08-01 19:52 UTC by Report Bug Copy Issue Report `38%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
35	11	mt_rand(0, 0xffff),
36	11	mt_rand(0, 0xffff),
37	11	mt_rand(0, 0xffff)
38	11	);
39		}
40		}
41

shlinkio / shlink

Push — master ( 9ab4b9...065cdd )

StringUtilsTrait::generateV4Uuid() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like