ShlinkioTest\Shlink\Rest\Service\ApiKeyServiceTest

Complexity

Total Complexity

11

Size/Duplication

Total Lines	157
Duplicated Lines	11.46 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	2
Bugs	0	Features	1

11 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	5	1
A	keyIsProperlyCreated()	0	8	1
A	keyIsProperlyCreatedWithExpirationDate()	0	9	1
A	checkReturnsFalseWhenKeyIsInvalid()	9	9	1
A	checkReturnsFalseWhenKeyIsDisabled()	0	11	1
A	checkReturnsFalseWhenKeyIsExpired()	0	11	1
A	checkReturnsTrueWhenConditionsAreFavorable()	9	9	1
A	disableThrowsExceptionWhenNoTokenIsFound()	0	9	1
A	disableReturnsDisabledKeyWhenFOund()	0	15	1
A	listFindsAllApiKeys()	0	9	1
A	listEnabledFindsOnlyEnabledApiKeys()	0	9	1

<?php
namespace ShlinkioTest\Shlink\Rest\Service;

use Doctrine\ORM\EntityManager;
use Doctrine\ORM\EntityRepository;
use PHPUnit_Framework_TestCase as TestCase;
use Prophecy\Argument;
use Prophecy\Prophecy\ObjectProphecy;
use Shlinkio\Shlink\Rest\Entity\ApiKey;
use Shlinkio\Shlink\Rest\Service\ApiKeyService;

class ApiKeyServiceTest extends TestCase
{
    /**
     * @var ApiKeyService
     */
    protected $service;
    /**
     * @var ObjectProphecy
     */
    protected $em;

    public function setUp()
    {
        $this->em = $this->prophesize(EntityManager::class);
        $this->service = new ApiKeyService($this->em->reveal());
    }

    /**
     * @test
     */
    public function keyIsProperlyCreated()
    {
        $this->em->flush()->shouldBeCalledTimes(1);
        $this->em->persist(Argument::type(ApiKey::class))->shouldBeCalledTimes(1);

        $key = $this->service->create();
        $this->assertNull($key->getExpirationDate());
    }

    /**
     * @test
     */
    public function keyIsProperlyCreatedWithExpirationDate()
    {
        $this->em->flush()->shouldBeCalledTimes(1);
        $this->em->persist(Argument::type(ApiKey::class))->shouldBeCalledTimes(1);

        $date = new \DateTime('2030-01-01');
        $key = $this->service->create($date);
        $this->assertSame($date, $key->getExpirationDate());
    }

    /**
     * @test
     */
    public function checkReturnsFalseWhenKeyIsInvalid()

This method seems to be duplicated in your project.

    {
        $repo = $this->prophesize(EntityRepository::class);
        $repo->findOneBy(['key' => '12345'])->willReturn(null)
                                            ->shouldBeCalledTimes(1);
        $this->em->getRepository(ApiKey::class)->willReturn($repo->reveal());

        $this->assertFalse($this->service->check('12345'));
    }

    /**
     * @test
     */
    public function checkReturnsFalseWhenKeyIsDisabled()
    {
        $key = new ApiKey();
        $key->disable();
        $repo = $this->prophesize(EntityRepository::class);
        $repo->findOneBy(['key' => '12345'])->willReturn($key)
                                            ->shouldBeCalledTimes(1);
        $this->em->getRepository(ApiKey::class)->willReturn($repo->reveal());

        $this->assertFalse($this->service->check('12345'));
    }

    /**
     * @test
     */
    public function checkReturnsFalseWhenKeyIsExpired()
    {
        $key = new ApiKey();
        $key->setExpirationDate((new \DateTime())->sub(new \DateInterval('P1D')));
        $repo = $this->prophesize(EntityRepository::class);
        $repo->findOneBy(['key' => '12345'])->willReturn($key)
                                            ->shouldBeCalledTimes(1);
        $this->em->getRepository(ApiKey::class)->willReturn($repo->reveal());

        $this->assertFalse($this->service->check('12345'));
    }

    /**
     * @test
     */
    public function checkReturnsTrueWhenConditionsAreFavorable()

This method seems to be duplicated in your project.

    {
        $repo = $this->prophesize(EntityRepository::class);
        $repo->findOneBy(['key' => '12345'])->willReturn(new ApiKey())
                                            ->shouldBeCalledTimes(1);
        $this->em->getRepository(ApiKey::class)->willReturn($repo->reveal());

        $this->assertTrue($this->service->check('12345'));
    }

    /**
     * @test
     * @expectedException \Shlinkio\Shlink\Common\Exception\InvalidArgumentException
     */
    public function disableThrowsExceptionWhenNoTokenIsFound()
    {
        $repo = $this->prophesize(EntityRepository::class);
        $repo->findOneBy(['key' => '12345'])->willReturn(null)
                                            ->shouldBeCalledTimes(1);
        $this->em->getRepository(ApiKey::class)->willReturn($repo->reveal());

        $this->service->disable('12345');
    }

    /**
     * @test
     */
    public function disableReturnsDisabledKeyWhenFOund()
    {
        $key = new ApiKey();
        $repo = $this->prophesize(EntityRepository::class);
        $repo->findOneBy(['key' => '12345'])->willReturn($key)
                                            ->shouldBeCalledTimes(1);
        $this->em->getRepository(ApiKey::class)->willReturn($repo->reveal());

        $this->em->flush()->shouldBeCalledTimes(1);

        $this->assertTrue($key->isEnabled());
        $returnedKey = $this->service->disable('12345');
        $this->assertFalse($key->isEnabled());
        $this->assertSame($key, $returnedKey);
    }

    /**
     * @test
     */
    public function listFindsAllApiKeys()
    {
        $repo = $this->prophesize(EntityRepository::class);
        $repo->findBy([])->willReturn([])
                         ->shouldBeCalledTimes(1);
        $this->em->getRepository(ApiKey::class)->willReturn($repo->reveal());

        $this->service->listKeys();
    }

    /**
     * @test
     */
    public function listEnabledFindsOnlyEnabledApiKeys()
    {
        $repo = $this->prophesize(EntityRepository::class);
        $repo->findBy(['enabled' => true])->willReturn([])
                                          ->shouldBeCalledTimes(1);
        $this->em->getRepository(ApiKey::class)->willReturn($repo->reveal());

        $this->service->listKeys(true);
    }
}