Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 18 | class BodyParserMiddleware implements MiddlewareInterface, RequestMethodInterface |
||
| 19 | { |
||
| 20 | /** |
||
| 21 | * Process an incoming server request and return a response, optionally delegating |
||
| 22 | * to the next middleware component to create the response. |
||
| 23 | * |
||
| 24 | * @param Request $request |
||
| 25 | * @param RequestHandlerInterface $handler |
||
| 26 | * |
||
| 27 | * @return Response |
||
| 28 | */ |
||
| 29 | 3 | public function process(Request $request, RequestHandlerInterface $handler): Response |
|
| 51 | |||
| 52 | /** |
||
| 53 | * @param Request $request |
||
| 54 | * @return string |
||
| 55 | */ |
||
| 56 | 2 | private function getRequestContentType(Request $request): string |
|
| 62 | |||
| 63 | /** |
||
| 64 | * @param Request $request |
||
| 65 | * @return Request |
||
| 66 | */ |
||
| 67 | 1 | View Code Duplication | private function parseFromJson(Request $request): Request |
| 77 | |||
| 78 | /** |
||
| 79 | * @param Request $request |
||
| 80 | * @return Request |
||
| 81 | */ |
||
| 82 | 1 | View Code Duplication | private function parseFromUrlEncoded(Request $request): Request |
| 94 | } |
||
| 95 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.