View GitHub Repository shlink

Schedule Inspection
Subscribe
Completed
Pull Request — master (#554)
by Alejandro
13:38
created

PHP Classes Changes

 ⇢ A ShortUrlNotFoundExceptionTest added
⇢ A DeleteShortUrlActionTest added
⇢ A UpdateTagActionTest added
⇢ A EditShortUrlTagsActionTest added
⇢ A GetVisitsActionTest added
⇢ A ResolveShortUrlActionTest added
⇢ A EditShortUrlActionTest added
⇢ A ShortUrlNotFoundException added
⇢ A MissingAuthenticationException added
⇢ A NotFoundTemplateHandler added
⋮ view more  
A ↛
EntityDoesNotExistException removed
A ↛
InvalidShortCodeExceptionTest removed
A ↛
JsonErrorResponseGeneratorTest removed
A ↛
RestUtils removed
A ↛
JsonErrorResponseGenerator removed
A ↛
InvalidShortCodeException removed
A ↛
NoAuthenticationException removed
A ↛
NotFoundHandlerTest removed
A ↛
NotFoundHandler removed
A ↛
HealthActionFactory removed
⋮ view more  

PHP Operations Changes

 ⇢ B NotFoundRedirectHandler::createRedirectResponse() added
⇢ A NotFoundRedirectHandlerTest::provideRedirects() added
⇢ A AuthenticationTest::provideInvalidAuthorizations() added
⇢ A BackwardsCompatibleProblemDetailsMiddlewareTest::m... added
⇢ A DeleteShortUrlActionTest::unprocessableEntityIsRet... added
⇢ A UpdateTagActionTest::tryingToRenameInvalidTagRetur... added
⇢ A EditShortUrlTagsActionTest::providingInvalidShortC... added
⇢ A BackwardsCompatibleProblemDetailsMiddleware::proce... added
⇢ A DeleteShortUrlActionTest::notFoundErrorIsReturnWhe... added
⇢ A GetVisitsActionTest::tryingToGetVisitsForInvalidUr... added
⋮ view more  
B ↗ A AuthenticationMiddleware::process() improved
B ↛
NotFoundHandler::createRedirectResponse() removed
B ↛
RestUtils::getRestErrorCodeFromException() removed
A ↛
AuthenticationMiddlewareTest.php$0 ➔ errorIsReturn... removed
A ↛
AuthenticationMiddlewareTest.php$0 ➔ updatedRespon... removed
A ↛
NotFoundHandlerTest::provideRedirects() removed
A ↛
AuthenticationMiddlewareTest::errorIsReturnedWhenN... removed
A ↛
RestUtilsTest::correctCodeIsReturnedFromException(... removed
A ↛
NotFoundHandler::handle() removed
A ↛
ListShortUrlsActionTest::anExceptionReturnsErrorRe... removed
A ↛
CreateShortUrlActionTest::nonUniqueSlugReturnsErro... removed
⋮ view more