AbstractLockedCommand::execute() - Code Metrics - Inspection of "Feature/locked installation" - shlinkio/shlink - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#440)

by Alejandro

created 2019-08-06 16:58 UTC

AbstractLockedCommand::execute() A

↳ Parent: AbstractLockedCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	2.004

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	10
c	1
b	0
f	0
dl	0
loc	16
ccs	9
cts	10
cp	0.9
rs	9.9332
cc	2
nc	2
nop	2
crap	2.004

<?php
declare(strict_types=1);

namespace Shlinkio\Shlink\CLI\Command\Util;

use Shlinkio\Shlink\CLI\Util\ExitCodes;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Lock\Factory as Locker;

use function sprintf;

abstract class AbstractLockedCommand extends Command
{
    /** @var Locker */
    private $locker;

    public function __construct(Locker $locker)
    {
        parent::__construct();
        $this->locker = $locker;
    }

    final protected function execute(InputInterface $input, OutputInterface $output): ?int
    {
        $lockConfig = $this->getLockConfig();
        $lock = $this->locker->createLock($lockConfig->lockName(), $lockConfig->ttl(), $lockConfig->isBlocking());

        if (! $lock->acquire($lockConfig->isBlocking())) {
            $output->writeln(
                sprintf('<comment>Command "%s" is already in progress. Skipping.</comment>', $lockConfig->lockName())
            );
            return ExitCodes::EXIT_WARNING;
        }

        try {
            return $this->lockedExecute($input, $output);
        } finally {
            $lock->release();
        }
    }

    abstract protected function lockedExecute(InputInterface $input, OutputInterface $output): int;

    abstract protected function getLockConfig(): LockedCommandConfig;
}


1		<?php
2		declare(strict_types=1);
3
4		namespace Shlinkio\Shlink\CLI\Command\Util;
5
6		use Shlinkio\Shlink\CLI\Util\ExitCodes;
7		use Symfony\Component\Console\Command\Command;
8		use Symfony\Component\Console\Input\InputInterface;
9		use Symfony\Component\Console\Output\OutputInterface;
10		use Symfony\Component\Lock\Factory as Locker;
11
12		use function sprintf;
13
14		abstract class AbstractLockedCommand extends Command
15		{
16		/** @var Locker */
17		private $locker;
18
19	11	public function __construct(Locker $locker)
20		{
21	11	parent::__construct();
22	11	$this->locker = $locker;
23		}
24
25	11	final protected function execute(InputInterface $input, OutputInterface $output): ?int
26		{
27	11	$lockConfig = $this->getLockConfig();
28	11	$lock = $this->locker->createLock($lockConfig->lockName(), $lockConfig->ttl(), $lockConfig->isBlocking());
29
30	11	if (! $lock->acquire($lockConfig->isBlocking())) {
31	1	$output->writeln(
32	1	sprintf('<comment>Command "%s" is already in progress. Skipping.</comment>', $lockConfig->lockName())
33		);
34	1	return ExitCodes::EXIT_WARNING;
35		}
36
37		try {
38	10	return $this->lockedExecute($input, $output);
39		} finally {
40	10	$lock->release();
41		}
42		}
43
44		abstract protected function lockedExecute(InputInterface $input, OutputInterface $output): int;
45
46		abstract protected function getLockConfig(): LockedCommandConfig;
47		}
48

shlinkio / shlink

Pull Request — master (#440)

AbstractLockedCommand::execute() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like