SimplifiedConfigParserTest::properlyMapsSimplifiedConfig() - Code Metrics - Inspection of "Feature/base path" - shlinkio/shlink - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#485)

by Alejandro

created 2019-09-13 18:47 UTC

properlyMapsSimplifiedConfig() B

↳ Parent: SimplifiedConfigParserTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	88
Code Lines	57

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	1
eloc	57
nc	1
nop	0
dl	0
loc	88
rs	8.9381
c	1
b	0
f	1

How to fix Long Method

<?php
declare(strict_types=1);

namespace ShlinkioTest\Shlink\Core\Config;

use PHPUnit\Framework\TestCase;
use Shlinkio\Shlink\Core\Config\SimplifiedConfigParser;

use function array_merge;

class SimplifiedConfigParserTest extends TestCase
{
    private $postProcessor;

    public function setUp(): void
    {
        $this->postProcessor = new SimplifiedConfigParser();
    }

    /** @test */
    public function properlyMapsSimplifiedConfig(): void
    {
        $config = [
            'app_options' => [
                'disable_track_param' => 'foo',
            ],

            'entity_manager' => [
                'connection' => [
                    'driver' => 'mysql',
                    'host' => 'shlink_db',
                    'port' => '3306',
                ],
            ],
        ];
        $simplified = [
            'disable_track_param' => 'bar',
            'short_domain_schema' => 'https',
            'short_domain_host' => 'doma.in',
            'validate_url' => false,
            'delete_short_url_threshold' => 50,
            'not_found_redirect_to' => 'foobar.com',
            'redis_servers' => [
                'tcp://1.1.1.1:1111',
                'tcp://1.2.2.2:2222',
            ],
            'db_config' => [
                'dbname' => 'shlink',
                'user' => 'foo',
                'password' => 'bar',
                'port' => '1234',
            ],
            'base_path' => '/foo/bar',
        ];
        $expected = [
            'app_options' => [
                'disable_track_param' => 'bar',
            ],

            'entity_manager' => [
                'connection' => [
                    'driver' => 'mysql',
                    'host' => 'shlink_db',
                    'dbname' => 'shlink',
                    'user' => 'foo',
                    'password' => 'bar',
                    'port' => '1234',
                ],
            ],

            'url_shortener' => [
                'domain' => [
                    'schema' => 'https',
                    'hostname' => 'doma.in',
                ],
                'validate_url' => false,
                'not_found_short_url' => [
                    'redirect_to' => 'foobar.com',
                    'enable_redirection' => true,
                ],
            ],

            'delete_short_urls' => [
                'visits_threshold' => 50,
                'check_visits_threshold' => true,
            ],

            'dependencies' => [
                'aliases' => [
                    'lock_store' => 'redis_lock_store',
                ],
            ],

            'redis' => [
                'servers' => [
                    'tcp://1.1.1.1:1111',
                    'tcp://1.2.2.2:2222',
                ],
            ],

            'router' => [
                'base_path' => '/foo/bar',
            ],
        ];

        $result = ($this->postProcessor)(array_merge($config, $simplified));

        $this->assertEquals(array_merge($expected, $simplified), $result);
    }
}


1			<?php
2			declare(strict_types=1);
3
4			namespace ShlinkioTest\Shlink\Core\Config;
5
6			use PHPUnit\Framework\TestCase;
7			use Shlinkio\Shlink\Core\Config\SimplifiedConfigParser;
8
9			use function array_merge;
10
11			class SimplifiedConfigParserTest extends TestCase
12			{
13			private $postProcessor;
14
15			public function setUp(): void
16			{
17			$this->postProcessor = new SimplifiedConfigParser();
18			}
19
20			/** @test */
21			public function properlyMapsSimplifiedConfig(): void
22			{
23			$config = [
24			'app_options' => [
25			'disable_track_param' => 'foo',
26			],
27
28			'entity_manager' => [
29			'connection' => [
30			'driver' => 'mysql',
31			'host' => 'shlink_db',
32			'port' => '3306',
33			],
34			],
35			];
36			$simplified = [
37			'disable_track_param' => 'bar',
38			'short_domain_schema' => 'https',
39			'short_domain_host' => 'doma.in',
40			'validate_url' => false,
41			'delete_short_url_threshold' => 50,
42			'not_found_redirect_to' => 'foobar.com',
43			'redis_servers' => [
44			'tcp://1.1.1.1:1111',
45			'tcp://1.2.2.2:2222',
46			],
47			'db_config' => [
48			'dbname' => 'shlink',
49			'user' => 'foo',
50			'password' => 'bar',
51			'port' => '1234',
52			],
53			'base_path' => '/foo/bar',
54			];
55			$expected = [
56			'app_options' => [
57			'disable_track_param' => 'bar',
58			],
59
60			'entity_manager' => [
61			'connection' => [
62			'driver' => 'mysql',
63			'host' => 'shlink_db',
64			'dbname' => 'shlink',
65			'user' => 'foo',
66			'password' => 'bar',
67			'port' => '1234',
68			],
69			],
70
71			'url_shortener' => [
72			'domain' => [
73			'schema' => 'https',
74			'hostname' => 'doma.in',
75			],
76			'validate_url' => false,
77			'not_found_short_url' => [
78			'redirect_to' => 'foobar.com',
79			'enable_redirection' => true,
80			],
81			],
82
83			'delete_short_urls' => [
84			'visits_threshold' => 50,
85			'check_visits_threshold' => true,
86			],
87
88			'dependencies' => [
89			'aliases' => [
90			'lock_store' => 'redis_lock_store',
91			],
92			],
93
94			'redis' => [
95			'servers' => [
96			'tcp://1.1.1.1:1111',
97			'tcp://1.2.2.2:2222',
98			],
99			],
100
101			'router' => [
102			'base_path' => '/foo/bar',
103			],
104			];
105
106			$result = ($this->postProcessor)(array_merge($config, $simplified));
107
108			$this->assertEquals(array_merge($expected, $simplified), $result);
109			}
110			}
111

shlinkio / shlink

Pull Request — master (#485)

properlyMapsSimplifiedConfig() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like