ShlinkioTest\Shlink\Rest\Middleware\BodyParserMiddlewareTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	69
Duplicated Lines	44.93 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	4	1
A	requestsFromOtherMethodsJustFallbackToNextMiddleware()	0	14	1
A	jsonRequestsAreJsonDecoded()	16	16	1
A	regularRequestsAreUrlDecoded()	15	15	1

<?php
namespace ShlinkioTest\Shlink\Rest\Middleware;

use PHPUnit_Framework_TestCase as TestCase;
use Psr\Http\Message\ServerRequestInterface as Request;
use Shlinkio\Shlink\Rest\Middleware\BodyParserMiddleware;
use Zend\Diactoros\Response;
use Zend\Diactoros\ServerRequestFactory;
use Zend\Diactoros\Stream;

class BodyParserMiddlewareTest extends TestCase
{
    /**
     * @var BodyParserMiddleware
     */
    private $middleware;

    public function setUp()
    {
        $this->middleware = new BodyParserMiddleware();
    }

    /**
     * @test
     */
    public function requestsFromOtherMethodsJustFallbackToNextMiddleware()
    {
        $request = ServerRequestFactory::fromGlobals()->withMethod('GET');
        $test = $this;
        $this->middleware->__invoke($request, new Response(), function ($req, $resp) use ($test, $request) {

The parameter $resp is not used and could be removed.

            $test->assertSame($request, $req);
        });

        $request = $request->withMethod('POST');
        $test = $this;
        $this->middleware->__invoke($request, new Response(), function ($req, $resp) use ($test, $request) {

The parameter $resp is not used and could be removed.

            $test->assertSame($request, $req);
        });
    }

    /**
     * @test
     */
    public function jsonRequestsAreJsonDecoded()

This method seems to be duplicated in your project.

    {
        $body = new Stream('php://temp', 'wr');
        $body->write('{"foo": "bar", "bar": ["one", 5]}');
        $request = ServerRequestFactory::fromGlobals()->withMethod('PUT')
                                                      ->withBody($body)
                                                      ->withHeader('content-type', 'application/json');
        $test = $this;
        $this->middleware->__invoke($request, new Response(), function (Request $req, $resp) use ($test, $request) {

The parameter $resp is not used and could be removed.

            $test->assertNotSame($request, $req);
            $test->assertEquals([
                'foo' => 'bar',
                'bar' => ['one', 5],
            ], $req->getParsedBody());
        });
    }

    /**
     * @test
     */
    public function regularRequestsAreUrlDecoded()

This method seems to be duplicated in your project.

    {
        $body = new Stream('php://temp', 'wr');
        $body->write('foo=bar&bar[]=one&bar[]=5');
        $request = ServerRequestFactory::fromGlobals()->withMethod('PUT')
                                                      ->withBody($body);
        $test = $this;
        $this->middleware->__invoke($request, new Response(), function (Request $req, $resp) use ($test, $request) {

The parameter $resp is not used and could be removed.

            $test->assertNotSame($request, $req);
            $test->assertEquals([
                'foo' => 'bar',
                'bar' => ['one', 5],
            ], $req->getParsedBody());
        });
    }
}