Shlinkio\Shlink\CLI\Command\Util\AbstractWithDateRangeCommand::getDateOption()

Complexity

Conditions	4
Paths	4

Size

Total Lines	21
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	4.0092

Importance

Changes	1
Bugs	0	Features	0

<?php
    protected function getDateOption(InputInterface $input, OutputInterface $output, string $key): ?Chronos
    {
        $value = $input->getOption($key);
        if (empty($value)) {
            return null;
        }

        try {
            return Chronos::parse($value);

It seems like $value can also be of type string[]; however, parameter $time of Cake\Chronos\Chronos::parse() does only seem to accept DateTimeInterface|string, maybe add an additional type check?

        } catch (Throwable $e) {
            $output->writeln(sprintf(
                '<comment>> Ignored provided "%s" since its value "%s" is not a valid date. <</comment>',
                $key,
                $value,

It seems like $value can also be of type string[]; however, parameter $args of sprintf() does only seem to accept string, maybe add an additional type check?

            ));

            if ($output->isVeryVerbose()) {
                $this->getApplication()->renderThrowable($e, $output);
            }

            return null;
        }