Shlinkio\Shlink\Common\Middleware\CloseDbConnectionMiddleware

Complexity

Total Complexity

4

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Test Coverage

Coverage

91.67%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	process()	0	17	3

<?php
declare(strict_types=1);

namespace Shlinkio\Shlink\Common\Middleware;

use Doctrine\ORM\EntityManager;
use Doctrine\ORM\EntityManagerInterface;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\MiddlewareInterface;
use Psr\Http\Server\RequestHandlerInterface;
use Throwable;

class CloseDbConnectionMiddleware implements MiddlewareInterface
{
    /** @var EntityManagerInterface */
    private $em;

    public function __construct(EntityManagerInterface $em)
    {
        $this->em = $em;
    }

    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        try {
            return $handler->handle($request);
        } catch (Throwable $e) {
            // FIXME Mega ugly hack to avoid a closed EntityManager to make shlink fail forever on swoole contexts
            //       Should be fixed with request-shared EntityManagers, which is not supported by the ServiceManager
            if (! $this->em->isOpen()) {
                (function () {
                    $this->closed = false;

The property closed does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

                })->bindTo($this->em, EntityManager::class)();
            }

            throw $e;
        } finally {
            $this->em->getConnection()->close();
            $this->em->clear();

In this branch, the function will implicitly return null which is incompatible with the type-hinted return Psr\Http\Message\ResponseInterface. Consider adding a return statement or allowing null as return value.

        }
    }
}