Shlinkio\Shlink\CLI\Command\Db\AbstractDatabaseCommand

Complexity

Total Complexity

4

Size/Duplication

Total Lines	21
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getLockConfig()	0	3	1
A	runPhpCommand()	0	4	1
A	__construct()	0	5	2

<?php

declare(strict_types=1);

namespace Shlinkio\Shlink\CLI\Command\Db;

use Shlinkio\Shlink\CLI\Command\Util\AbstractLockedCommand;
use Shlinkio\Shlink\CLI\Command\Util\LockedCommandConfig;
use Symfony\Component\Console\Helper\ProcessHelper;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Lock\LockFactory;
use Symfony\Component\Process\PhpExecutableFinder;

abstract class AbstractDatabaseCommand extends AbstractLockedCommand
{
    private ProcessHelper $processHelper;
    private string $phpBinary;

    public function __construct(LockFactory $locker, ProcessHelper $processHelper, PhpExecutableFinder $phpFinder)
    {
        parent::__construct($locker);
        $this->processHelper = $processHelper;
        $this->phpBinary = $phpFinder->find(false) ?: 'php';
    }

    protected function runPhpCommand(OutputInterface $output, array $command): void
    {
        $command = [$this->phpBinary, ...$command, '--no-interaction'];
        $this->processHelper->mustRun($output, $command);

$command of type array<integer,array|string> is incompatible with the type Symfony\Component\Process\Process|string expected by parameter $cmd of Symfony\Component\Console\Helper\ProcessHelper::mustRun().

    }

    protected function getLockConfig(): LockedCommandConfig
    {
        return new LockedCommandConfig($this->getName(), true);

It seems like $this->getName() can also be of type null; however, parameter $lockName of Shlinkio\Shlink\CLI\Command\Util\LockedCommandConfig::__construct() does only seem to accept string, maybe add an additional type check?

    }
}