DestinationRegistry - Code Metrics - Inspection of "singleton registries" - shippinno/notification - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c6d1df...be73a8 )

by Hirofumi

created 2018-11-05 09:10 UTC

DestinationRegistry A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	0

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	5
lcom	2
cbo	0
dl	0
loc	51
ccs	0
cts	23
cp	0
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	instance()	8	2
A	set()	4	1
A	get()	13	2

<?php

namespace Shippinno\Notification\Domain\Model;

use InvalidArgumentException;

class DestinationRegistry
{
    /**
     * @var null|DestinationRegistry
     */
    private static $instance = null;

    /**
     * @var Destination[]
     */
    protected $destinations = [];

    /**
     * @return DestinationRegistry
     */
    public static function instance(): DestinationRegistry
    {
        if (null === static::$instance) {
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
            static::$instance = new DestinationRegistry;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
        }

        return static::$instance;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
    }

    /**
     * @param string $name
     * @param Destination $destination
     */
    public function set(string $name, Destination $destination)
    {
        $this->destinations[$name] = $destination;
    }

    /**
     * @param string $name
     * @return Destination
     */
    public function get(string $name): Destination
    {
        if (!isset($this->destinations[$name])) {
            throw new InvalidArgumentException(
                sprintf(
                    'No destination is registered with name (%s).',
                    $name
                )
            );
        }

        return $this->destinations[$name];
    }
}


1			<?php
2
3			namespace Shippinno\Notification\Domain\Model;
4
5			use InvalidArgumentException;
6
7			class DestinationRegistry
8			{
9			/**
10			* @var null\|DestinationRegistry
11			*/
12			private static $instance = null;
13
14			/**
15			* @var Destination[]
16			*/
17			protected $destinations = [];
18
19			/**
20			* @return DestinationRegistry
21			*/
22			public static function instance(): DestinationRegistry
23			{
24			if (null === static::$instance) {
			0 ignored issues – show Bug introduced 2018-11-05 09:18 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
25			static::$instance = new DestinationRegistry;
			0 ignored issues – show Bug introduced 2018-11-05 09:18 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
26			}
27
28			return static::$instance;
			0 ignored issues – show Bug introduced 2018-11-05 09:18 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
29			}
30
31			/**
32			* @param string $name
33			* @param Destination $destination
34			*/
35			public function set(string $name, Destination $destination)
36			{
37			$this->destinations[$name] = $destination;
38			}
39
40			/**
41			* @param string $name
42			* @return Destination
43			*/
44			public function get(string $name): Destination
45			{
46			if (!isset($this->destinations[$name])) {
47			throw new InvalidArgumentException(
48			sprintf(
49			'No destination is registered with name (%s).',
50			$name
51			)
52			);
53			}
54
55			return $this->destinations[$name];
56			}
57			}
58

shippinno / notification

Push — master ( c6d1df...be73a8 )

DestinationRegistry A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Duplication Side-by-Side

Filter issues like