SendFreshNotificationsHandler::handle() - Code Metrics - Inspection of "some more" - shippinno/notification - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 6f7a22...abd8b8 )

by Hirofumi

created 2018-11-02 09:05 UTC

SendFreshNotificationsHandler::handle() A

↳ Parent: SendFreshNotificationsHandler

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
c	0
b	0
f	0
rs	10
cc	2
nc	2
nop	1

<?php
declare(strict_types=1);

namespace Shippinno\Notification\Application\Command;

use Shippinno\Notification\Domain\Model\NotificationRepository;
use Shippinno\Notification\Domain\Model\SendNotification as SendNotificationService;

class SendFreshNotificationsHandler
{
    /**
     * @var NotificationRepository
     */
    private $notificationRepository;

    /**
     * @var SendNotificationService
     */
    private $sendNotificationService;

    /**
     * @param NotificationRepository $notificationRepository
     * @param SendNotificationService $sendNotificationService
     */
    public function __construct(
        NotificationRepository $notificationRepository,
        SendNotificationService $sendNotificationService
    ) {
        $this->notificationRepository = $notificationRepository;
        $this->sendNotificationService = $sendNotificationService;
    }

    /**
     * @param SendFreshNotifications $command
     */
    public function handle(SendFreshNotifications $command): void

    {
        $notifications = $this->notificationRepository->unsentNotifications();
        foreach ($notifications as $notification) {
            $this->sendNotificationService->execute($notification);
        }
    }
}


1			<?php
2			declare(strict_types=1);
3
4			namespace Shippinno\Notification\Application\Command;
5
6			use Shippinno\Notification\Domain\Model\NotificationRepository;
7			use Shippinno\Notification\Domain\Model\SendNotification as SendNotificationService;
8
9			class SendFreshNotificationsHandler
10			{
11			/**
12			* @var NotificationRepository
13			*/
14			private $notificationRepository;
15
16			/**
17			* @var SendNotificationService
18			*/
19			private $sendNotificationService;
20
21			/**
22			* @param NotificationRepository $notificationRepository
23			* @param SendNotificationService $sendNotificationService
24			*/
25			public function __construct(
26			NotificationRepository $notificationRepository,
27			SendNotificationService $sendNotificationService
28			) {
29			$this->notificationRepository = $notificationRepository;
30			$this->sendNotificationService = $sendNotificationService;
31			}
32
33			/**
34			* @param SendFreshNotifications $command
35			*/
36			public function handle(SendFreshNotifications $command): void
			1 ignored issue – show Unused Code introduced 2018-11-01 17:58 UTC by Report Bug Copy Issue Report The parameter `$command` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
37			{
38			$notifications = $this->notificationRepository->unsentNotifications();
39			foreach ($notifications as $notification) {
40			$this->sendNotificationService->execute($notification);
41			}
42			}
43			}
44

shippinno / notification

Push — master ( 6f7a22...abd8b8 )

SendFreshNotificationsHandler::handle() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like