InMemoryNotificationRepository::add() - Code Metrics - Inspection of "Merge remote-tracking branch 'origin/master'" - shippinno/notification - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( dd3a40...b9ffdf )

by Hirofumi

created 2018-11-01 17:51 UTC

InMemoryNotificationRepository::add() A

↳ Parent: InMemoryNotificationRepository

Complexity

Conditions	3
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	3.0416

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	5
cts	6
cp	0.8333
rs	10
c	0
b	0
f	0
cc	3
nc	2
nop	1
crap	3.0416

<?php
declare(strict_types=1);

namespace Shippinno\Notification\Infrastructure\Domain\Model;

use Shippinno\Notification\Domain\Model\DeduplicationKey;
use Shippinno\Notification\Domain\Model\Notification;
use Shippinno\Notification\Domain\Model\NotificationId;
use Shippinno\Notification\Domain\Model\NotificationRepository;

class InMemoryNotificationRepository implements NotificationRepository
{
    /**
     * @var Notification[]
     */
    private $notifications = [];

    private $nextIdentity = 1;

    /**
     * {@inheritdoc}
     */
    public function add(Notification $notification): void
    {
        $deduplicationKey = $notification->deduplicationKey();
        if (!is_null($deduplicationKey) && $this->hasNotificationOfDeduplicationKey($deduplicationKey)) {
            return;
        }
        $this->notifications[$this->nextIdentity()->id()] = $notification;
    }

    /**
     * {@inheritdoc}
     */
    public function notificationOfId(NotificationId $notificationId): ?Notification
    {
        if (!isset($this->notifications[$notificationId->id()])) {
            return null;
        }

        return $this->notifications[$notificationId->id()];
    }

    /**
     * {@inheritdoc}
     */
    public function hasNotificationOfDeduplicationKey(DeduplicationKey $deduplicationKey): bool
    {
        foreach ($this->notifications as $notification) {
            if ($notification->deduplicationKey()->equals($deduplicationKey)) {
                return true;
            }
        }
    }

    /**
     * {@inheritdoc}
     */
    public function unsentNotifications(): array
    {
        return array_filter($this->notifications, function (Notification $notification) {
            return !$notification->isSent();
        });
    }

    /**
     * @return NotificationId
     */
    private function nextIdentity(): NotificationId
    {
        return new NotificationId($this->nextIdentity++);
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace Shippinno\Notification\Infrastructure\Domain\Model;
5
6		use Shippinno\Notification\Domain\Model\DeduplicationKey;
7		use Shippinno\Notification\Domain\Model\Notification;
8		use Shippinno\Notification\Domain\Model\NotificationId;
9		use Shippinno\Notification\Domain\Model\NotificationRepository;
10
11		class InMemoryNotificationRepository implements NotificationRepository
12		{
13		/**
14		* @var Notification[]
15		*/
16		private $notifications = [];
17
18		private $nextIdentity = 1;
19
20		/**
21		* {@inheritdoc}
22		*/
23	1	public function add(Notification $notification): void
24		{
25	1	$deduplicationKey = $notification->deduplicationKey();
26	1	if (!is_null($deduplicationKey) && $this->hasNotificationOfDeduplicationKey($deduplicationKey)) {
27		return;
28		}
29	1	$this->notifications[$this->nextIdentity()->id()] = $notification;
30	1	}
31
32		/**
33		* {@inheritdoc}
34		*/
35	2	public function notificationOfId(NotificationId $notificationId): ?Notification
36		{
37	2	if (!isset($this->notifications[$notificationId->id()])) {
38	1	return null;
39		}
40
41	1	return $this->notifications[$notificationId->id()];
42		}
43
44		/**
45		* {@inheritdoc}
46		*/
47		public function hasNotificationOfDeduplicationKey(DeduplicationKey $deduplicationKey): bool
48		{
49		foreach ($this->notifications as $notification) {
50		if ($notification->deduplicationKey()->equals($deduplicationKey)) {
51		return true;
52		}
53		}
54		}
55
56		/**
57		* {@inheritdoc}
58		*/
59		public function unsentNotifications(): array
60		{
61		return array_filter($this->notifications, function (Notification $notification) {
62		return !$notification->isSent();
63		});
64		}
65
66		/**
67		* @return NotificationId
68		*/
69	1	private function nextIdentity(): NotificationId
70		{
71	1	return new NotificationId($this->nextIdentity++);
72		}
73		}
74

shippinno / notification

Push — master ( dd3a40...b9ffdf )

InMemoryNotificationRepository::add() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like