SendUnsentNotificationsHandler::handle() - Code Metrics - Inspection of "Merge remote-tracking branch 'origin/master'" - shippinno/notification - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( dd3a40...b9ffdf )

by Hirofumi

created 2018-11-01 17:51 UTC

SendUnsentNotificationsHandler::handle() A

↳ Parent: SendUnsentNotificationsHandler

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	0
cts	8
cp	0
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	1
crap	6

<?php

namespace Shippinno\Notification\Application\Command;

use Shippinno\Notification\Domain\Model\GatewayRegistry;
use Shippinno\Notification\Domain\Model\NotificationRepository;

class SendUnsentNotificationsHandler
{
    /**
     * @var NotificationRepository
     */
    private $notificationRepository;

    /**
     * @var GatewayRegistry
     */
    private $gatewayRegistry;

    /**
     * @param NotificationRepository $notificationRepository
     * @param GatewayRegistry $gatewayRegistry
     */
    public function __construct(
        NotificationRepository $notificationRepository,
        GatewayRegistry $gatewayRegistry
    ) {
        $this->notificationRepository = $notificationRepository;
        $this->gatewayRegistry = $gatewayRegistry;
    }

    /**
     * @param SendUnsentNotifications $command
     */
    public function handle(SendUnsentNotifications $command): void

    {
        $notifications = $this->notificationRepository->unsentNotifications();
        foreach ($notifications as $notification) {
            $this->gatewayRegistry->get($notification->destination())->send($notification);
            $notification->markSent();
        }
    }
}


1			<?php
2
3			namespace Shippinno\Notification\Application\Command;
4
5			use Shippinno\Notification\Domain\Model\GatewayRegistry;
6			use Shippinno\Notification\Domain\Model\NotificationRepository;
7
8			class SendUnsentNotificationsHandler
9			{
10			/**
11			* @var NotificationRepository
12			*/
13			private $notificationRepository;
14
15			/**
16			* @var GatewayRegistry
17			*/
18			private $gatewayRegistry;
19
20			/**
21			* @param NotificationRepository $notificationRepository
22			* @param GatewayRegistry $gatewayRegistry
23			*/
24			public function __construct(
25			NotificationRepository $notificationRepository,
26			GatewayRegistry $gatewayRegistry
27			) {
28			$this->notificationRepository = $notificationRepository;
29			$this->gatewayRegistry = $gatewayRegistry;
30			}
31
32			/**
33			* @param SendUnsentNotifications $command
34			*/
35			public function handle(SendUnsentNotifications $command): void
			1 ignored issue – show Unused Code introduced 2018-11-01 17:58 UTC by Report Bug Copy Issue Report The parameter `$command` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
36			{
37			$notifications = $this->notificationRepository->unsentNotifications();
38			foreach ($notifications as $notification) {
39			$this->gatewayRegistry->get($notification->destination())->send($notification);
40			$notification->markSent();
41			}
42			}
43			}
44

shippinno / notification

Push — master ( dd3a40...b9ffdf )

SendUnsentNotificationsHandler::handle() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like