DestinationRegistry - Code Metrics - Inspection of "redesigned some" - shippinno/notification - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 66351d...335aef )

by Hirofumi

created 2018-11-05 14:03 UTC

DestinationRegistry A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	59
Duplicated Lines	100 %

Coupling/Cohesion

Components	2
Dependencies	0

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	6
lcom	2
cbo	0
dl	59
loc	59
ccs	0
cts	27
cp	0
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	instance()	8	8	2
A	set()	4	4	1
A	setAll()	4	4	1
A	get()	13	13	2

How to fix Duplicated Code

<?php

namespace Shippinno\Notification\Domain\Model;

use InvalidArgumentException;

class DestinationRegistry

{
    /**
     * @var null|DestinationRegistry
     */
    private static $instance = null;

    /**
     * @var Destination[]
     */
    protected $destinations = [];

    /**
     * @return DestinationRegistry
     */
    public static function instance(): DestinationRegistry
    {
        if (null === static::$instance) {
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
            static::$instance = new DestinationRegistry;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
        }

        return static::$instance;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
    }

    /**
     * @param string $name
     * @param Destination $destination
     */
    public function set(string $name, Destination $destination): void
    {
        $this->destinations[$name] = $destination;
    }

    /**
     * @param array $destinations
     */
    public function setAll(array $destinations): void
    {
        $this->destinations = $destinations;
    }

    /**
     * @param string $name
     * @return Destination
     */
    public function get(string $name): Destination
    {
        if (!isset($this->destinations[$name])) {
            throw new InvalidArgumentException(
                sprintf(
                    'No destination is registered with name (%s).',
                    $name
                )
            );
        }

        return $this->destinations[$name];
    }
}


1		<?php
2
3		namespace Shippinno\Notification\Domain\Model;
4
5		use InvalidArgumentException;
6
7	View Code Duplication	class DestinationRegistry
		0 ignored issues – show Duplication introduced 2018-11-05 14:23 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
8		{
9		/**
10		* @var null\|DestinationRegistry
11		*/
12		private static $instance = null;
13
14		/**
15		* @var Destination[]
16		*/
17		protected $destinations = [];
18
19		/**
20		* @return DestinationRegistry
21		*/
22		public static function instance(): DestinationRegistry
23		{
24		if (null === static::$instance) {
		0 ignored issues – show Bug introduced 2018-11-05 09:18 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
25		static::$instance = new DestinationRegistry;
		0 ignored issues – show Bug introduced 2018-11-05 09:18 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
26		}
27
28		return static::$instance;
		0 ignored issues – show Bug introduced 2018-11-05 09:18 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
29		}
30
31		/**
32		* @param string $name
33		* @param Destination $destination
34		*/
35		public function set(string $name, Destination $destination): void
36		{
37		$this->destinations[$name] = $destination;
38		}
39
40		/**
41		* @param array $destinations
42		*/
43		public function setAll(array $destinations): void
44		{
45		$this->destinations = $destinations;
46		}
47
48		/**
49		* @param string $name
50		* @return Destination
51		*/
52		public function get(string $name): Destination
53		{
54		if (!isset($this->destinations[$name])) {
55		throw new InvalidArgumentException(
56		sprintf(
57		'No destination is registered with name (%s).',
58		$name
59		)
60		);
61		}
62
63		return $this->destinations[$name];
64		}
65		}
66

shippinno / notification

Push — master ( 66351d...335aef )

DestinationRegistry A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like