JobConsume::consume() - Code Metrics - Inspection of "d" - shippinno/job - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 301252...c2a612 )

by Hirofumi

created 2018-03-27 06:03 UTC

JobConsume::consume() B

↳ Parent: JobConsume

Complexity

Conditions	6
Paths	27

Size

Total Lines	31
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	20
CRAP Score	6.027

Importance

Changes

Metric	Value
dl	0
loc	31
ccs	20
cts	22
cp	0.9091
rs	8.439
c	0
b	0
f	0
cc	6
eloc	22
nc	27
nop	1
crap	6.027

<?php

namespace Shippinno\Job\Infrastructure\Ui\Console\Laravel\Command;

use Doctrine\ORM\EntityManager;
use Illuminate\Console\Command;
use Illuminate\Contracts\Console\Application;
use Illuminate\Contracts\Container\Container;
use Interop\Queue\PsrConsumer;
use Interop\Queue\PsrContext;
use Interop\Queue\PsrMessage;
use JMS\Serializer\Serializer;
use Shippinno\Job\Application\Job\Job;
use Shippinno\Job\Application\Job\JobRunner;
use Shippinno\Job\Domain\Model\JobFailedException;

class JobConsume extends Command
{
    /**
     * {@inheritdoc}
     */
    protected $signature = 'job:consume';

    /**
     * @var PsrContext
     */
    private $context;

    /**
     * @var Serializer
     */
    private $serializer;

    /**
     * @var EntityManager
     */
    private $entityManager;

    /**
     * @var Container
     */
    private $container;

    /**
     * @param PsrContext $context
     * @param Serializer $serializer
     * @param EntityManager $entityManager
     * @param Container $container
     */
    public function __construct(
        PsrContext $context,
        Serializer $serializer,
        EntityManager $entityManager,
function someFunction(ManagerRegistry $registry) {
    $em = $registry->getManager();
    $em->getConnection()->beginTransaction();
    try {
        // Do something.
        $em->getConnection()->commit();
    } catch (\Exception $ex) {
        $em->getConnection()->rollback();
        $em->close();

        throw $ex;
    }
}
        Container $container
    ) {
        parent::__construct();
        $this->context = $context;
        $this->serializer = $serializer;
        $this->entityManager = $entityManager;
        $this->container = $container;
    }

    /**
     * @throws \Doctrine\Common\Persistence\Mapping\MappingException
     * @throws \Doctrine\ORM\ORMException
     * @throws \Doctrine\ORM\OptimisticLockException
     */
    public function handle()
    {
        $consumer = $this->createConsumer();
        while (true) {
            $this->consume($consumer);
        }
    }

    /**
     * @return PsrConsumer
     */
    protected function createConsumer(): PsrConsumer
    {
        $queue = $this->context->createQueue('test');
        $consumer = $this->context->createConsumer($queue);

        return $consumer;
    }

    /**
     * @param PsrConsumer $consumer
     * @throws \Doctrine\Common\Persistence\Mapping\MappingException
     * @throws \Doctrine\ORM\ORMException
     * @throws \Doctrine\ORM\OptimisticLockException
     */
    protected function consume(PsrConsumer $consumer)
    {
        $this->entityManager->clear();
        $message = $consumer->receive();
        if (null === $message) {
            return;
        }
        $messageBody = json_decode($message->getBody());
        /** @var Job $job */
        $job = $this->serializer->deserialize($messageBody->body, $messageBody->name, 'json');
        if ($message->getProperty('attempts') > $job->maxAttempts()) {
            $consumer->reject($message);
        }
        /** @var JobRunner $jobRunner */
        $jobRunner = $this->container->make($job->jobRunner());
        try {
            $jobRunner->run($job);
            $consumer->acknowledge($message);
        } catch (JobFailedException $e) {
            $message->setProperty(
                'attempts',
                intval($message->getProperty('attempts', 0)) ?: 0
            );
            if ($job->reattemptDelay() > 0) {
                $message = $this->delayMessage($message, $job->reattemptDelay());
            }
            $consumer->reject($message, true);
        } finally {
            $this->entityManager->flush();
        }
    }

    /**
     * @param PsrMessage $message
     * @param int $delay
     * @return PsrMessage
     */
    protected function delayMessage(PsrMessage $message, int $delay)
    {
        if (method_exists($message, 'setDelaySeconds')) {
            $message->setDelaySeconds($delay);

        }

        return $message;
    }
}


1		<?php
2
3		namespace Shippinno\Job\Infrastructure\Ui\Console\Laravel\Command;
4
5		use Doctrine\ORM\EntityManager;
6		use Illuminate\Console\Command;
7		use Illuminate\Contracts\Console\Application;
8		use Illuminate\Contracts\Container\Container;
9		use Interop\Queue\PsrConsumer;
10		use Interop\Queue\PsrContext;
11		use Interop\Queue\PsrMessage;
12		use JMS\Serializer\Serializer;
13		use Shippinno\Job\Application\Job\Job;
14		use Shippinno\Job\Application\Job\JobRunner;
15		use Shippinno\Job\Domain\Model\JobFailedException;
16
17		class JobConsume extends Command
18		{
19		/**
20		* {@inheritdoc}
21		*/
22		protected $signature = 'job:consume';
23
24		/**
25		* @var PsrContext
26		*/
27		private $context;
28
29		/**
30		* @var Serializer
31		*/
32		private $serializer;
33
34		/**
35		* @var EntityManager
36		*/
37		private $entityManager;
38
39		/**
40		* @var Container
41		*/
42		private $container;
43
44		/**
45		* @param PsrContext $context
46		* @param Serializer $serializer
47		* @param EntityManager $entityManager
48		* @param Container $container
49		*/
50	3	public function __construct(
51		PsrContext $context,
52		Serializer $serializer,
53		EntityManager $entityManager,
		0 ignored issues – show Bug introduced 2018-03-27 05:55 UTC by Report Bug Copy Issue Report You have injected the EntityManager via parameter `$entityManager`. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via `getManager()` each time you need it. The `EntityManager` might become unusable for example if a transaction is rolled back and it gets closed. Let’s assume that somewhere in your application, or in a third-party library, there is code such as the following: function someFunction(ManagerRegistry $registry) { $em = $registry->getManager(); $em->getConnection()->beginTransaction(); try { // Do something. $em->getConnection()->commit(); } catch (\Exception $ex) { $em->getConnection()->rollback(); $em->close(); throw $ex; } } If that code throws an exception and the `EntityManager` is closed. Any other code which depends on the same instance of the `EntityManager` during this request will fail. On the other hand, if you instead inject the `ManagerRegistry`, the `getManager()` method guarantees that you will always get a usable manager instance. Loading history...
54		Container $container
55		) {
56	3	parent::__construct();
57	3	$this->context = $context;
58	3	$this->serializer = $serializer;
59	3	$this->entityManager = $entityManager;
60	3	$this->container = $container;
61	3	}
62
63		/**
64		* @throws \Doctrine\Common\Persistence\Mapping\MappingException
65		* @throws \Doctrine\ORM\ORMException
66		* @throws \Doctrine\ORM\OptimisticLockException
67		*/
68		public function handle()
69		{
70		$consumer = $this->createConsumer();
71		while (true) {
72		$this->consume($consumer);
73		}
74		}
75
76		/**
77		* @return PsrConsumer
78		*/
79		protected function createConsumer(): PsrConsumer
80		{
81		$queue = $this->context->createQueue('test');
82		$consumer = $this->context->createConsumer($queue);
83
84		return $consumer;
85		}
86
87		/**
88		* @param PsrConsumer $consumer
89		* @throws \Doctrine\Common\Persistence\Mapping\MappingException
90		* @throws \Doctrine\ORM\ORMException
91		* @throws \Doctrine\ORM\OptimisticLockException
92		*/
93	3	protected function consume(PsrConsumer $consumer)
94		{
95	3	$this->entityManager->clear();
96	3	$message = $consumer->receive();
97	3	if (null === $message) {
98		return;
99		}
100	3	$messageBody = json_decode($message->getBody());
101		/** @var Job $job */
102	3	$job = $this->serializer->deserialize($messageBody->body, $messageBody->name, 'json');
103	3	if ($message->getProperty('attempts') > $job->maxAttempts()) {
104	1	$consumer->reject($message);
105		}
106		/** @var JobRunner $jobRunner */
107	3	$jobRunner = $this->container->make($job->jobRunner());
108		try {
109	3	$jobRunner->run($job);
110	1	$consumer->acknowledge($message);
111	2	} catch (JobFailedException $e) {
112	2	$message->setProperty(
113	2	'attempts',
114	2	intval($message->getProperty('attempts', 0)) ?: 0
115		);
116	2	if ($job->reattemptDelay() > 0) {
117		$message = $this->delayMessage($message, $job->reattemptDelay());
118		}
119	2	$consumer->reject($message, true);
120	3	} finally {
121	3	$this->entityManager->flush();
122		}
123	3	}
124
125		/**
126		* @param PsrMessage $message
127		* @param int $delay
128		* @return PsrMessage
129		*/
130		protected function delayMessage(PsrMessage $message, int $delay)
131		{
132		if (method_exists($message, 'setDelaySeconds')) {
133		$message->setDelaySeconds($delay);
		0 ignored issues – show Bug introduced 2018-03-27 05:55 UTC by Report Bug Copy Issue Report The method `setDelaySeconds()` does not seem to exist on `object<Interop\Queue\PsrMessage>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
134		}
135
136		return $message;
137		}
138		}
139

shippinno / job

Push — master ( 301252...c2a612 )

JobConsume::consume() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like