shibdib / Dramiel

src/plugins/onTick/twitterOutput.php

<?php
/**
 * The MIT License (MIT)
 *
 * Copyright (c) 2016 Robert Sardinia
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

use discord\discord;

/**
 * Class twitterOutput
 */
class twitterOutput

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public $config;
    public $discord;
    public $logger;
    public $guild;
    private $twitter;
    private $lastCheck;
    private $lastID;
    private $channelID;
    private $maxID;

    /**
     * @param $config
     * @param $discord
     * @param $logger
     */
    public function init($config, $discord, $logger)
    {
        $this->config = $config;
        $this->discord = $discord;
        $this->logger = $logger;
        $this->guild = $config['bot']['guild'];
        $this->twitter = new Twitter($config['twitter']['consumerKey'], $config['twitter']['consumerSecret'], $config['twitter']['accessToken'], $config['twitter']['accessTokenSecret']);
        $this->lastCheck = time();
        $this->maxID = 0;
        $this->channelID = $config['plugins']['twitterOutput']['channelID']; // outputs to the news channel on the 4M server
    }

    /**
     *
     */
    public function tick()
    {
        $continue = false;
        $data = array();
        // If last check + 60 seconds is larger or equal to the current time(), we run
        if ($this->lastCheck <= time()) {
            // Fetch the last 25 twitter replies and/or searches
            try {
                $data = $this->twitter->load(Twitter::ME_AND_FRIENDS, 5);
                foreach ($data as $message) {

The expression $data of type object<stdClass>|array<integer,object<stdClass>> is not guaranteed to be traversable. How about adding an additional type check?

                    $text = (array) $message->text;
                    $createdAt = (array) $message->created_at;
                    $postedBy = (array) $message->user->name;
                    $screenName = (array) $message->user->screen_name;
                    $id = (int) $message->id;
                    $this->lastID = getPermCache('twitterLatestID'); // get the last posted ID

                    if ($id <= $this->lastID) {
                        continue;
                    }

                    $this->maxID = max($id, $this->maxID);

                    $url = 'https://twitter.com/' . $screenName[0] . '/status/' . $id;
                    $message = array('message' => $text[0], 'postedAt' => $createdAt[0], 'postedBy' => $postedBy[0], 'screenName' => $screenName[0], 'url' => $url . $id[0]);
                    $msg = '**@' . $screenName[0] . '** (' . $message['postedBy'] . ') / ' . htmlspecialchars_decode($message['message']);
                    $messages[$id] = $msg;

$messages was never initialized. Although not strictly required by PHP, it is generally a good practice to add $messages = array(); before regardless.

                    $continue = true;

                    if (count($data)) {
                        setPermCache('twitterLatestID', $this->maxID);
                    }
                }
            } catch (Exception $e) {
                //$this->logger->err("Twitter Error: " . $e->getMessage()); // Don't show there was an error, it's most likely just a rate limit
            }

            if ($continue === true) {
                ksort($messages);

                foreach ($messages as $id => $msg) {
                    // Send the tweets to the channel
                    $channelID = $this->channelID;
                    queueMessage($msg, $channelID, $this->guild);
                    $this->logger->addInfo('twitterOutput: Tweet queued.');
                }
            }
            $this->lastCheck = time() + 60;
        }
    }

    /**
     * @param $url
     * @return string
     */
    public function shortenUrl($url)
    {
        return file_get_contents('http://is.gd/api.php?longurl=' . $url);
    }
}