Issues in about.php (master) - Issues in master - shibdib/Dramiel - Measure and Improve Code Quality continuously with Scrutinizer

Issues (205)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/plugins/onMessage/about.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * The MIT License (MIT)
 *
 * Copyright (c) 2016 Robert Sardinia
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

/**
 * Class about
 */
class about
namespace YourVendor;

class YourClass { }
{
    public $config;
    public $discord;
    public $logger;
    public $message;
    private $excludeChannel;
    private $triggers;

    /**
     * @param $config
     * @param $discord
     * @param $logger
     * @internal param $message
     */
    public function init($config, $discord, $logger)

    {
        $this->config = $config;
        $this->discord = $discord;
        $this->logger = $logger;
        $this->excludeChannel = $this->config['bot']['restrictedChannels'];
        $this->triggers[] = $this->config['bot']['trigger'] . 'about';
        $this->triggers[] = $this->config['bot']['trigger'] . 'About';
    }

    /**
     * @param $msgData
     * @param $message
     * @return null
     */
    public function onMessage($msgData, $message)
    {
        $this->message = $message;
        $info['guilds'] = $this->discord->guilds->count();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $channelID = (int) $msgData['message']['channelID'];

        if (in_array($channelID, $this->excludeChannel, true))
        {
            return null;
        }

        global $startTime; // Get the starttime of the bot
function myFunction($a, $b) {
    // Do something
}
        $time1 = new DateTime(date('Y-m-d H:i:s', $startTime));
        $time2 = new DateTime(date('Y-m-d H:i:s'));
        $interval = $time1->diff($time2);

        $botID = $this->discord->id;

        $message = $msgData['message']['message'];
        $user = $msgData['message']['from'];

        $data = command($message, $this->information()['trigger'], $this->config['bot']['trigger']);
        if (isset($data['trigger'])) {
            $gitRevision = gitRevision();
            $gitBranch = gitBranch();
            $msg = '```
Developer: Shibdib (In-game Name: Mr Twinkie)

Bot ID: ' . $botID . '

Current Version: ' . $gitRevision['short'] . '
Current Branch: ' . $gitBranch . "
Github Repo: https://github.com/shibdib/Dramiel

Statistics:
Currently on {$info['guilds']} different discord servers.
Up-time: " . $interval->y . ' Year(s), ' . $interval->m . ' Month(s), ' . $interval->d . ' Days, ' . $interval->h . ' Hours, ' . $interval->i . ' Minutes, ' . $interval->s . ' seconds.
Memory Usage: ~' . round(memory_get_usage() / 1024 / 1024, 3) . 'MB```';
            $this->logger->addInfo("About: Sending about info to {$user}");
            $this->message->reply($msg);
        }
    }

    /**
     * @return array
     */
    public function information()
    {
        return array(
            'name' => 'about',
            'trigger' => $this->triggers,
            'information' => "Shows information on the bot, who created it, what library it's using, revision, and other stats. Example: !about"
        );
    }
}


1		<?php
2		/**
3		* The MIT License (MIT)
4		*
5		* Copyright (c) 2016 Robert Sardinia
6		*
7		* Permission is hereby granted, free of charge, to any person obtaining a copy
8		* of this software and associated documentation files (the "Software"), to deal
9		* in the Software without restriction, including without limitation the rights
10		* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
11		* copies of the Software, and to permit persons to whom the Software is
12		* furnished to do so, subject to the following conditions:
13		*
14		* The above copyright notice and this permission notice shall be included in all
15		* copies or substantial portions of the Software.
16		*
17		* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
18		* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
19		* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
20		* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
21		* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
22		* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
23		* SOFTWARE.
24		*/
25
26		/**
27		* Class about
28		*/
29		class about
		0 ignored issues – show Coding Style Compatibility introduced 2016-07-16 19:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
30		{
31		public $config;
32		public $discord;
33		public $logger;
34		public $message;
35		private $excludeChannel;
36		private $triggers;
37
38		/**
39		* @param $config
40		* @param $discord
41		* @param $logger
42		* @internal param $message
43		*/
44	View Code Duplication	public function init($config, $discord, $logger)
		0 ignored issues – show Duplication introduced 2017-08-09 18:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45		{
46		$this->config = $config;
47		$this->discord = $discord;
48		$this->logger = $logger;
49		$this->excludeChannel = $this->config['bot']['restrictedChannels'];
50		$this->triggers[] = $this->config['bot']['trigger'] . 'about';
51		$this->triggers[] = $this->config['bot']['trigger'] . 'About';
52		}
53
54		/**
55		* @param $msgData
56		* @param $message
57		* @return null
58		*/
59		public function onMessage($msgData, $message)
60		{
61		$this->message = $message;
62		$info['guilds'] = $this->discord->guilds->count();
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-07-17 01:01 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$info` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$info = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
63		$channelID = (int) $msgData['message']['channelID'];
64
65		if (in_array($channelID, $this->excludeChannel, true))
66		{
67		return null;
68		}
69
70		global $startTime; // Get the starttime of the bot
		0 ignored issues – show Compatibility Best Practice introduced 2016-07-16 19:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
71		$time1 = new DateTime(date('Y-m-d H:i:s', $startTime));
72		$time2 = new DateTime(date('Y-m-d H:i:s'));
73		$interval = $time1->diff($time2);
74
75		$botID = $this->discord->id;
76
77		$message = $msgData['message']['message'];
78		$user = $msgData['message']['from'];
79
80		$data = command($message, $this->information()['trigger'], $this->config['bot']['trigger']);
81		if (isset($data['trigger'])) {
82		$gitRevision = gitRevision();
83		$gitBranch = gitBranch();
84		$msg = '```
85		Developer: Shibdib (In-game Name: Mr Twinkie)
86
87		Bot ID: ' . $botID . '
88
89		Current Version: ' . $gitRevision['short'] . '
90		Current Branch: ' . $gitBranch . "
91		Github Repo: https://github.com/shibdib/Dramiel
92
93		Statistics:
94		Currently on {$info['guilds']} different discord servers.
95		Up-time: " . $interval->y . ' Year(s), ' . $interval->m . ' Month(s), ' . $interval->d . ' Days, ' . $interval->h . ' Hours, ' . $interval->i . ' Minutes, ' . $interval->s . ' seconds.
96		Memory Usage: ~' . round(memory_get_usage() / 1024 / 1024, 3) . 'MB```';
97		$this->logger->addInfo("About: Sending about info to {$user}");
98		$this->message->reply($msg);
99		}
100		}
101
102		/**
103		* @return array
104		*/
105		public function information()
106		{
107		return array(
108		'name' => 'about',
109		'trigger' => $this->triggers,
110		'information' => "Shows information on the bot, who created it, what library it's using, revision, and other stats. Example: !about"
111		);
112		}
113		}
114

shibdib / Dramiel

Issues (205)

Security Analysis no request data

src/plugins/onMessage/about.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like