shibdib /
Dramiel
| Conditions | 20 |
| Paths | 769 |
| Total Lines | 87 |
| Code Lines | 61 |
| Lines | 12 |
| Ratio | 13.79 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 84 | private function getKM() |
||
| 85 | { |
||
| 86 | foreach ($this->groupConfig as $kmGroup) { |
||
| 87 | $killID = getPermCache("{$kmGroup['name']}newestKillmailID"); |
||
| 88 | //check if start id is greater than current id and if it is set |
||
| 89 | if ($kmGroup['startMail'] > $killID || null === $killID) { |
||
| 90 | $killID = $kmGroup['startMail']; |
||
| 91 | } |
||
| 92 | View Code Duplication | if ($kmGroup['allianceID'] == '0' & $kmGroup['lossMails'] === 'true') { |
|
| 93 | $url = "https://zkillboard.com/api/no-attackers/no-items/orderDirection/asc/afterKillID/{$killID}/corporationID/{$kmGroup['corpID']}/"; |
||
| 94 | } |
||
| 95 | View Code Duplication | if ($kmGroup['allianceID'] == '0' & $kmGroup['lossMails'] === 'false') { |
|
| 96 | $url = "https://zkillboard.com/api/no-attackers/no-items/kills/orderDirection/asc/afterKillID/{$killID}/corporationID/{$kmGroup['corpID']}/"; |
||
| 97 | } |
||
| 98 | View Code Duplication | if ($kmGroup['allianceID'] != '0' & $kmGroup['lossMails'] === 'true') { |
|
| 99 | $url = "https://zkillboard.com/api/no-attackers/no-items/orderDirection/asc/afterKillID/{$killID}/allianceID/{$kmGroup['allianceID']}/"; |
||
| 100 | } |
||
| 101 | View Code Duplication | if ($kmGroup['allianceID'] != '0' & $kmGroup['lossMails'] === 'false') { |
|
| 102 | $url = "https://zkillboard.com/api/no-attackers/no-items/kills/orderDirection/asc/afterKillID/{$killID}/allianceID/{$kmGroup['allianceID']}/"; |
||
| 103 | } |
||
| 104 | |||
| 105 | if (!isset($url)) { // Make sure it's always set. |
||
| 106 | $this->logger->addInfo('Killmails: ERROR - Ensure your config file is setup correctly for killmails.'); |
||
| 107 | return null; |
||
| 108 | } |
||
| 109 | |||
| 110 | $kills = json_decode(downloadData($url), true); |
||
| 111 | $i = 0; |
||
| 112 | if (isset($kills)) { |
||
| 113 | foreach ($kills as $kill) { |
||
| 114 | if ($i < 10) { |
||
| 115 | //if big kill isn't set, disable it |
||
| 116 | if (null === $kmGroup['bigKill']) { |
||
| 117 | $kmGroup['bigKill'] = 99999999999999999999999999; |
||
| 118 | } |
||
| 119 | $killID = $kill['killID']; |
||
| 120 | $channelID = $kmGroup['channel']; |
||
| 121 | $solarSystemID = $kill['solarSystemID']; |
||
| 122 | $systemName = systemName($solarSystemID); |
||
| 123 | $killTime = $kill['killTime']; |
||
| 124 | $victimAllianceName = $kill['victim']['allianceName']; |
||
| 125 | $victimName = $kill['victim']['characterName']; |
||
| 126 | $victimCorpName = $kill['victim']['corporationName']; |
||
| 127 | $victimShipID = $kill['victim']['shipTypeID']; |
||
| 128 | $shipName = apiTypeName($victimShipID); |
||
| 129 | $rawValue = $kill['zkb']['totalValue']; |
||
| 130 | //Check if killmail meets minimum value |
||
| 131 | if (isset($kmGroup['minimumValue'])) { |
||
| 132 | if ($rawValue < $kmGroup['minimumValue']) { |
||
| 133 | $this->logger->addInfo("Killmails: Mail {$killID} ignored for not meeting the minimum value required."); |
||
| 134 | setPermCache("{$kmGroup['name']}newestKillmailID", $killID); |
||
| 135 | continue; |
||
| 136 | } |
||
| 137 | } |
||
| 138 | $totalValue = number_format($kill['zkb']['totalValue']); |
||
| 139 | // Check if it's a structure |
||
| 140 | if ($victimName !== '') { |
||
| 141 | if ($rawValue >= $kmGroup['bigKill']) { |
||
| 142 | $channelID = $kmGroup['bigKillChannel']; |
||
| 143 | $msg = "@here \n :warning:***Expensive Killmail***:warning: \n **{$killTime}**\n\n**{$shipName}** worth **{$totalValue} ISK** flown by **{$victimName}** of (***{$victimCorpName}|{$victimAllianceName}***) killed in {$systemName}\nhttps://zkillboard.com/kill/{$killID}/"; |
||
| 144 | } elseif ($rawValue <= $kmGroup['bigKill']) { |
||
| 145 | $msg = "**{$killTime}**\n\n**{$shipName}** worth **{$totalValue} ISK** flown by **{$victimName}** of (***{$victimCorpName}|{$victimAllianceName}***) killed in {$systemName}\nhttps://zkillboard.com/kill/{$killID}/"; |
||
| 146 | } |
||
| 147 | } elseif ($victimName === '') { |
||
| 148 | $msg = "**{$killTime}**\n\n**{$shipName}** worth **{$totalValue} ISK** owned by (***{$victimCorpName}|{$victimAllianceName}***) killed in {$systemName}\nhttps://zkillboard.com/kill/{$killID}/"; |
||
| 149 | } |
||
| 150 | |||
| 151 | if (!isset($msg)) { // Make sure it's always set. |
||
| 152 | return null; |
||
| 153 | } |
||
| 154 | queueMessage($msg, $channelID, $this->guild); |
||
| 155 | $this->logger->addInfo("Killmails: Mail {$killID} queued."); |
||
| 156 | |||
| 157 | $i++; |
||
| 158 | } else { |
||
| 159 | $updatedID = getPermCache("{$kmGroup['name']}newestKillmailID"); |
||
| 160 | $this->logger->addInfo("Killmails: Kill posting cap reached, newest kill id for {$kmGroup['name']} is {$updatedID}"); |
||
| 161 | break; |
||
| 162 | } |
||
| 163 | } |
||
| 164 | setPermCache("{$kmGroup['name']}newestKillmailID", $killID); |
||
| 165 | } |
||
| 166 | $updatedID = getPermCache("{$kmGroup['name']}newestKillmailID"); |
||
| 167 | $this->logger->addInfo("Killmails: All kills posted, newest kill id for {$kmGroup['name']} is {$updatedID}"); |
||
| 168 | continue; |
||
| 169 | } |
||
| 170 | } |
||
| 171 | |||
| 223 |
Loading history...
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.