+global\authCheck::checkAuth()

Complexity

Conditions	19
Paths	247

Size

Total Lines	136
Code Lines	97

Duplication

Lines	0
Ratio	0 %

Importance

Changes	16
Bugs	8	Features	0

<?php
    function checkAuth()

It is generally recommended to explicitly declare the visibility for methods.

    {
        if ($this->config["plugins"]["auth"]["periodicCheck"] == "true") {
            $db = $this->config["database"]["host"];
            $dbUser = $this->config["database"]["user"];
            $dbPass = $this->config["database"]["pass"];
            $dbName = $this->config["database"]["database"];
            $clientId = $this->config["bot"]["clientID"];

$clientId is not used, you could remove the assignment.

            $id = $this->config["bot"]["guild"];
            $allyID = $this->config["plugins"]["auth"]["allianceID"];
            $corpID = $this->config["plugins"]["auth"]["corpID"];
            $toDiscordChannel = $this->config["plugins"]["auth"]["alertChannel"];
            $conn = new mysqli($db, $dbUser, $dbPass, $dbName);

            //get bot ID so we don't remove out own roles
            $botID = $this->discord->id;

            //Remove members who have roles but never authed
            $guild = $this->discord->guilds->get('id', $id);
            foreach($guild->members as $member) {
                $notifier = null;

$notifier is not used, you could remove the assignment.

                $id = $member->id;
                $username = $member->username;
                $roles = $member->roles;

                $sql = "SELECT * FROM authUsers WHERE discordID='$id' AND active='yes'";

                $result = $conn->query($sql);
                if($result->num_rows == 0) {
                    foreach ($roles as $role) {
                        if(!isset($role->name)){
                            if($id != $botID){
                                $member->removeRole($role);
                                $member->save();
                                // Send the info to the channel
                                $msg = "{$username} has been removed from the {$role->name} role as they never authed (Someone manually assigned them roles).";
                                $channelID = $toDiscordChannel;
                                $channel = Channel::find($channelID);
                                $channel->sendMessage($msg, false);
                                $this->logger->addInfo("{$username} has been removed from the {$role->name} role as they never authed.");
                            }
                        }
                    }
                }
            }

            $sql = "SELECT characterID, discordID, eveName FROM authUsers WHERE active='yes'";

            $result = $conn->query($sql);
            $num_rows = $result->num_rows;

            if ($num_rows >= 2) {
                while ($rows = $result->fetch_assoc()) {
                    $charID = $rows['characterID'];
                    $discordID = $rows['discordID'];
                    $guild = $this->discord->guilds->first();
                    $member = $guild->members->get("id", $discordID);
                    $eveName = $rows['eveName'];
                    $roles = $member->roles;
                    $url = "https://api.eveonline.com/eve/CharacterAffiliation.xml.aspx?ids=$charID";
                    $xml = makeApiRequest($url);
                    if ($xml->result->rowset->row[0]) {
                        foreach ($xml->result->rowset->row as $character) {
                            if ($character->attributes()->allianceID != $allyID && $character->attributes()->corporationID != $corpID) {
                                foreach ($roles as $role) {
                                    $member->removeRole($role);
                                    $member->save();
                                }

                                $statsURL = "https://beta.eve-kill.net/api/corpInfo/corporationID/" . urlencode($corpID) . "/";
                                $stats = json_decode(downloadData($statsURL), true);

                                if (empty($stats)) {
                                    $stats["corporationName"] = "Unknown";
                                }

                                $corporationName = @$stats["corporationName"];

                                // Send the info to the channel
                                $msg = "{$eveName} roles have been removed, user is now a member of **{$corporationName}**.";
                                $channelID = $toDiscordChannel;
                                $channel = Channel::find($channelID);
                                $channel->sendMessage($msg, false);
                                $this->logger->addInfo("{$eveName} roles ({$role}) have been removed, user is now a member of **{$corporationName}**.");

The variable $role does not seem to be defined for all execution paths leading up to this point.

                                $sql = "UPDATE authUsers SET active='no' WHERE discordID='$discordID'";
                                $conn->query($sql);

                            }
                        }
                    }
                }
                $this->logger->addInfo("All users successfully authed.");
                $nextCheck = time() + 7200;
                setPermCache("authLastChecked", $nextCheck);
                if ($this->config["plugins"]["auth"]["nameEnforce"] == "true") {
                    while ($rows = $result->fetch_assoc()) {
                        $discordID = $rows['discordID'];
                        $eveName = $rows['eveName'];
                        $guild = $this->discord->guilds->first();
                        $member = $guild->members->get("id", $discordID);
                        $discordName = $member->user->username;
                        if ($discordName != $eveName) {
                            foreach ($roles as $role) {

The variable $roles does not seem to be defined for all execution paths leading up to this point.

                                $member->removeRole($role);
                            }

                            // Send the info to the channel
                            $msg = $discordName . " roles have been removed because their name no longer matches their ingame name.";
                            $channelID = $toDiscordChannel;
                            $channel = Channel::find($channelID);
                            $channel->sendMessage($msg, false);
                            $this->logger->addInfo($discordName . " roles have been removed because their name no longer matches their ingame name.");

                            $sql = "UPDATE authUsers SET active='no' WHERE discordID='$discordID'";
                            $conn->query($sql);
                        }
                    }
                    $this->logger->addInfo("All users names have been checked.");
                    $cacheTimer = gmdate("Y-m-d H:i:s", $nextCheck);
                    $this->logger->addInfo("Next auth and name check at {$cacheTimer} EVE");
                    return null;
                }
                $cacheTimer = gmdate("Y-m-d H:i:s", $nextCheck);
                $this->logger->addInfo("Next auth and name check at {$cacheTimer} EVE");
                return null;
            }
            $this->logger->addInfo("No users found in database.");
            $nextCheck = time() + 7200;
            setPermCache("authLastChecked", $nextCheck);
            $cacheTimer = gmdate("Y-m-d H:i:s", $nextCheck);
            $this->logger->addInfo("Next auth and name check at {$cacheTimer} EVE");
            return null;
        }
        return null;
    }