motd::onMessage() - Code Metrics - Inspection of "Daily Inspection: Merge pull request #236 from shi..." - shibdib/Dramiel - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Branch — dev (952e73)

unknown

created 2021-04-02 18:04 UTC

motd::onMessage() B

↳ Parent: motd

Complexity

Conditions	8
Paths	12

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	8
nc	12
nop	2
dl	0
loc	52
rs	7.8028
c	0
b	0
f	0

How to fix Long Method

<?php
/**
 * The MIT License (MIT)
 *
 * Copyright (c) 2016 Robert Sardinia
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */
/**
 * @property  message
 */
	class motd {
		public $config;
		public $discord;
		public $logger;
		public $message;
		private $excludeChannel;
		private $triggers;
		public function init($config, $discord, $logger) {
			$this->config = $config;
			$this->discord = $discord;
			$this->logger = $logger;
			$this->excludeChannel = $this->config['bot']['restrictedChannels'];
			$this->triggers[] = $this->config['bot']['trigger'] . 'motd';
			$this->triggers[] = $this->config['bot']['trigger'] . 'Motd';
			$this->triggers[] = $this->config['bot']['trigger'] . 'MOTD';
			$this->keyID = $config['plugins']['motd']['keyID'];
class MyClass { }

$x = new MyClass();
$x->foo = true;
			$this->vCode = $config['plugins']['motd']['vCode'];
class MyClass { }

$x = new MyClass();
$x->foo = true;
			$this->characterID = $config['plugins']['motd']['characterID'];
class MyClass { }

$x = new MyClass();
$x->foo = true;
			$this->channelname = $config['plugins']['motd']['channelname'];
class MyClass { }

$x = new MyClass();
$x->foo = true;
		}
		public function onMessage($msgData, $message) {
			$channelID = (int) $msgData['message']['channelID'];
			if (in_array($channelID, $this->excludeChannel, true)) {
				return null;
			}
			$this->message = $message;
			$user = $msgData['message']['from'];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
			$message = $msgData['message']['message'];
			$data = command($message, $this->information() ['trigger'], $this->config['bot']['trigger']);
			if (isset($data['trigger'])) {
				$keyID = $this->keyID;
				$vCode = $this->vCode;
				$characterID = $this->characterID;
				$channelname = $this->channelname;

        $urlChar = "https://api.eveonline.com/char/ChatChannels.xml.aspx?keyID=$keyID&vCode=$vCode&characterID=$characterID";
				$data = file_get_contents($urlChar);
				$list = new SimpleXMLElement($data);
				
				
				foreach ($list->result->rowset->row as $row) {
					$channeln = $row["displayName"];
					
					if ($channeln == $channelname) {
					//scrub the motd, then break it into 1900 chars or less. Limit is 2000 and want to leave room for the name of the person being replied too
					$comment = $row["motd"];
          $comment = str_replace("<BR>", "\n", $comment);
          $comment = str_replace("<br>", "\n", $comment);
          $comment = str_replace("<u>", "__", $comment);
          $comment = str_replace("</u>", "__", $comment);	
          $comment = str_replace("<b>", "**", $comment);	
          $comment = str_replace("</b>", "**", $comment);	
          $comment = str_replace("<i>", "*", $comment);	
          $comment = str_replace("</i>", "*", $comment);
					$comment = str_replace("&amp;", "&", $comment);
          $comment = strip_tags($comment);
					$comment2 = str_split($comment, 1900);
					
					$this->message->reply("\n $comment2[0]");
						if (!empty($comment2[1])) {
							$this->message->reply("\n $comment2[1]");
						}
						if (!empty($comment2[2])) {
							$this->message->reply("\n $comment2[2]");
						}
						if (!empty($comment2[3])) {
							$this->message->reply("\n $comment2[3]");
						}
					}
				}
			}
		}
		public function information() {
            return array('name' => 'motd', 'trigger' => $this->triggers, 'information' => 'Displays the MOTD, useful for seeing information displayed there when not in-game.');
		}
	}
?>



1			<?php
2			/**
3			* The MIT License (MIT)
4			*
5			* Copyright (c) 2016 Robert Sardinia
6			*
7			* Permission is hereby granted, free of charge, to any person obtaining a copy
8			* of this software and associated documentation files (the "Software"), to deal
9			* in the Software without restriction, including without limitation the rights
10			* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
11			* copies of the Software, and to permit persons to whom the Software is
12			* furnished to do so, subject to the following conditions:
13			*
14			* The above copyright notice and this permission notice shall be included in all
15			* copies or substantial portions of the Software.
16			*
17			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
18			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
19			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
20			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
21			* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
22			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
23			* SOFTWARE.
24			*/
25			/**
26			* @property message
27			*/
28			class motd {
29			public $config;
30			public $discord;
31			public $logger;
32			public $message;
33			private $excludeChannel;
34			private $triggers;
35			public function init($config, $discord, $logger) {
36			$this->config = $config;
37			$this->discord = $discord;
38			$this->logger = $logger;
39			$this->excludeChannel = $this->config['bot']['restrictedChannels'];
40			$this->triggers[] = $this->config['bot']['trigger'] . 'motd';
41			$this->triggers[] = $this->config['bot']['trigger'] . 'Motd';
42			$this->triggers[] = $this->config['bot']['trigger'] . 'MOTD';
43			$this->keyID = $config['plugins']['motd']['keyID'];
			0 ignored issues – show Bug introduced 2017-01-12 19:55 UTC by Report Bug Copy Issue Report The property `keyID` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
44			$this->vCode = $config['plugins']['motd']['vCode'];
			0 ignored issues – show Bug introduced 2017-01-12 19:55 UTC by Report Bug Copy Issue Report The property `vCode` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
45			$this->characterID = $config['plugins']['motd']['characterID'];
			0 ignored issues – show Bug introduced 2017-01-12 19:55 UTC by Report Bug Copy Issue Report The property `characterID` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
46			$this->channelname = $config['plugins']['motd']['channelname'];
			0 ignored issues – show Bug introduced 2017-01-12 19:55 UTC by Report Bug Copy Issue Report The property `channelname` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
47			}
48			public function onMessage($msgData, $message) {
49			$channelID = (int) $msgData['message']['channelID'];
50			if (in_array($channelID, $this->excludeChannel, true)) {
51			return null;
52			}
53			$this->message = $message;
54			$user = $msgData['message']['from'];
			0 ignored issues – show Unused Code introduced 2017-01-12 19:55 UTC by Report Bug Copy Issue Report `$user` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
55			$message = $msgData['message']['message'];
56			$data = command($message, $this->information() ['trigger'], $this->config['bot']['trigger']);
57			if (isset($data['trigger'])) {
58			$keyID = $this->keyID;
59			$vCode = $this->vCode;
60			$characterID = $this->characterID;
61			$channelname = $this->channelname;
62
63			$urlChar = "https://api.eveonline.com/char/ChatChannels.xml.aspx?keyID=$keyID&vCode=$vCode&characterID=$characterID";
64			$data = file_get_contents($urlChar);
65			$list = new SimpleXMLElement($data);
66
67
68			foreach ($list->result->rowset->row as $row) {
69			$channeln = $row["displayName"];
70
71			if ($channeln == $channelname) {
72			//scrub the motd, then break it into 1900 chars or less. Limit is 2000 and want to leave room for the name of the person being replied too
73			$comment = $row["motd"];
74			$comment = str_replace("<BR>", "\n", $comment);
75			$comment = str_replace("<br>", "\n", $comment);
76			$comment = str_replace("<u>", "__", $comment);
77			$comment = str_replace("</u>", "__", $comment);
78			$comment = str_replace("<b>", "**", $comment);
79			$comment = str_replace("</b>", "**", $comment);
80			$comment = str_replace("<i>", "*", $comment);
81			$comment = str_replace("</i>", "*", $comment);
82			$comment = str_replace("&", "&", $comment);
83			$comment = strip_tags($comment);
84			$comment2 = str_split($comment, 1900);
85
86			$this->message->reply("\n $comment2[0]");
87			if (!empty($comment2[1])) {
88			$this->message->reply("\n $comment2[1]");
89			}
90			if (!empty($comment2[2])) {
91			$this->message->reply("\n $comment2[2]");
92			}
93			if (!empty($comment2[3])) {
94			$this->message->reply("\n $comment2[3]");
95			}
96			}
97			}
98			}
99			}
100			public function information() {
101			return array('name' => 'motd', 'trigger' => $this->triggers, 'information' => 'Displays the MOTD, useful for seeing information displayed there when not in-game.');
102			}
103			}
104			?>
			0 ignored issues – show Best Practice introduced 2017-01-12 19:55 UTC by Report Bug Copy Issue Report It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
105

shibdib / Dramiel

Branch — dev (952e73)

motd::onMessage() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like