shibdib /
Dramiel
| Conditions | 36 |
| Paths | 735 |
| Total Lines | 135 |
| Lines | 15 |
| Ratio | 11.11 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 81 | private function getKM() |
||
| 82 | { |
||
| 83 | $i = 0; |
||
| 84 | while ($i < 25) { |
||
| 85 | $kill = zKillRedis(); |
||
| 86 | $i++; |
||
| 87 | |||
| 88 | //Check if mail is null |
||
| 89 | if (!$kill || !array_key_exists('killID', $kill)) { |
||
| 90 | break; |
||
| 91 | } |
||
| 92 | |||
| 93 | //Check if mail is a big kill |
||
| 94 | if (@$kill['zkb']['totalValue'] >= 10000000000 && @$this->config['plugins']['getKillmails']['bigKills']['shareBigKills'] === 'true') { |
||
| 95 | $killID = getPermCache('bigKillNewestKillmailID'); |
||
| 96 | if ($this->config['plugins']['getKillmails']['bigKills']['bigKillStartID'] > $killID || null === $killID) { |
||
| 97 | $killID = $this->config['plugins']['getKillmails']['bigKills']['bigKillStartID']; |
||
| 98 | } |
||
| 99 | $channelID = $this->config['plugins']['getKillmails']['bigKills']['bigKillChannel']; |
||
| 100 | $killID = $kill['killmail']['killID']; |
||
| 101 | $systemName = $kill['killmail']['solarSystem']['name']; |
||
| 102 | $killTime = $kill['killmail']['killTime']; |
||
| 103 | $victimAllianceName = @$kill['killmail']['victim']['alliance']['name']; |
||
| 104 | $victimName = @$kill['killmail']['victim']['character']['name']; |
||
| 105 | $victimCorpName = @$kill['killmail']['victim']['corporation']['name']; |
||
| 106 | $shipName = $kill['killmail']['victim']['shipType']['name']; |
||
| 107 | $totalValue = number_format($kill['zkb']['totalValue']); |
||
| 108 | // Check if it's a structure |
||
| 109 | View Code Duplication | if ($victimName !== '') { |
|
| 110 | $msg = "**10b+ Kill Reported**\n\n**{$killTime}**\n\n**{$shipName}** worth **{$totalValue} ISK** flown by **{$victimName}** of (***{$victimCorpName}|{$victimAllianceName}***) killed in {$systemName}\nhttps://zkillboard.com/kill/{$killID}/"; |
||
| 111 | } else { |
||
| 112 | $msg = "**10b+ Kill Reported**\n\n**{$killTime}**\n\n**{$shipName}** worth **{$totalValue} ISK** owned by (***{$victimCorpName}|{$victimAllianceName}***) killed in {$systemName}\nhttps://zkillboard.com/kill/{$killID}/"; |
||
| 113 | } |
||
| 114 | if (null === $msg) { // Make sure it's always set. |
||
| 115 | return null; |
||
| 116 | } |
||
| 117 | queueMessage($msg, $channelID, $this->guild); |
||
| 118 | $newID = $killID++; |
||
| 119 | setPermCache('bigKillNewestKillmailID', $newID); |
||
| 120 | $this->logger->addInfo("Killmails: BIG KILLMAIL Mail {$killID} queued."); |
||
| 121 | continue; |
||
| 122 | } |
||
| 123 | |||
| 124 | foreach ($this->groupConfig as $kmGroup) { |
||
| 125 | $killID = getPermCache("{$kmGroup['name']}newestKillmailID"); |
||
| 126 | |||
| 127 | //check if start id is greater than current id and if it is set |
||
| 128 | if ($kmGroup['startMail'] > $killID || null === $killID) { |
||
| 129 | $killID = $kmGroup['startMail']; |
||
| 130 | } |
||
| 131 | |||
| 132 | //setup variables |
||
| 133 | $corpLoss = false; |
||
| 134 | $allianceLoss = false; |
||
| 135 | $corpKill = false; |
||
| 136 | $allianceKill = false; |
||
| 137 | $attackerCorpArray = array(); |
||
| 138 | $attackerAllianceArray = array(); |
||
| 139 | |||
| 140 | //Populate arrays with corp and alliance ids of attackers |
||
| 141 | foreach ($kill['killmail']['attackers'] as $attacker) { |
||
| 142 | $attackerCorpArray[] = (int) @$attacker['corporation']['id']; |
||
| 143 | $attackerAllianceArray[] = (int) @$attacker['alliance']['id']; |
||
| 144 | } |
||
| 145 | |||
| 146 | //check if it was corp or alliance kill or lossmail |
||
| 147 | if ((int) @$kill['killmail']['victim']['corporation']['id'] === $kmGroup['corpID'] && (int) $kmGroup['corpID'] !== 0) { |
||
| 148 | $corpLoss = true; |
||
| 149 | } elseif ((int) @$kill['killmail']['victim']['alliance']['id'] === $kmGroup['allianceID'] && (int) $kmGroup['allianceID'] !== 0) { |
||
| 150 | $allianceLoss = true; |
||
| 151 | } elseif (in_array((int) $kmGroup['corpID'], $attackerCorpArray) && (int) $kmGroup['corpID'] !== 0) { |
||
| 152 | $corpKill = true; |
||
| 153 | } elseif (in_array((int) $kmGroup['allianceID'], $attackerAllianceArray) && (int) $kmGroup['allianceID'] !== 0) { |
||
| 154 | $allianceKill = true; |
||
| 155 | } else { |
||
| 156 | //if it wasn't any of these continue in case there is another group to process |
||
| 157 | continue; |
||
| 158 | } |
||
| 159 | |||
| 160 | //Check if it's a lossmail and continue to next group if lossmails are turned off |
||
| 161 | if (($corpLoss === true || $allianceLoss === true) && $kmGroup['lossMails'] === 'false') { |
||
| 162 | continue; |
||
| 163 | } |
||
| 164 | |||
| 165 | //if big kill isn't set, disable it (unless someone explodes with a lot of plex..) |
||
| 166 | if (null === $kmGroup['bigKill']) { |
||
| 167 | $kmGroup['bigKill'] = 99999999999999999999999999; |
||
| 168 | } |
||
| 169 | |||
| 170 | //get the kill values |
||
| 171 | $killID = $kill['killmail']['killID']; |
||
| 172 | $channelID = $kmGroup['channel']; |
||
| 173 | $systemName = $kill['killmail']['solarSystem']['name']; |
||
| 174 | $killTime = $kill['killmail']['killTime']; |
||
| 175 | $victimAllianceName = @$kill['killmail']['victim']['alliance']['name']; |
||
| 176 | $victimName = @$kill['killmail']['victim']['character']['name']; |
||
| 177 | $victimCorpName = @$kill['killmail']['victim']['corporation']['name']; |
||
| 178 | $shipName = @$kill['killmail']['victim']['shipType']['name']; |
||
| 179 | $rawValue = $kill['zkb']['totalValue']; |
||
| 180 | //Check if killmail is older than 2 days |
||
| 181 | if ((time() - (60 * 60 * 48)) > DateTime::createFromFormat('Y.m.d H:i:s', $killTime)->getTimestamp()) { |
||
| 182 | continue; |
||
| 183 | } |
||
| 184 | //Check if killmail meets minimum value |
||
| 185 | if (isset($kmGroup['minimumValue'])) { |
||
| 186 | if ($rawValue < $kmGroup['minimumValue']) { |
||
| 187 | $this->logger->addInfo("Killmails: Mail {$killID} ignored for not meeting the minimum value required."); |
||
| 188 | setPermCache("{$kmGroup['name']}newestKillmailID", $killID); |
||
| 189 | continue; |
||
| 190 | } |
||
| 191 | } |
||
| 192 | $totalValue = number_format($kill['zkb']['totalValue']); |
||
| 193 | // Check if it's a structure |
||
| 194 | View Code Duplication | if ($victimName !== '') { |
|
| 195 | if ($kmGroup['bigKill'] != null && $rawValue >= $kmGroup['bigKill']) { |
||
| 196 | $channelID = $kmGroup['bigKillChannel']; |
||
| 197 | $msg = "@here \n :warning:***Expensive Killmail***:warning: \n **{$killTime}**\n\n**{$shipName}** worth **{$totalValue} ISK** flown by **{$victimName}** of (***{$victimCorpName}|{$victimAllianceName}***) killed in {$systemName}\nhttps://zkillboard.com/kill/{$killID}/"; |
||
| 198 | } elseif ($kmGroup['bigKill'] == null || $rawValue <= $kmGroup['bigKill']) { |
||
| 199 | $msg = "**{$killTime}**\n\n**{$shipName}** worth **{$totalValue} ISK** flown by **{$victimName}** of (***{$victimCorpName}|{$victimAllianceName}***) killed in {$systemName}\nhttps://zkillboard.com/kill/{$killID}/"; |
||
| 200 | } |
||
| 201 | } elseif ($victimName === '') { |
||
| 202 | $msg = "**{$killTime}**\n\n**{$shipName}** worth **{$totalValue} ISK** owned by (***{$victimCorpName}|{$victimAllianceName}***) killed in {$systemName}\nhttps://zkillboard.com/kill/{$killID}/"; |
||
| 203 | } |
||
| 204 | |||
| 205 | if (null === $msg) { // Make sure it's always set. |
||
| 206 | return null; |
||
| 207 | } |
||
| 208 | queueMessage($msg, $channelID, $this->guild); |
||
| 209 | $this->logger->addInfo("Killmails: Mail {$killID} queued."); |
||
| 210 | setPermCache("{$kmGroup['name']}newestKillmailID", $killID); |
||
| 211 | //don't process the same kill twice |
||
| 212 | break; |
||
| 213 | } |
||
| 214 | } |
||
| 215 | } |
||
| 216 | } |
||
| 217 |
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.