+global\charInfo::onMessage()

Complexity

Conditions	13
Paths	24

Size

Total Lines	90
Code Lines	56

Duplication

Lines	4
Ratio	4.44 %

Importance

Changes

0

<?php
    function onMessage($msgData, $message)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $channelID = (int)$msgData["message"]["channelID"];

        if (in_array($channelID, $this->excludeChannel, true))
        {
            return null;
        }

        $this->message = $message;

        $message = $msgData["message"]["message"];
        $user = $msgData["message"]["from"];

        $data = command($message, $this->information()["trigger"], $this->config["bot"]["trigger"]);
        if (isset($data["trigger"])) {

            // Most EVE players on Discord use their ingame name, so lets support @highlights
            $messageString = stristr($data["messageString"], "@") ? str_replace("<@", "", str_replace(">", "", $data["messageString"])) : $data["messageString"];
            if (is_numeric($messageString)) {
                // The person used @highlighting, so now we got a discord id, lets map that to a name
                $messageString = dbQueryField("SELECT name FROM usersSeen WHERE id = :id", "name", array(":id" => $messageString));
            }

            $cleanString = urlencode($messageString);

            //API call 1
            $url = "https://api.eveonline.com/eve/CharacterID.xml.aspx?names={$cleanString}";
            $xml = makeApiRequest($url);
            $characterID = null;

            if (isset($xml->result->rowset->row)) {

This code seems to be duplicated across your project.

                foreach ($xml->result->rowset->row as $character) {
                    $characterID = $character->attributes()->characterID;
                }
            }
            if (empty($characterID)) {
                return $this->message->reply("**Error:** no data available");
            }
            $characterID = urlencode($characterID);

            //API call 2
            $url = "https://api.eveonline.com/eve/CharacterInfo.xml.aspx?characterID={$characterID}";
            $xml = makeApiRequest($url);
            foreach ($xml->result as $characterDetails) {
                $dob = $characterDetails->DoB;

$dob is not used, you could remove the assignment.

                $corporationName = $characterDetails->corporation;
                $corporationJoinDate = $characterDetails->corporationDate;
                $allianceName = $characterDetails->alliance;
                $securityStatus = $characterDetails->securityStatus;
                $characterName = $characterDetails->characterName;
            }

            //ZKill lookup
            $url = "https://zkillboard.com/api/orderDirection/desc/limit/1/no-items/characterID/{$characterID}/xml/";
            $xml = makeApiRequest($url);
            if (empty($xml)) {
                return $this->message->reply("**Error:** ZKill is down. Try again later.");
            }
            foreach ($xml->result->rowset->row as $kill) {
                $lastSeenSystemID = $kill->attributes()->solarSystemID;
                $lastSeenSystem = apiCharacterName($lastSeenSystemID);
                $lastSeenDate = $kill->attributes()->killTime;
            }
            foreach ($xml->result->rowset->row->rowset->row as $attacker) {
                if ($attacker->attributes()->characterID == $characterID){
                    $lastSeenShipID = $attacker->attributes()->shipTypeID;
                    $lastSeenShip = apiTypeName($lastSeenShipID);
                }
            }
            $url = "https://zkillboard.com/character/{$characterID}/";

            $msg = "```Name: {$characterName}      

The variable $characterName does not seem to be defined for all execution paths leading up to this point.

			
Corporation Name: {$corporationName}

The variable $corporationName does not seem to be defined for all execution paths leading up to this point.

Joined Corporation On: {$corporationJoinDate}

The variable $corporationJoinDate does not seem to be defined for all execution paths leading up to this point.

Alliance Name: {$allianceName}

The variable $allianceName does not seem to be defined for all execution paths leading up to this point.

Security Status: {$securityStatus}

The variable $securityStatus does not seem to be defined for all execution paths leading up to this point.

Last Seen In System: {$lastSeenSystem}

The variable $lastSeenSystem does not seem to be defined for all execution paths leading up to this point.

Last Seen Flying a: {$lastSeenShip}

The variable $lastSeenShip does not seem to be defined for all execution paths leading up to this point.

Last Seen On: {$lastSeenDate}```

The variable $lastSeenDate does not seem to be defined for all execution paths leading up to this point.

For more info, visit: $url";

            $this->logger->addInfo("charInfo: Sending character info to {$user}");
            $this->message->reply($msg);
        }
        return null;
    }