authCheck::nameReset() - Code Metrics - Inspection of "Daily Inspection: speed up authing if corp has bee..." - shibdib/Dramiel - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (739b13)

unknown

created 2016-11-30 18:37 UTC

authCheck::nameReset() D

↳ Parent: authCheck

Complexity

Conditions	25
Paths	18

Size

Total Lines	110
Code Lines	78

Duplication

Lines	27
Ratio	24.55 %

Importance

Changes

Metric	Value
cc	25
eloc	78
nc	18
nop	0
dl	27
loc	110
rs	4.5682
c	0
b	0
f	0

How to fix Long Method Complexity

<?php
/**
 * The MIT License (MIT)
 *
 * Copyright (c) 2016 Robert Sardinia
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */


/**
 * Class fileAuthCheck
 * @property int nextCheck
 */
class authCheck
namespace YourVendor;

class YourClass { }
{
    /**
     * @var
     */
    var $config;
class A {
    var $property;
}
    /**
     * @var
     */
    var $db;
class A {
    var $property;
}
    var $dbUser;
class A {
    var $property;
}
    var $dbPass;
class A {
    var $property;
}
    var $dbName;
class A {
    var $property;
}
    var $guildID;
class A {
    var $property;
}
    var $corpTickers;
class A {
    var $property;
}
    var $authGroups;
class A {
    var $property;
}
    var $exempt;
class A {
    var $property;
}
    var $alertChannel;
class A {
    var $property;
}
    var $guild;
class A {
    var $property;
}
    var $nameEnforce;
class A {
    var $property;
}
    var $nameCheck;
class A {
    var $property;
}
    /**
     * @var
     */
    var $discord;
class A {
    var $property;
}
    /**
     * @var
     */
    var $channelConfig;
class A {
    var $property;
}
    /**
     * @var int
     */
    var $lastCheck = 0;
class A {
    var $property;
}
    /**
     * @var
     */
    var $logger;
class A {
    var $property;
}

    /**
     * @param $config
     * @param $discord
     * @param $logger
     */
    function init($config, $discord, $logger)

    {
        $this->config = $config;
        $this->discord = $discord;
        $this->logger = $logger;
        $this->db = $config["database"]["host"];
        $this->dbUser = $config["database"]["user"];
        $this->dbPass = $config["database"]["pass"];
        $this->dbName = $config["database"]["database"];
        $this->guildID = $config["bot"]["guild"];
        $this->exempt = $config["plugins"]["auth"]["exempt"];
        $this->corpTickers = $config["plugins"]["auth"]["corpTickers"];
        $this->nameEnforce = $config["plugins"]["auth"]["nameEnforce"];
        $this->authGroups = $config["plugins"]["auth"]["authGroups"];
        $this->alertChannel = $config["plugins"]["auth"]["alertChannel"];
        $this->guild = $config["bot"]["guild"];
        $this->nextCheck = 0;

        //Set name check to happen if corpTicker or nameEnforce is set
        if ($this->nameEnforce == "true" || $this->corpTickers == "true") {
            $this->nameCheck = "true";
        }

        //check if cache has been set
        $permsChecked = getPermCache("permsLastChecked");
        $namesChecked = getPermCache("nameStateLastChecked");
        if ($namesChecked == NULL) {
            setPermCache("nameStateLastChecked", time());
        }

        //if not set set for now (30 minutes from now for role removal)
        if ($permsChecked == NULL) {
            setPermCache("permsLastChecked", time() - 5);
            setPermCache("authStateLastChecked", time() + 7200);
        }
    }

    /**
     * @return array
     */
    function information()

    {
        return array(
            "name" => "",
            "trigger" => array(),
            "information" => ""
        );
    }

    function tick()

    {
        // What was the servers last reported state
        $lastStatus = getPermCache("serverState");
        if ($lastStatus == "online") {
            $permsChecked = getPermCache("permsLastChecked");
            $stateChecked = getPermCache("authStateLastChecked");
            $namesChecked = getPermCache("nameStateLastChecked");

            if ($permsChecked <= time()) {
                $this->logger->addInfo("AuthCheck: Checking for users who have left corp/alliance....");
                $this->checkPermissions();
                $this->logger->addInfo("AuthCheck: Corp/alliance check complete.");
            }

            if ($stateChecked <= time()) {
                $this->logger->addInfo("AuthCheck: Checking for users who have been wrongly given roles....");
                $this->checkAuthState();
                $this->logger->addInfo("AuthCheck: Role check complete.");
            }

            if ($this->nameCheck == "true" && $namesChecked <= time()) {
                $this->logger->addInfo("AuthCheck: Resetting player names....");
                $this->nameReset();
                $this->logger->addInfo("AuthCheck: Names reset.");
            }
        }
    }

    /**
     * @return null
     */

    //Remove members who have roles but never authed
    function checkPermissions()

    {
        //Get guild object
        $guild = $this->discord->guilds->get('id', $this->guildID);

        //Establish connection to mysql
        $conn = new mysqli($this->db, $this->dbUser, $this->dbPass, $this->dbName);

        $sql = "SELECT characterID, discordID, eveName FROM authUsers WHERE active='yes'";

        $result = $conn->query($sql);

        //Set empty arrays
        $corpArray = array();
        $allianceArray = array();

        // If config is outdated
        if (is_null($this->authGroups)) {

            $msg = "**Auth Failure:** Please update the bots config to the latest version.";
            queueMessage($msg, $this->alertChannel, $this->guild);
            $nextCheck = time() + 10800;
            setPermCache("permsLastChecked", $nextCheck);
            return null;
        }

        //Set corp/ally id arrays
        foreach ($this->authGroups as $authGroup) {
            if ($authGroup["corpID"] != 0) {
                array_push($corpArray, (int) $authGroup["corpID"]);
            }
            if ($authGroup["allianceID"] != 0) {
                array_push($allianceArray, (int) $authGroup["allianceID"]);
            }
        }

        if ($result->num_rows >= 1) {
            while ($rows = $result->fetch_assoc()) {
                $charID = $rows['characterID'];
                $discordID = $rows['discordID'];
                $member = $guild->members->get("id", $discordID);
                $eveName = $rows['eveName'];
                //Check if member has roles
                if (is_null($member->roles)) {
                    continue;
                }

                //Get ingame affiliations
                $url = "https://api.eveonline.com/eve/CharacterAffiliation.xml.aspx?ids=$charID";
                $xml = makeApiRequest($url);
                // Stop the process if the api is throwing an error
                if (is_null($xml)) {
                    $this->logger->addInfo("{$eveName} cannot be authed, API issues detected.");
                    return null;
                }

                //Auth things
                if ($xml->result->rowset->row[0]) {
                    foreach ($xml->result->rowset->row as $character) {
                        if (!in_array((int) $character->attributes()->allianceID, $allianceArray) && !in_array((int) $character->attributes()->corporationID, $corpArray)) {
                            // Deactivate user in database
                            $sql = "UPDATE authUsers SET active='no' WHERE discordID='$discordID'";
                            $this->logger->addInfo("AuthCheck: {$eveName} account has been deactivated as they are no longer in a correct corp/alliance.");
                            $conn->query($sql);
                            continue;
                        }
                    }
                }
            }
            $nextCheck = time() + 10800;
            setPermCache("permsLastChecked", $nextCheck);
            return null;
        }
        $nextCheck = time() + 10800;
        setPermCache("permsLastChecked", $nextCheck);
        return null;
    }

    //Check user corp/alliance affiliation


    function checkAuthState()

    {

        //Check if exempt roles are set
        if (is_null($this->exempt)) {
            $this->exempt = "0";
        }

        // If config is outdated
        if (is_null($this->authGroups)) {

            $msg = "**Auth Failure:** Please update the bots config to the latest version.";
            queueMessage($msg, $this->alertChannel, $this->guild);
            //queue up next check
            $nextCheck = time() + 1800;
            setPermCache("authStateLastChecked", $nextCheck);
            return null;
        }

        //Establish connection to mysql
        $conn = new mysqli($this->db, $this->dbUser, $this->dbPass, $this->dbName);

        //get bot ID so we don't remove out own roles
        $botID = $this->discord->id;

        //Get guild object
        $guild = $this->discord->guilds->get('id', $this->guildID);

        //Check to make sure guildID is set correctly
        if (is_null($guild)) {
            $this->logger->addError("Config Error: Ensure the guild entry in the config is the guildID (aka serverID) for the main server that the bot is in.");
            $nextCheck = time() + 7200;
            setPermCache("authLastChecked", $nextCheck);
            return null;
        }

        //create empty array to store names
        $removedRoles = array();
        $userCount = 0;

        //Perform check if roles were added without permission
        foreach ($guild->members as $member) {
            $id = $member->id;
            $username = $member->username;
            $roles = $member->roles;

            //Skip to next member if this user has no roles
            if (is_null($roles)) {
                continue;
            }
            $sql = "SELECT * FROM authUsers WHERE discordID='$id' AND active='yes'";
            $result = $conn->query($sql);

            //If they are NOT active in the db, check for roles to remove
            if ($result->num_rows == 0) {
                $userCount++;
                foreach ($roles as $role) {
                    if (!isset($role->name)) {
                        if ($id != $botID && !in_array($role->name, $this->exempt, true)) {
                            $member->removeRole($role);
                            $guild->members->save($member);
                            // Add users name to array
                            array_push($removedRoles, $username);
                        }
                    }
                }
            }
        }
        //Report removed users to log and channel
        $nameList = implode(", ", $removedRoles);
        if ($userCount > 0 && strlen($nameList) > 3 && !is_null($nameList)) {
            $msg = "Following users roles have been removed - {$nameList}";
            queueMessage($msg, $this->alertChannel, $this->guild);
            $this->logger->addInfo("AuthCheck: Roles removed from {$nameList}");
        }
        //queue up next check
        $nextCheck = time() + 1800;
        setPermCache("authStateLastChecked", $nextCheck);
        return null;
    }

    function nameReset()

    {
        //Get guild object
        $guild = $this->discord->guilds->get('id', $this->guildID);

        //Establish connection to mysql
        $conn = new mysqli($this->db, $this->dbUser, $this->dbPass, $this->dbName);
        $sql = "SELECT characterID, discordID, eveName FROM authUsers WHERE active='yes'";
        $result = $conn->query($sql);

        // If config is outdated
        if (is_null($this->authGroups)) {

            $msg = "**Auth Failure:** Please update the bots config to the latest version.";
            queueMessage($msg, $this->alertChannel, $this->guild);
            $nextCheck = time() + 10800;
            setPermCache("permsLastChecked", $nextCheck);
            return null;
        }

        if ($result->num_rows >= 1) {
            while ($rows = $result->fetch_assoc()) {
                $charID = $rows['characterID'];
                $discordID = $rows['discordID'];
                $member = $guild->members->get("id", $discordID);
                $eveName = $rows['eveName'];
                //Check if member has roles
                if (is_null($member->roles)) {
                    continue;
                }

                //Get current nickname
                $guild = $this->discord->guilds->get('id', $this->guildID);
                $member = $guild->members->get("id", $discordID);
                $nickName = $member->nick;
                $userName = $member->user->username;
                //If nick isn't set than make it username
                if ($nickName == "" || is_null($nickName)) {
                    $nickName = $userName;
                }

                //Get ingame affiliations
                if ($this->corpTickers == "true") {
                    $url = "https://api.eveonline.com/eve/CharacterAffiliation.xml.aspx?ids=$charID";
                    $xml = makeApiRequest($url);
                    // Stop the process if the api is throwing an error
                    if (is_null($xml)) {
                        $this->logger->addInfo("{$eveName} cannot be authed, API issues detected.");
                        return null;
                    }
                    if ($xml->result->rowset->row[0]) {
                        foreach ($xml->result->rowset->row as $character) {
                            $corpInfo = getCorpInfo($character->attributes()->corporationID);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
                            if (!is_null($corpInfo)) {
                                $corpTicker = $corpInfo['corpTicker'];
                                if ($this->nameEnforce == "true") {

                                    $nick = "[{$corpTicker}] {$eveName}";
                                } elseif ($nickName == "[{$corpTicker}]") {
                                    $nick = "[{$corpTicker}] {$userName}";
                                } elseif (strpos($nickName, $corpTicker) == false) {

                                    $nick = "[{$corpTicker}] {$nickName}";
                                } elseif (strpos($nickName, $corpTicker) !== false) {
                                    $nick = "{$nickName}";
                                    continue;
                                }
                                if ($nick != $nickName) {
                                    queueRename($discordID, $nick, $this->guildID);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                                }
                                continue;
                            }
                            $url = "https://api.eveonline.com/corp/CorporationSheet.xml.aspx?corporationID={$character->attributes()->corporationID}";
                            $xml = makeApiRequest($url);
                            $corpTicker = "";
                            $corpName = "";
                            foreach ($xml->result as $corporation) {
                                $corpTicker = $corporation->ticker;
                                $corpName = $corporation->corporationName;
                            }
                            if ($this->nameEnforce == "true") {

                                $nick = "[{$corpTicker}] {$eveName}";
                            } elseif ($nickName == "[{$corpTicker}]") {
                                $nick = "[{$corpTicker}] {$userName}";
                            } elseif (strpos($nickName, $corpTicker) == false) {

                                $nick = "[{$corpTicker}] {$nickName}";
                            } elseif (strpos($nickName, $corpTicker) !== false) {
                                $nick = "{$nickName}";
                                continue;
                            }
                            if ($nick != $nickName) {
                                queueRename($discordID, $nick, $this->guildID);
                            }
                            addCorpInfo($character->attributes()->corporationID, $corpTicker, $corpName);
                            continue;
                        }
                    }
                }
                $nick = "{$eveName}";
                if ($nick != $nickName && $this->corpTickers != "true") {
                    queueRename($discordID, $nick, $this->guildID);
                }
                continue;
            }
            $nextCheck = time() + 43200;
            setPermCache("nameStateLastChecked", $nextCheck);
            return null;
        }
        $nextCheck = time() + 43200;
        setPermCache("nameStateLastChecked", $nextCheck);
        return null;

    }
}


1			<?php
2			/**
3			* The MIT License (MIT)
4			*
5			* Copyright (c) 2016 Robert Sardinia
6			*
7			* Permission is hereby granted, free of charge, to any person obtaining a copy
8			* of this software and associated documentation files (the "Software"), to deal
9			* in the Software without restriction, including without limitation the rights
10			* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
11			* copies of the Software, and to permit persons to whom the Software is
12			* furnished to do so, subject to the following conditions:
13			*
14			* The above copyright notice and this permission notice shall be included in all
15			* copies or substantial portions of the Software.
16			*
17			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
18			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
19			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
20			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
21			* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
22			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
23			* SOFTWARE.
24			*/
25
26
27			/**
28			* Class fileAuthCheck
29			* @property int nextCheck
30			*/
31			class authCheck
			0 ignored issues – show Coding Style Compatibility introduced 2016-07-16 19:16 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
32			{
33			/**
34			* @var
35			*/
36			var $config;
			0 ignored issues – show Coding Style introduced 2016-07-16 19:16 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$config`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
37			/**
38			* @var

shibdib / Dramiel

Branch — master (739b13)

authCheck::nameReset() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Duplication Side-by-Side

Filter issues like