siphons

Complexity

Total Complexity

20

Size/Duplication

Total Lines	160
Duplicated Lines	40.63 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	onMessage()	0	3	1
A	init()	0	16	2
A	tick()	0	11	2
C	checkTowers()	65	81	14
A	information()	0	8	1

<?php
/**
 * The MIT License (MIT)
 *
 * Copyright (c) 2016 Robert Sardinia
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

use discord\discord;

/**
 * Class siphons
 */
class siphons {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

    /**
     * @var
     */
    var $config;

The visibility should be declared for property $config.

    /**
     * @var
     */
    var $discord;

The visibility should be declared for property $discord.

    /**
     * @var
     */
    var $logger;

The visibility should be declared for property $logger.

    /**
     * @var
     */
    var $toDiscordChannel;

The visibility should be declared for property $toDiscordChannel.

    public $guild;
    protected $keyID;
    protected $vCode;
    protected $prefix;

    /**
     * @param $config
     * @param $discord
     * @param $logger
     */
    function init($config, $discord, $logger)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->config = $config;
        $this->discord = $discord;
        $this->logger = $logger;
        $this->guild = $config["bot"]["guild"];
        $this->toDiscordChannel = $config["plugins"]["siphons"]["channelID"];
        $this->keyID = $config["plugins"]["siphons"]["keyID"];
        $this->vCode = $config["plugins"]["siphons"]["vCode"];
        $this->prefix = $config["plugins"]["siphons"]["prefix"];
        $lastCheck = getPermCache("siphonLastChecked{$this->keyID}");
        if ($lastCheck == NULL) {
            // Schedule it for right now if first run
            setPermCache("siphonLastChecked{$this->keyID}", time() - 5);
        }
    }

    /**
     *
     */
    function tick()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $lastChecked = getPermCache("siphonLastChecked{$this->keyID}");
        $keyID = $this->keyID;
        $vCode = $this->vCode;

        if ($lastChecked <= time()) {
            $this->logger->addInfo("Checking API Key {$keyID} for siphons");
            $this->checkTowers($keyID, $vCode);
        }
    }

    function checkTowers($keyID, $vCode)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $discord = $this->discord;

        $url = "https://api.eveonline.com/corp/AssetList.xml.aspx?keyID={$keyID}&vCode={$vCode}";
        $xml = makeApiRequest($url);
        $siphonCount = 0;
        foreach ($xml->result->rowset->row as $structures) {
            //Check silos
            if ($structures->attributes()->typeID == 14343) {

This code seems to be duplicated across your project.

                if (isset($structures->rowset->row)) {
                    foreach ($structures->rowset->row as $silo) {
                        //Avoid reporting empty silos
                        if ($silo->attributes()->quantity != 0) {
                            //Check for a multiple of 50
                            if ($silo->attributes()->quantity % 50 != 0) {
                                $gooType = apiTypeName($silo->attributes()->typeID);
                                $systemName = apiCharacterName($structures->attributes()->locationID);
                                $msg = "{$this->prefix}";
                                $msg .= "**POSSIBLE SIPHON**\n";
                                $msg .= "**System: **{$systemName} has a possible siphon stealing {$gooType} from a silo.\n";
                                // Send the msg to the channel;
                                $channelID = $this->toDiscordChannel;
                                $guild = $discord->guilds->get('id', $this->guild);
                                $channel = $guild->channels->get('id', $channelID);
                                $channel->sendMessage($msg, false);
                                $this->logger->addInfo($msg);
                                $siphonCount++;
                                sleep(2); // Lets sleep for a second, so we don't rage spam
                            }
                        }
                    }
                }
            }
            if ($structures->attributes()->typeID == 17982) {

This code seems to be duplicated across your project.

                if (isset($structures->rowset->row)) {
                    foreach ($structures->rowset->row as $coupling) {
                        //Avoid reporting empty coupling arrays
                        if ($coupling->attributes()->quantity != 0) {
                            //Check for a multiple of 50
                            if ($coupling->attributes()->quantity % 50 != 0) {
                                $gooType = apiTypeName($silo->attributes()->typeID);

The variable $silo seems to be defined by a foreach iteration on line 101. Are you sure the iterator is never empty, otherwise this variable is not defined?

                                $systemName = apiCharacterName($structures->attributes()->locationID);
                                $msg = "{$this->prefix}";
                                $msg .= "**POSSIBLE SIPHON**\n";
                                $msg .= "**System: **{$systemName} has a possible siphon stealing {$gooType} from a coupling array.\n";
                                // Send the msg to the channel;
                                $channelID = $this->toDiscordChannel;
                                $guild = $discord->guilds->get('id', $this->guild);
                                $channel = $guild->channels->get('id', $channelID);
                                $channel->sendMessage($msg, false);
                                $this->logger->addInfo($msg);
                                $siphonCount++;
                                sleep(2); // Lets sleep for a second, so we don't rage spam
                            }
                        }
                    }
                }
            }
        }
        $cached = $xml->cachedUntil[0];
        $baseUnix = strtotime($cached);
        $cacheClr = $baseUnix - 13500;
        if ($cacheClr <= time()) {

This code seems to be duplicated across your project.

            $weirdTime = time() + 21700;
            $cacheTimer = gmdate("Y-m-d H:i:s", $weirdTime);
            setPermCache("siphonLastChecked{$keyID}", $weirdTime);
        } else {
            $cacheTimer = gmdate("Y-m-d H:i:s", $cacheClr);
            setPermCache("siphonLastChecked{$keyID}", $cacheClr);
        }
        if ($siphonCount > 0) {

This code seems to be duplicated across your project.

            $msg = "Next Siphon Check At: {$cacheTimer} EVE Time";
            $channelID = $this->toDiscordChannel;
            $guild = $discord->guilds->get('id', $this->guild);
            $channel = $guild->channels->get('id', $channelID);
            $channel->sendMessage($msg, false);
        }
        $this->logger->addInfo("Siphon Check Complete Next Check At {$cacheTimer}");
        return null;
    }

    /**
     *
     */
    function onMessage()

It is generally recommended to explicitly declare the visibility for methods.

    {
    }

    /**
     * @return array
     */
    function information()

It is generally recommended to explicitly declare the visibility for methods.

    {
        return array(
            "name" => "",
            "trigger" => array(""),
            "information" => ""
        );
    }
}