getKillmails - Code Metrics - Inspection of "Daily Inspection: 55" - shibdib/Dramiel - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (d9babe)

unknown

created 2016-12-06 18:41 UTC

getKillmails B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	223
Duplicated Lines	5.38 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
dl	12
loc	223
rs	8.8
c	0
b	0
f	0
wmc	36
lcom	1
cbo	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	information()	0	8	1
A	init()	0	10	1
B	tick()	0	23	5
F	getKM()	12	87	20
C	getBigKM()	0	50	9

How to fix Duplicated Code

<?php
/**
 * The MIT License (MIT)
 *
 * Copyright (c) 2016 Robert Sardinia
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

use discord\discord;

/**
 * Class getKillmails
 */
class getKillmails
namespace YourVendor;

class YourClass { }
{
    /**
     * @var
     */
    var $config;
class A {
    var $property;
}
    /**
     * @var
     */
    var $db;
class A {
    var $property;
}
    /**
     * @var
     */
    var $discord;
class A {
    var $property;
}
    /**
     * @var
     */
    var $channelConfig;
class A {
    var $property;
}
    /**
     * @var int
     */
    var $lastCheck = 0;
class A {
    var $property;
}
    /**
     * @var
     */
    var $logger;
class A {
    var $property;
}
    public $groupConfig;

    /**
     * @param $config
     * @param $discord
     * @param $logger
     */
    function init($config, $discord, $logger)

    {
        $this->config = $config;
        $this->discord = $discord;
        $this->logger = $logger;
        $this->groupConfig = $config["plugins"]["getKillmails"]["groupConfig"];
        $this->guild = $config["bot"]["guild"];
class MyClass { }

$x = new MyClass();
$x->foo = true;
        //Refresh check at bot start
        setPermCache("killmailCheck", time() - 5);
    }


    /**
     * @return array
     */
    function information()

    {
        return array(
            "name" => "",
            "trigger" => array(),
            "information" => ""
        );
    }

    /**
     *
     */
    function tick()

    {
        // What was the servers last reported state
        $lastStatus = getPermCache("serverState");
        if ($lastStatus == "online") {
            $lastChecked = getPermCache("killmailCheck");
            if ($lastChecked <= time()) {
                //check if user is still using the old config
                if (is_null($this->groupConfig)) {
                    $this->logger->addError("Killmails: UPDATE YOUR CONFIG TO RECEIVE KILLMAILS");
                    setPermCache("killmailCheck", time() + 600);
                    return null;
                }
                $this->logger->addInfo("Killmails: Checking for new killmails.");
                $this->getKM();
                setPermCache("killmailCheck", time() + 600);
                if ($this->config["plugins"]["getKillmails"]["bigKills"]["shareBigKills"] == "true") {
                    $this->logger->addInfo("Killmails: Checking for 10b+ kills.");
                    $this->getBigKM();
                }
            }
        }
    }

    function getKM()

    {
        foreach ($this->groupConfig as $kmGroup) {
            $killID = getPermCache("{$kmGroup["name"]}newestKillmailID");
            //check if start id is greater than current id and if it is set
            if ($kmGroup["startMail"] > $killID || is_null($killID)) {
                $killID = $kmGroup["startMail"];
            }
            if ($kmGroup["allianceID"] == "0" & $kmGroup["lossMails"] == 'true') {
// Returns always int(0).
return 0 === $foo & 4;
return (0 === $foo) & 4;

// More likely intended return: true/false
return 0 === ($foo & 4);
                $url = "https://zkillboard.com/api/no-attackers/no-items/orderDirection/asc/afterKillID/{$killID}/corporationID/{$kmGroup["corpID"]}/";
            }
            if ($kmGroup["allianceID"] == "0" & $kmGroup["lossMails"] == 'false') {
// Returns always int(0).
return 0 === $foo & 4;
return (0 === $foo) & 4;

// More likely intended return: true/false
return 0 === ($foo & 4);
                $url = "https://zkillboard.com/api/no-attackers/no-items/kills/orderDirection/asc/afterKillID/{$killID}/corporationID/{$kmGroup["corpID"]}/";
            }
            if ($kmGroup["allianceID"] != "0" & $kmGroup["lossMails"] == 'true') {
// Returns always int(0).
return 0 === $foo & 4;
return (0 === $foo) & 4;

// More likely intended return: true/false
return 0 === ($foo & 4);
                $url = "https://zkillboard.com/api/no-attackers/no-items/orderDirection/asc/afterKillID/{$killID}/allianceID/{$kmGroup["allianceID"]}/";
            }
            if ($kmGroup["allianceID"] != "0" & $kmGroup["lossMails"] == 'false') {
// Returns always int(0).
return 0 === $foo & 4;
return (0 === $foo) & 4;

// More likely intended return: true/false
return 0 === ($foo & 4);
                $url = "https://zkillboard.com/api/no-attackers/no-items/kills/orderDirection/asc/afterKillID/{$killID}/allianceID/{$kmGroup["allianceID"]}/";
            }

            if (!isset($url)) { // Make sure it's always set.
                $this->logger->addInfo("Killmails: ERROR - Ensure your config file is setup correctly for killmails.");
                return null;
            }

            $kills = json_decode(downloadData($url), true);
            $i = 0;
            if (isset($kills)) {
                foreach ($kills as $kill) {
                    if ($i < 10) {
                        //if big kill isn't set, disable it
                        if (is_null($kmGroup["bigKill"])) {
                            $kmGroup["bigKill"] = 99999999999999999999999999;
                        }
                        $killID = $kill['killID'];
                        $channelID = $kmGroup["channel"];
                        $solarSystemID = $kill['solarSystemID'];
                        $systemName = apiCharacterName($solarSystemID);
                        $killTime = $kill['killTime'];
                        $victimAllianceName = $kill['victim']['allianceName'];
                        $victimName = $kill['victim']['characterName'];
                        $victimCorpName = $kill['victim']['corporationName'];
                        $victimShipID = $kill['victim']['shipTypeID'];
                        $shipName = apiTypeName($victimShipID);
                        $rawValue = $kill['zkb']['totalValue'];
                        //Check if killmail meets minimum value
                        if (isset($kmGroup["minimumValue"])) {
                            if ($rawValue < $kmGroup["minimumValue"]) {
                                $this->logger->addInfo("Killmails: Mail {$killID} ignored for not meeting the minimum value required.");
                                setPermCache("{$kmGroup["name"]}newestKillmailID", $killID);
                                continue;
                            }
                        }
                        $totalValue = number_format($kill['zkb']['totalValue']);
                        // Check if it's a structure
                        if ($victimName != "") {
                            if ($rawValue >= $kmGroup["bigKill"]) {
                                $channelID = $kmGroup["bigKillChannel"];
                                $msg = "@here \n :warning:***Expensive Killmail***:warning: \n **{$killTime}**\n\n**{$shipName}** worth **{$totalValue} ISK** flown by **{$victimName}** of (***{$victimCorpName}|{$victimAllianceName}***) killed in {$systemName}\nhttps://zkillboard.com/kill/{$killID}/";
                            } elseif ($rawValue <= $kmGroup["bigKill"]) {
                                $msg = "**{$killTime}**\n\n**{$shipName}** worth **{$totalValue} ISK** flown by **{$victimName}** of (***{$victimCorpName}|{$victimAllianceName}***) killed in {$systemName}\nhttps://zkillboard.com/kill/{$killID}/";
                            }
                        } elseif ($victimName == "") {
                            $msg = "**{$killTime}**\n\n**{$shipName}** worth **{$totalValue} ISK** owned by (***{$victimCorpName}|{$victimAllianceName}***) killed in {$systemName}\nhttps://zkillboard.com/kill/{$killID}/";
                        }

                        if (!isset($msg)) { // Make sure it's always set.
                            return null;
                        }
                        queueMessage($msg, $channelID, $this->guild);
                        $this->logger->addInfo("Killmails: Mail {$killID} queued.");

                        $i++;
                    } else {
                        $updatedID = getPermCache("{$kmGroup["name"]}newestKillmailID");
                        $this->logger->addInfo("Killmails: Kill posting cap reached, newest kill id for {$kmGroup["name"]} is {$updatedID}");
                        break;
                    }
                }
                setPermCache("{$kmGroup["name"]}newestKillmailID", $killID);
            }
            $updatedID = getPermCache("{$kmGroup["name"]}newestKillmailID");
            $this->logger->addInfo("Killmails: All kills posted, newest kill id for {$kmGroup["name"]} is {$updatedID}");
            continue;
        }
    }

    function getBigKM()

    {
        $killID = getPermCache("bigKillNewestKillmailID");
        if ($this->config["plugins"]["getKillmails"]["bigKills"]["bigKillStartID"] > $killID || is_null($killID)) {
            $killID = $this->config["plugins"]["getKillmails"]["bigKills"]["bigKillStartID"];
        }

        $url = "https://zkillboard.com/api/kills/iskValue/10000000000/afterKillID/{$killID}/";

        $kills = json_decode(downloadData($url), true);
        $i = 0;
        if (isset($kills)) {
            foreach ($kills as $kill) {
                if ($i < 5) {
                    $newestID = getPermCache("bigKillNewestKillmailID");
                    $killID = $kill['killID'];
                    $channelID = $this->config["plugins"]["getKillmails"]["bigKills"]["bigKillChannel"];
                    $solarSystemID = $kill['solarSystemID'];
                    $systemName = apiCharacterName($solarSystemID);
                    $killTime = $kill['killTime'];
                    $victimAllianceName = $kill['victim']['allianceName'];
                    $victimName = $kill['victim']['characterName'];
                    $victimCorpName = $kill['victim']['corporationName'];
                    $victimShipID = $kill['victim']['shipTypeID'];
                    $shipName = apiTypeName($victimShipID);
                    $totalValue = number_format($kill['zkb']['totalValue']);
                    if ($killID > $newestID) {
                        // Check if it's a structure
                        if ($victimName != "") {
                            $msg = "**10b+ Kill Reported**\n\n**{$killTime}**\n\n**{$shipName}** worth **{$totalValue} ISK** flown by **{$victimName}** of (***{$victimCorpName}|{$victimAllianceName}***) killed in {$systemName}\nhttps://zkillboard.com/kill/{$killID}/";
                        } else {
                            $msg = "**10b+ Kill Reported**\n\n**{$killTime}**\n\n**{$shipName}** worth **{$totalValue} ISK** owned by (***{$victimCorpName}|{$victimAllianceName}***) killed in {$systemName}\nhttps://zkillboard.com/kill/{$killID}/";
                        }
                        if (!isset($msg)) { // Make sure it's always set.
                            return null;
                        }
                        queueMessage($msg, $channelID, $this->guild);
                        $this->logger->addInfo("Killmails: Mail {$killID} queued.");
                        setPermCache("bigKillNewestKillmailID", $newID);

                    }
                    $i++;
                } else {
                    $this->logger->addInfo("Killmails: bigKill posting cap reached, newest kill id is {$updatedID}");
function someFunction() {
    $x = 5;
    echo $x;
}
                    break;
                }
            }
        }
        $updatedID = getPermCache("bigKillNewestKillmailID");
        $this->logger->addInfo("Killmails: All bigKills posted, newest kill id is {$updatedID}");
    }
}


1			<?php
2			/**
3			* The MIT License (MIT)
4			*
5			* Copyright (c) 2016 Robert Sardinia
6			*
7			* Permission is hereby granted, free of charge, to any person obtaining a copy
8			* of this software and associated documentation files (the "Software"), to deal
9			* in the Software without restriction, including without limitation the rights
10			* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
11			* copies of the Software, and to permit persons to whom the Software is
12			* furnished to do so, subject to the following conditions:
13			*
14			* The above copyright notice and this permission notice shall be included in all
15			* copies or substantial portions of the Software.
16			*
17			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
18			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
19			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
20			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
21			* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
22			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
23			* SOFTWARE.
24			*/
25
26			use discord\discord;
27
28			/**
29			* Class getKillmails
30			*/
31			class getKillmails
			0 ignored issues – show Coding Style Compatibility introduced 2016-07-16 19:16 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
32			{
33			/**
34			* @var
35			*/
36			var $config;
			0 ignored issues – show Coding Style introduced 2016-07-16 19:16 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$config`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
37			/**
38			* @var

shibdib / Dramiel

Branch — master (d9babe)

getKillmails B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like