shibdib /
Dramiel
| Conditions | 18 |
| Paths | 769 |
| Total Lines | 82 |
| Code Lines | 58 |
| Lines | 12 |
| Ratio | 14.63 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 106 | function getKM() |
||
| 107 | { |
||
| 108 | foreach($this->groupConfig as $kmGroup) { |
||
| 109 | $lastMail = getPermCache("{$kmGroup["name"]}newestKillmailID"); |
||
| 110 | if (is_null($lastMail)){ |
||
| 111 | $lastMail = $kmGroup["startMail"]; |
||
| 112 | } |
||
| 113 | View Code Duplication | if ($kmGroup["allianceID"] == "0" & $kmGroup["lossMails"] == 'true') { |
|
| 114 | $url = "https://zkillboard.com/api/no-attackers/no-items/orderDirection/asc/afterKillID/{$lastMail}/corporationID/{$kmGroup["corpID"]}/"; |
||
| 115 | } |
||
| 116 | View Code Duplication | if ($kmGroup["allianceID"] == "0" & $kmGroup["lossMails"] == 'false') { |
|
| 117 | $url = "https://zkillboard.com/api/no-attackers/no-items/kills/orderDirection/asc/afterKillID/{$lastMail}/corporationID/{$kmGroup["corpID"]}/"; |
||
| 118 | } |
||
| 119 | View Code Duplication | if ($kmGroup["allianceID"] != "0" & $kmGroup["lossMails"] == 'true') { |
|
| 120 | $url = "https://zkillboard.com/api/no-attackers/no-items/orderDirection/asc/afterKillID/{$lastMail}/allianceID/{$kmGroup["allianceID"]}/"; |
||
| 121 | } |
||
| 122 | View Code Duplication | if ($kmGroup["allianceID"] != "0" & $kmGroup["lossMails"] == 'false') { |
|
| 123 | $url = "https://zkillboard.com/api/no-attackers/no-items/kills/orderDirection/asc/afterKillID/{$lastMail}/allianceID/{$kmGroup["allianceID"]}/"; |
||
| 124 | } |
||
| 125 | |||
| 126 | if (!isset($url)) { // Make sure it's always set. |
||
| 127 | $this->logger->addInfo("Killmails: ERROR - Ensure your config file is setup correctly for killmails."); |
||
| 128 | return null; |
||
| 129 | } |
||
| 130 | |||
| 131 | $xml = json_decode(downloadData($url), true); |
||
| 132 | $i = 0; |
||
| 133 | $limit = $kmGroup["spamAmount"]; |
||
| 134 | if (isset($xml)) { |
||
| 135 | foreach ($xml as $kill) { |
||
| 136 | if ($i < $limit) { |
||
| 137 | //if big kill isn't set, disable it |
||
| 138 | if (is_null($kmGroup["bigKill"])){ |
||
| 139 | $kmGroup["bigKill"] = 99999999999999999999999999; |
||
| 140 | } |
||
| 141 | $killID = $kill['killID']; |
||
| 142 | //check if start id is greater than current id |
||
| 143 | if ($kmGroup["startMail"] > $killID) { |
||
| 144 | $killID = $kmGroup["startMail"]; |
||
| 145 | } |
||
| 146 | $channelID = $kmGroup["channel"]; |
||
| 147 | $solarSystemID = $kill['solarSystemID']; |
||
| 148 | $systemName = apiCharacterName($solarSystemID); |
||
| 149 | $killTime = $kill['killTime']; |
||
| 150 | $victimAllianceName = $kill['victim']['allianceName']; |
||
| 151 | $victimName = $kill['victim']['characterName']; |
||
| 152 | $victimCorpName = $kill['victim']['corporationName']; |
||
| 153 | $victimShipID = $kill['victim']['shipTypeID']; |
||
| 154 | $shipName = apiTypeName($victimShipID); |
||
| 155 | $rawValue = $kill['zkb']['totalValue']; |
||
| 156 | $totalValue = number_format($kill['zkb']['totalValue']); |
||
| 157 | // Check if it's a structure |
||
| 158 | if ($victimName != "") { |
||
| 159 | if ($rawValue >= $kmGroup["bigKill"]) { |
||
| 160 | $channelID = $kmGroup["bigKillChannel"]; |
||
| 161 | $msg = "@here \n :warning:***Expensive Killmail***:warning: \n **{$killTime}**\n\n**{$shipName}** worth **{$totalValue} ISK** flown by **{$victimName}** of (***{$victimCorpName}|{$victimAllianceName}***) killed in {$systemName}\nhttps://zkillboard.com/kill/{$killID}/"; |
||
| 162 | } elseif ($rawValue <= $kmGroup["bigKill"]) { |
||
| 163 | $msg = "**{$killTime}**\n\n**{$shipName}** worth **{$totalValue} ISK** flown by **{$victimName}** of (***{$victimCorpName}|{$victimAllianceName}***) killed in {$systemName}\nhttps://zkillboard.com/kill/{$killID}/"; |
||
| 164 | } |
||
| 165 | } elseif ($victimName == "") { |
||
| 166 | $msg = "**{$killTime}**\n\n**{$shipName}** worth **{$totalValue} ISK** owned by (***{$victimCorpName}|{$victimAllianceName}***) killed in {$systemName}\nhttps://zkillboard.com/kill/{$killID}/"; |
||
| 167 | } |
||
| 168 | |||
| 169 | if (!isset($msg)) { // Make sure it's always set. |
||
| 170 | return null; |
||
| 171 | } |
||
| 172 | queueMessage($msg, $channelID, $this->guild); |
||
| 173 | setPermCache("{$kmGroup["name"]}newestKillmailID", $killID++); |
||
| 174 | |||
| 175 | $i++; |
||
| 176 | } else { |
||
| 177 | $updatedID = getPermCache("{$kmGroup["name"]}newestKillmailID"); |
||
| 178 | $this->logger->addInfo("Killmails: Kill posting cap reached, newest kill id for {$kmGroup["name"]} is {$updatedID}"); |
||
| 179 | break; |
||
| 180 | } |
||
| 181 | } |
||
| 182 | } |
||
| 183 | $updatedID = getPermCache("{$kmGroup["name"]}newestKillmailID"); |
||
| 184 | $this->logger->addInfo("Killmails: All kills posted, newest kill id for {$kmGroup["name"]} is {$updatedID}"); |
||
| 185 | continue; |
||
| 186 | } |
||
| 187 | } |
||
| 188 | } |
||
| 189 |
Loading history...
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.