shibdib / Dramiel

src/plugins/onTick/authCheck.php

Braces +23 added lines, -14 removed lines

@@ -177,8 +177,9 @@ 
             for ($i=0; $i<3; $i++) {
                 $character = characterDetails($charID);
                 //if (isset($character['corporation_id']) && in_array($character['corporation_id'], $corpArray))
-                if (!is_null($character))
-                    break;
+                if (!is_null($character)) {
+                                    break;
+                }
                 //Postpone check if ESI is down to prevent timeouts
                 if (isset($character['error']) && $character['error'] === 'The datasource tranquility is temporarily unavailable') {
                     $this->logger->addInfo('AuthCheck: The datasource tranquility is temporarily unavailable, check canceled.');
@@ -197,8 +198,9 @@ 
             // alliance membership check
             for ($i=0; $i<3; $i++) {
                 $corporationDetails = corpDetails($corporationID);
-                if (!is_null($corporationDetails))
-                    break;
+                if (!is_null($corporationDetails)) {
+                                    break;
+                }
             }
             if (is_null($corporationDetails) || isset($corporationDetails['error'])) {
                 $this->logger->addInfo('AuthCheck: corpDetails lookup failed.');
@@ -223,8 +225,10 @@ 
                     $standings = 1;
                 }
             }
-            if ($standings)
-                continue; //keep the user based on standings
+            if ($standings) {
+                            continue;
+            }
+            //keep the user based on standings
 
             // User failed all checks, deactivate user in database
             $sql = "UPDATE authUsers SET active='no' WHERE discordID='$discordID'";
@@ -294,8 +298,10 @@ 
 
             } while (!isset($character['corporation_id']));
             $corporationID = $character['corporation_id'];
-            if (in_array($corporationID, $corpArray))
-                continue; // user is in a valid corp, stop checking
+            if (in_array($corporationID, $corpArray)) {
+                            continue;
+            }
+            // user is in a valid corp, stop checking
 
             $timeout = 0;
             do {
@@ -306,8 +312,10 @@ 
                 $timeout++;
                 $corporationDetails = corpDetails($corporationID);
             } while (!isset($corporationDetails));
-            if (isset($corporationDetails['alliance_id']) && in_array($corporationDetails['alliance_id'], $allianceArray))
-                continue; // user is in a valid alliance, stop checking
+            if (isset($corporationDetails['alliance_id']) && in_array($corporationDetails['alliance_id'], $allianceArray)) {
+                            continue;
+            }
+            // user is in a valid alliance, stop checking
 
             //check if user authed based on standings
             $standings = null;
@@ -324,8 +332,10 @@ 
                     $standings = 1;
                 }
             }
-            if ($standings)
-                continue; //keep the user based on standings
+            if ($standings) {
+                            continue;
+            }
+            //keep the user based on standings
 
             // User failed all checks, deactivate user in database
             $sql = "UPDATE authUsers SET active='no' WHERE discordID='$discordID'";
@@ -467,8 +477,7 @@ 
                     while (null === $character) { //try 10 times to pull characterDetails
                         if ($timeout > 9) {
                             continue;
-                        }
-                        else{
+                        } else{
                             $character = characterDetails($charID);
                             $timeout++;
                         }