+global\authCheck::checkPermissions()

Complexity

Conditions	41
Paths	381

Size

Total Lines	88
Code Lines	60

Duplication

Lines	12
Ratio	13.64 %

Importance

Changes

0

<?php
    private function checkPermissions()
    {
        $rows = array();

$rows is not used, you could remove the assignment.

        $dbh = new PDO("mysql:host={$this->db};dbname={$this->dbName}", $this->dbUser, $this->dbPass);
        $rows = array_column($dbh->query('SELECT discordID, characterID, eveName, role FROM authUsers')->fetchAll(), null, 'discordID');

        //Set empty arrays
        $corpArray = array_column($this->authGroups, 'corpID');
        $allianceArray = array_column($this->authGroups, 'allianceID');

        foreach ($this->discord->guilds->get('id', $this->guildID)->members as $member) {
            $discordID = $member->getIdAttribute();
            $discordNick = $member->nick ?: $member->getUsernameAttribute();
            if ($member->getRolesAttribute()->isEmpty()) {
                continue;
            }
            if ($this->discord->id == $discordID) {
                continue;
            }
            $this->logger->addDebug("AuthCheck: Username: $discordNick");
            if (!isset($rows[$discordID])) {
                $this->logger->addInfo("AuthCheck: User [$discordNick] not found in database.");
                $this->removeRoles($member);
                continue;
            }
            $charID = $rows[$discordID]['characterID'];

            // corporation membership check
            for ($i=0; $i<3; $i++) {
                $character = characterDetails($charID);
                //if (isset($character['corporation_id']) && in_array($character['corporation_id'], $corpArray))

80% of this comment could be valid code. Did you maybe forget this after debugging?

                if (!is_null($character))
                    break;
                //Postpone check if ESI is down to prevent timeouts
                if (isset($character['error']) && $character['error'] === 'The datasource tranquility is temporarily unavailable') {
                    $this->logger->addInfo('AuthCheck: The datasource tranquility is temporarily unavailable, check canceled.');
                    $nextCheck = time() + 10800;
                    setPermCache('permsLastChecked', $nextCheck);
                    return;
                }
            }
            if (is_null($character) || isset($character['error'])) {

The variable $character does not seem to be defined for all execution paths leading up to this point.

This code seems to be duplicated across your project.

                $this->logger->addInfo('AuthCheck: characterDetails lookup failed.');
                continue;
            } elseif (isset($character['corporation_id']) && in_array($character['corporation_id'], $corpArray)) {
                continue; // user is in a valid corporation, stop checking
            }

            // alliance membership check
            for ($i=0; $i<3; $i++) {
                $corporationDetails = corpDetails($corporationID);

The variable $corporationID does not exist. Did you forget to declare it?

                if (!is_null($corporationDetails))
                    break;
            }
            if (is_null($corporationDetails) || isset($corporationDetails['error'])) {

The variable $corporationDetails does not seem to be defined for all execution paths leading up to this point.

This code seems to be duplicated across your project.

                $this->logger->addInfo('AuthCheck: corpDetails lookup failed.');
                continue;
            } else if (isset($corporationDetails['alliance_id']) && in_array($corporationDetails['alliance_id'], $allianceArray)) {
                continue; // user is in a valid alliance, stop checking
            }

            //check if user authed based on standings
            $role = $rows[$discordID]['role'];
            $standings = null;
            if ($role === 'blue' || 'neut' || 'red') {
                $allianceContacts = getContacts($allianceID);

The variable $allianceID does not exist. Did you forget to declare it?

Are you sure the assignment to $allianceContacts is correct as getContacts($allianceID) (which targets getContacts()) seems to always return null.

                $corpContacts = getContacts($corporationID);

Are you sure the assignment to $corpContacts is correct as getContacts($corporationID) (which targets getContacts()) seems to always return null.

                if ($role === 'blue' && ((int) $allianceContacts['standing'] === 5 || 10 || (int) $corpContacts['standing'] === 5 || 10)) {
                    $standings = 1;
                }
                if ($role === 'red' && ((int) $allianceContacts['standing'] === -5 || -10 || (int) $corpContacts['standing'] === -5 || -10)) {
                    $standings = 1;
                }
                if ($role === 'neut' && ((int) $allianceContacts['standing'] === 0 || (int) $corpContacts['standing'] === 0 || (@(int) $allianceContacts['standings'] === null || '' && @(int) $corpContacts['standings'] === null || ''))) {
                    $standings = 1;
                }
            }
            if ($standings)

The expression $standings of type integer|null is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

                continue; //keep the user based on standings

            // User failed all checks, deactivate user in database
            $sql = "UPDATE authUsers SET active='no' WHERE discordID='$discordID'";
            $this->logger->addInfo("AuthCheck: {$eveName} account has been deactivated as they are no longer in a correct corp/alliance.");

The variable $eveName does not exist. Did you forget to declare it?

            $dbh->query($sql);
            $this->removeRoles($member);
        }
        setPermCache('permsLastChecked', time() + 1800);
    }