Issues in Dramiel.php - All Issues - Inspection of "added a catch if update fails" - shibdib/Dramiel - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 8e597b...728663 )

by Bob

created 2016-09-07 17:48 UTC

Dramiel.php (4 issues)

Labels

Severity

Minor 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * The MIT License (MIT)
 *
 * Copyright (c) 2016  Robert Sardinia
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

// Require the vendor stuff
require_once(__DIR__ . "/vendor/autoload.php");

// Setup logger
use Monolog\Logger;
use Monolog\Handler\StreamHandler;

// More memory allowance
ini_set("memory_limit", "1024M");

// Just incase we get launched from somewhere else
chdir(__DIR__);

// Enable garbage collection
gc_enable();

// When the bot started
$startTime = time();

// create a log channel
$logger = new Logger('Dramiel');
$logger->pushHandler(new StreamHandler(__DIR__ . '/log/dramielLog.log', Logger::DEBUG));
$logger->addInfo('Logger Initiated');

GLOBAL $logger;
function myFunction($a, $b) {
    // Do something
}

// Require the config
if (file_exists("config/config.php")) {
    require_once("config/config.php");
} else {
    $logger->error("config.php not found (you might wanna start by editing and renaming config_new.php)");
    die();
}

// Load the library files (Probably a prettier way to do this that i haven't thought up yet)
foreach (glob(__DIR__ . "/src/lib/*.php") as $lib) {
    require_once($lib);
}

//Startup DB Check
updateDramielDB($logger);
updateCCPData($logger);

// Init Discord
use Discord\Discord;
use Discord\Parts\User\Game;
use Discord\WebSockets\Event;
use Discord\WebSockets\WebSocket;

$discord = new Discord(["token" => $config["bot"]["token"]]);

// Load tick plugins
$pluginDirs = array("src/plugins/onTick/*.php");
$logger->info("Loading background plugins");
$plugins = array();
foreach ($pluginDirs as $dir) {
    foreach (glob($dir) as $plugin) {
        // Only load the plugins we want to load, according to the config
        if (!in_array(str_replace(".php", "", basename($plugin)), $config["enabledPlugins"])) {
            continue;
        }

        require_once($plugin);
        $fileName = str_replace(".php", "", basename($plugin));
        $p = new $fileName();
        $p->init($config, $discord, $logger);
        $pluginsT[] = $p;
    }
}
// Number of plugins loaded
$logger->info("Loaded: " . count($pluginsT) . " background plugins");

if ($config["bot"]["silentMode"] == "false" || !isset($config["bot"]["silentMode"])) {
// Load chat plugins
    $pluginDirs = array("src/plugins/onMessage/*.php", "src/plugins/admin/*.php");
    $adminPlugins = array("setNickname", "updateBot", "holder");
    $logger->addInfo("Loading in chat plugins");
    $plugins = array();
    foreach ($pluginDirs as $dir) {
        foreach (glob($dir) as $plugin) {
            var_dump($plugin);
            var_dump($adminPlugins);
            // Only load the plugins we want to load, according to the config
            if (!in_array(str_replace(".php", "", basename($plugin)), $config["enabledPlugins"]) && !in_array(str_replace(".php", "", basename($plugin)), $adminPlugins)) {
                continue;
            }

            require_once($plugin);
            $fileName = str_replace(".php", "", basename($plugin));
            $p = new $fileName();
            $p->init($config, $discord, $logger);
            $plugins[] = $p;
        }
    }

// Number of chat plugins loaded
    $logger->addInfo("Loaded: " . count($plugins) . " chat plugins");
}

$discord->on(
    'ready',
    function($discord) use ($logger, $config, $plugins, $pluginsT) {
        // In here we can access any of the WebSocket events.
        //
        // There is a list of event constants that you can
        // find here: https://teamreflex.github.io/DiscordPHP/classes/Discord.WebSockets.Event.html
        //
        // We will echo to the console that the WebSocket is ready.
        $logger->addInfo('Discord WebSocket is ready!' . PHP_EOL);
        //$game = new Game(array('name' => $config["bot"]["game"], 'url' => null, 'type' => null), true);

        //$discord->updatePresence($game, false);

        // $ws->setNickname($config["bot"]["name"]); //not in yet


        // Database check
        $discord->loop->addPeriodicTimer(86400, function() use ($logger) {
            updateDramielDB($logger);
            updateCCPData($logger);
        });

        // Run the Tick plugins
        $discord->loop->addPeriodicTimer(5, function() use ($pluginsT) {
            foreach ($pluginsT as $plugin)
                $plugin->tick();
        });

        // Mem cleanup every 30 minutes
        $discord->loop->addPeriodicTimer(1800, function() use ($logger) {
            $logger->addInfo("Memory in use: " . memory_get_usage() / 1024 / 1024 . "MB");
            gc_collect_cycles(); // Collect garbage
            $logger->addInfo("Memory in use after garbage collection: " . memory_get_usage() / 1024 / 1024 . "MB");
        });

        $discord->on(
            Event::MESSAGE_CREATE,
            function($message) use ($logger, $config, $plugins) {

                $msgData = array(
                    "message" => array(
                        "timestamp" => $message->timestamp,
                        "id" => $message->id,
                        "message" => $message->content,
                        "channelID" => $message->channel_id,
                        "from" => $message->author->username,
                        "fromID" => $message->author->id,
                        "fromDiscriminator" => $message->author->discriminator,
                        "fromAvatar" => $message->author->avatar
                    )
                );

                if ($message->content == '(╯°□°）╯︵ ┻━┻') {
                    $message->reply('┬─┬﻿ ノ( ゜-゜ノ)');
                }

                // We are just checking if the message equals to ping and replying to the user with a pong!
                if ($message->content == 'ping') {
                    $message->reply('pong!');
                }
                // Check for plugins
                if (isset($message->content[0])) {
                    if ($message->content[0] == $config["bot"]["trigger"]) {
                        foreach ($plugins as $plugin) {
                            try {
                                $plugin->onMessage($msgData, $message);
                            } catch (Exception $e) {
                                $logger->addError("Error: " . $e->getMessage());
                            }
                        }
                    }
                }
            }
        );
    }
);
$discord->on(
    'error',
    function($error) use ($logger) {
        $logger->addError($error);
        exit(1);
    }
);
$discord->on(
    'reconnecting',
    function() use ($logger) {
        $logger->addInfo('Websocket is reconnecting..');
    });
$discord->on(
    'reconnected',
    function() use ($logger) {
        $logger->addInfo('Websocket was reconnected..');
    });
// Now we will run the ReactPHP Event Loop!
$discord->run();



Push — master ( 8e597b...728663 )

Dramiel.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2			/**
3			* The MIT License (MIT)
4			*
5			* Copyright (c) 2016 Robert Sardinia
6			*
7			* Permission is hereby granted, free of charge, to any person obtaining a copy
8			* of this software and associated documentation files (the "Software"), to deal
9			* in the Software without restriction, including without limitation the rights
10			* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
11			* copies of the Software, and to permit persons to whom the Software is
12			* furnished to do so, subject to the following conditions:
13			*
14			* The above copyright notice and this permission notice shall be included in all
15			* copies or substantial portions of the Software.
16			*
17			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
18			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
19			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
20			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
21			* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
22			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
23			* SOFTWARE.
24			*/
25
26			// Require the vendor stuff
27			require_once(__DIR__ . "/vendor/autoload.php");
28
29			// Setup logger
30			use Monolog\Logger;
31			use Monolog\Handler\StreamHandler;
32
33			// More memory allowance
34			ini_set("memory_limit", "1024M");
35
36			// Just incase we get launched from somewhere else
37			chdir(__DIR__);
38
39			// Enable garbage collection
40			gc_enable();
41
42			// When the bot started
43			$startTime = time();
44
45			// create a log channel
46			$logger = new Logger('Dramiel');
47			$logger->pushHandler(new StreamHandler(__DIR__ . '/log/dramielLog.log', Logger::DEBUG));
48			$logger->addInfo('Logger Initiated');
49
50			GLOBAL $logger;
			0 ignored issues – show Compatibility Best Practice introduced 2016-07-16 19:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
51
52			// Require the config
53			if (file_exists("config/config.php")) {
54			require_once("config/config.php");
55			} else {
56			$logger->error("config.php not found (you might wanna start by editing and renaming config_new.php)");
57			die();
58			}
59
60			// Load the library files (Probably a prettier way to do this that i haven't thought up yet)
61			foreach (glob(__DIR__ . "/src/lib/*.php") as $lib) {
62			require_once($lib);
63			}
64
65			//Startup DB Check
66			updateDramielDB($logger);
67			updateCCPData($logger);
68
69			// Init Discord
70			use Discord\Discord;
71			use Discord\Parts\User\Game;
72			use Discord\WebSockets\Event;
73			use Discord\WebSockets\WebSocket;
74
75			$discord = new Discord(["token" => $config["bot"]["token"]]);
76
77			// Load tick plugins
78			$pluginDirs = array("src/plugins/onTick/*.php");
79			$logger->info("Loading background plugins");
80			$plugins = array();
81			foreach ($pluginDirs as $dir) {
82			foreach (glob($dir) as $plugin) {
83			// Only load the plugins we want to load, according to the config
84			if (!in_array(str_replace(".php", "", basename($plugin)), $config["enabledPlugins"])) {
85			continue;
86			}
87
88			require_once($plugin);
89			$fileName = str_replace(".php", "", basename($plugin));
90			$p = new $fileName();
91			$p->init($config, $discord, $logger);
92			$pluginsT[] = $p;
93			}
94			}
95			// Number of plugins loaded
96			$logger->info("Loaded: " . count($pluginsT) . " background plugins");
97
98			if ($config["bot"]["silentMode"] == "false" \|\| !isset($config["bot"]["silentMode"])) {
99			// Load chat plugins
100			$pluginDirs = array("src/plugins/onMessage/.php", "src/plugins/admin/.php");
101			$adminPlugins = array("setNickname", "updateBot", "holder");
102			$logger->addInfo("Loading in chat plugins");
103			$plugins = array();
104			foreach ($pluginDirs as $dir) {
105			foreach (glob($dir) as $plugin) {
106			var_dump($plugin);
107			var_dump($adminPlugins);
108			// Only load the plugins we want to load, according to the config
109			if (!in_array(str_replace(".php", "", basename($plugin)), $config["enabledPlugins"]) && !in_array(str_replace(".php", "", basename($plugin)), $adminPlugins)) {
110			continue;
111			}
112
113			require_once($plugin);
114			$fileName = str_replace(".php", "", basename($plugin));
115			$p = new $fileName();
116			$p->init($config, $discord, $logger);
117			$plugins[] = $p;
118			}
119			}
120
121			// Number of chat plugins loaded
122			$logger->addInfo("Loaded: " . count($plugins) . " chat plugins");
123			}
124
125			$discord->on(
126			'ready',
127			function($discord) use ($logger, $config, $plugins, $pluginsT) {
128			// In here we can access any of the WebSocket events.
129			//
130			// There is a list of event constants that you can
131			// find here: https://teamreflex.github.io/DiscordPHP/classes/Discord.WebSockets.Event.html
132			//
133			// We will echo to the console that the WebSocket is ready.
134			$logger->addInfo('Discord WebSocket is ready!' . PHP_EOL);
135			//$game = new Game(array('name' => $config["bot"]["game"], 'url' => null, 'type' => null), true);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-08-29 11:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this `61%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
136			//$discord->updatePresence($game, false);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-08-29 11:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this `80%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
137			// $ws->setNickname($config["bot"]["name"]); //not in yet
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-07-16 19:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this `80%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
138
139			// Database check
140			$discord->loop->addPeriodicTimer(86400, function() use ($logger) {
141			updateDramielDB($logger);
142			updateCCPData($logger);
143			});
144
145			// Run the Tick plugins
146			$discord->loop->addPeriodicTimer(5, function() use ($pluginsT) {
147			foreach ($pluginsT as $plugin)
148			$plugin->tick();
149			});
150
151			// Mem cleanup every 30 minutes
152			$discord->loop->addPeriodicTimer(1800, function() use ($logger) {
153			$logger->addInfo("Memory in use: " . memory_get_usage() / 1024 / 1024 . "MB");
154			gc_collect_cycles(); // Collect garbage
155			$logger->addInfo("Memory in use after garbage collection: " . memory_get_usage() / 1024 / 1024 . "MB");
156			});
157
158			$discord->on(
159			Event::MESSAGE_CREATE,
160			function($message) use ($logger, $config, $plugins) {
161
162			$msgData = array(
163			"message" => array(
164			"timestamp" => $message->timestamp,
165			"id" => $message->id,
166			"message" => $message->content,
167			"channelID" => $message->channel_id,
168			"from" => $message->author->username,
169			"fromID" => $message->author->id,
170			"fromDiscriminator" => $message->author->discriminator,
171			"fromAvatar" => $message->author->avatar
172			)
173			);
174
175			if ($message->content == '(╯°□°）╯︵ ┻━┻') {
176			$message->reply('┬─┬ ノ( ゜-゜ノ)');
177			}
178
179			// We are just checking if the message equals to ping and replying to the user with a pong!
180			if ($message->content == 'ping') {
181			$message->reply('pong!');
182			}
183			// Check for plugins
184			if (isset($message->content[0])) {
185			if ($message->content[0] == $config["bot"]["trigger"]) {
186			foreach ($plugins as $plugin) {
187			try {
188			$plugin->onMessage($msgData, $message);
189			} catch (Exception $e) {
190			$logger->addError("Error: " . $e->getMessage());
191			}
192			}
193			}
194			}
195			}
196			);
197			}
198			);
199			$discord->on(
200			'error',
201			function($error) use ($logger) {
202			$logger->addError($error);
203			exit(1);
204			}
205			);
206			$discord->on(
207			'reconnecting',
208			function() use ($logger) {
209			$logger->addInfo('Websocket is reconnecting..');
210			});
211			$discord->on(
212			'reconnected',
213			function() use ($logger) {
214			$logger->addInfo('Websocket was reconnected..');
215			});
216			// Now we will run the ReactPHP Event Loop!
217			$discord->run();
218
219

shibdib / Dramiel

Push — master ( 8e597b...728663 )

Dramiel.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like