+global\authCheck::checkAuth()

Complexity

Conditions	18
Paths	216

Size

Total Lines	116
Code Lines	80

Duplication

Lines	0
Ratio	0 %

Importance

Changes	23
Bugs	9	Features	1

<?php
    function checkAuth($discord)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $db = $this->config["database"]["host"];
        $dbUser = $this->config["database"]["user"];
        $dbPass = $this->config["database"]["pass"];
        $dbName = $this->config["database"]["database"];
        $id = $this->config["bot"]["guild"];
        $allyID = $this->config["plugins"]["auth"]["allianceID"];
        $corpID = $this->config["plugins"]["auth"]["corpID"];
        $exempt = $this->config["plugins"]["auth"]["exempt"];
        if(is_null($exempt)){
            $exempt = "0";
        }
        $toDiscordChannel = $this->config["plugins"]["auth"]["alertChannel"];
        $conn = new mysqli($db, $dbUser, $dbPass, $dbName);

        //get bot ID so we don't remove out own roles
        $botID = $this->discord->id;

        //Remove members who have roles but never authed
        $guild = $discord->guilds->get('id', $id);
        foreach($guild->members as $member) {
            $notifier = null;

$notifier is not used, you could remove the assignment.

            $id = $member->id;
            $username = $member->username;
            $roles = $member->roles;

            $sql = "SELECT * FROM authUsers WHERE discordID='$id' AND active='yes'";

            $result = $conn->query($sql);
            if($result->num_rows == 0) {
                foreach ($roles as $role) {
                    if(!isset($role->name)){
                        if($id != $botID && !in_array($role->name, $exempt, true)){
                            $member->removeRole($role);
                            $guild->members->save($member);
                            // Send the info to the channel
                            $msg = "{$username} has been removed from the {$role->name} role as they never authed (Someone manually assigned them roles).";
                            $channelID = $toDiscordChannel;
                            $channel = $guild->channels->get('id', $channelID);
                            $channel->sendMessage($msg, false);
                            $this->logger->addInfo("{$username} has been removed from the {$role->name} role as they never authed.");
                        }
                    }
                }
            }
        }

        $sql = "SELECT characterID, discordID, eveName FROM authUsers WHERE active='yes'";

        $result = $conn->query($sql);
        $num_rows = $result->num_rows;

        if ($num_rows >= 1) {
            while ($rows = $result->fetch_assoc()) {
                $charID = $rows['characterID'];
                $discordID = $rows['discordID'];
                $member = $guild->members->get("id", $discordID);
                $eveName = $rows['eveName'];
                $roles = $member->roles;

                if ($this->config["plugins"]["auth"]["nameEnforce"] == "true") {
                    $nick = $eveName;
                    $member->setNickname($nick);
                }

                $url = "https://api.eveonline.com/eve/CharacterAffiliation.xml.aspx?ids=$charID";
                $xml = makeApiRequest($url);
                // Stop the process if the api is throwing an error
                if (is_null($xml)){
                    $this->logger->addInfo("{$eveName} cannot be authed, API issues detected.");
                    return null;
                }
                if ($xml->result->rowset->row[0]) {
                    foreach ($xml->result->rowset->row as $character) {

                        if ($character->attributes()->allianceID != $allyID && $character->attributes()->corporationID != $corpID) {
                            foreach ($roles as $role) {
                                $member->removeRole($role);
                                $guild->members->save($member);
                            }

                            $statsURL = "https://api.eveonline.com/eve/CharacterName.xml.aspx?ids=" . urlencode($character->attributes()->corporationID) . "/";
                            $stats = makeApiRequest($statsURL);
                            foreach ($stats->result->rowset->row as $corporation) {
                                $corporationName = $corporation->attributes()->name;
                            }

                            // Send the info to the channel
                            $msg = "{$eveName} roles have been removed, user is now a member of **{$corporationName}**.";

The variable $corporationName does not seem to be defined for all execution paths leading up to this point.

                            $channelID = $toDiscordChannel;
                            $channel = $guild->channels->get('id', $channelID);
                            $channel->sendMessage($msg, false);
                            $this->logger->addInfo("{$eveName} roles ({$role}) have been removed, user is now a member of **{$corporationName}**.");

The variable $role does not seem to be defined for all execution paths leading up to this point.

                            $sql = "UPDATE authUsers SET active='no' WHERE discordID='$discordID'";
                            $conn->query($sql);

                        }
                    }
                }
            }
            $this->logger->addInfo("All users successfully authed.");
            $nextCheck = time() + 7200;
            setPermCache("authLastChecked", $nextCheck);
            $cacheTimer = gmdate("Y-m-d H:i:s", $nextCheck);
            $this->logger->addInfo("Next auth and name check at {$cacheTimer} EVE");
            return null;
        }
        $this->logger->addInfo("No users found in database.");
        $nextCheck = time() + 7200;
        setPermCache("authLastChecked", $nextCheck);
        $cacheTimer = gmdate("Y-m-d H:i:s", $nextCheck);
        $this->logger->addInfo("Next auth and name check at {$cacheTimer} EVE");
        return null;
    }