shibdib /
Dramiel
| Conditions | 34 |
| Paths | 721 |
| Total Lines | 133 |
| Code Lines | 91 |
| Lines | 28 |
| Ratio | 21.05 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 81 | private function getKM() |
||
| 82 | { |
||
| 83 | $i = 0; |
||
| 84 | while ($i < 25) { |
||
| 85 | $kill = zKillRedis(); |
||
| 86 | $i++; |
||
| 87 | |||
| 88 | //Check if mail is null |
||
| 89 | if (null === $kill['killID']) { |
||
| 90 | break; |
||
| 91 | } |
||
| 92 | |||
| 93 | //Check if mail is a big kill |
||
| 94 | if (@$kill['zkb']['totalValue'] >= 10000000000 && @$this->config['plugins']['getKillmails']['bigKills']['shareBigKills'] === 'true') { |
||
| 95 | $killID = getPermCache('bigKillNewestKillmailID'); |
||
| 96 | View Code Duplication | if ($this->config['plugins']['getKillmails']['bigKills']['bigKillStartID'] > $killID || null === $killID) { |
|
| 97 | $killID = $this->config['plugins']['getKillmails']['bigKills']['bigKillStartID']; |
||
| 98 | } |
||
| 99 | if ($killID > $kill['killmail']['killID']) { |
||
| 100 | continue; |
||
| 101 | } |
||
| 102 | $channelID = $this->config['plugins']['getKillmails']['bigKills']['bigKillChannel']; |
||
| 103 | $killID = $kill['killmail']['killID']; |
||
| 104 | $systemName = $kill['killmail']['solarSystem']['name']; |
||
| 105 | $killTime = $kill['killmail']['killTime']; |
||
| 106 | $victimAllianceName = @$kill['killmail']['victim']['alliance']['name']; |
||
| 107 | $victimName = $kill['killmail']['victim']['character']['name']; |
||
| 108 | $victimCorpName = @$kill['killmail']['victim']['corporation']['name']; |
||
| 109 | $shipName = $kill['killmail']['victim']['shipType']['name']; |
||
| 110 | $totalValue = number_format($kill['zkb']['totalValue']); |
||
| 111 | // Check if it's a structure |
||
| 112 | View Code Duplication | if ($victimName !== '') { |
|
| 113 | $msg = "**10b+ Kill Reported**\n\n**{$killTime}**\n\n**{$shipName}** worth **{$totalValue} ISK** flown by **{$victimName}** of (***{$victimCorpName}|{$victimAllianceName}***) killed in {$systemName}\nhttps://zkillboard.com/kill/{$killID}/"; |
||
| 114 | } else { |
||
| 115 | $msg = "**10b+ Kill Reported**\n\n**{$killTime}**\n\n**{$shipName}** worth **{$totalValue} ISK** owned by (***{$victimCorpName}|{$victimAllianceName}***) killed in {$systemName}\nhttps://zkillboard.com/kill/{$killID}/"; |
||
| 116 | } |
||
| 117 | if (null === $msg) { // Make sure it's always set. |
||
| 118 | return null; |
||
| 119 | } |
||
| 120 | queueMessage($msg, $channelID, $this->guild); |
||
| 121 | $newID = $killID++; |
||
| 122 | setPermCache('bigKillNewestKillmailID', $newID); |
||
| 123 | $this->logger->addInfo("Killmails: BIG KILLMAIL Mail {$killID} queued."); |
||
| 124 | continue; |
||
| 125 | } |
||
| 126 | |||
| 127 | foreach ($this->groupConfig as $kmGroup) { |
||
| 128 | $killID = getPermCache("{$kmGroup['name']}newestKillmailID"); |
||
| 129 | |||
| 130 | //check if start id is greater than current id and if it is set |
||
| 131 | View Code Duplication | if ($kmGroup['startMail'] > $killID || null === $killID) { |
|
| 132 | $killID = $kmGroup['startMail']; |
||
| 133 | } |
||
| 134 | |||
| 135 | //Check if id's are in the kill |
||
| 136 | $corpLoss = false; |
||
| 137 | $allianceLoss = false; |
||
| 138 | $corpKill = false; |
||
| 139 | $allianceKill = false; |
||
| 140 | $attackerCorpArray = array(); |
||
| 141 | $attackerAllianceArray = array(); |
||
| 142 | |||
| 143 | foreach ($kill['killmail']['attackers'] as $attacker) { |
||
| 144 | $attackerCorpArray[] = (int)@$attacker['corporation']['id']; |
||
| 145 | $attackerAllianceArray[] = (int)@$attacker['alliance']['id']; |
||
| 146 | } |
||
| 147 | |||
| 148 | if ((int)@$kill['killmail']['victim']['corporation']['id'] === $kmGroup['corpID'] && (int)$kmGroup['corpID'] !== 0) { |
||
| 149 | $corpLoss = true; |
||
| 150 | } elseif ((int)@$kill['killmail']['victim']['alliance']['id'] === $kmGroup['allianceID'] && (int)$kmGroup['allianceID'] !== 0) { |
||
| 151 | $allianceLoss = true; |
||
| 152 | } elseif (in_array((int)$kmGroup['corpID'], $attackerCorpArray) && (int)$kmGroup['corpID'] !== 0) { |
||
| 153 | $corpKill = true; |
||
| 154 | } elseif (in_array((int)$kmGroup['allianceID'], $attackerAllianceArray) && (int)$kmGroup['allianceID'] !== 0) { |
||
| 155 | $allianceKill = true; |
||
| 156 | } else { |
||
| 157 | break; |
||
| 158 | } |
||
| 159 | |||
| 160 | //Check if it's a lossmail and lossmails are turned off |
||
| 161 | if (($corpLoss === true || $allianceLoss === true) && $kmGroup['lossMails'] === 'false') { |
||
| 162 | break; |
||
| 163 | } |
||
| 164 | |||
| 165 | //Check if it's an old kill |
||
| 166 | if ($killID > $kill['killmail']['killID']) { |
||
| 167 | break; |
||
| 168 | } |
||
| 169 | |||
| 170 | //if big kill isn't set, disable it |
||
| 171 | if (null === $kmGroup['bigKill']) { |
||
| 172 | $kmGroup['bigKill'] = 99999999999999999999999999; |
||
| 173 | } |
||
| 174 | $killID = $kill['killmail']['killID']; |
||
| 175 | $channelID = $kmGroup['channel']; |
||
| 176 | $systemName = $kill['killmail']['solarSystem']['name']; |
||
| 177 | $killTime = $kill['killmail']['killTime']; |
||
| 178 | $victimAllianceName = @$kill['killmail']['victim']['alliance']['name']; |
||
| 179 | $victimName = $kill['killmail']['victim']['character']['name']; |
||
| 180 | $victimCorpName = @$kill['killmail']['victim']['corporation']['name']; |
||
| 181 | $shipName = $kill['killmail']['victim']['shipType']['name']; |
||
| 182 | $rawValue = $kill['zkb']['totalValue']; |
||
| 183 | //Check if killmail meets minimum value |
||
| 184 | View Code Duplication | if (isset($kmGroup['minimumValue'])) { |
|
| 185 | if ($rawValue < $kmGroup['minimumValue']) { |
||
| 186 | $this->logger->addInfo("Killmails: Mail {$killID} ignored for not meeting the minimum value required."); |
||
| 187 | setPermCache("{$kmGroup['name']}newestKillmailID", $killID); |
||
| 188 | continue; |
||
| 189 | } |
||
| 190 | } |
||
| 191 | $totalValue = number_format($kill['zkb']['totalValue']); |
||
| 192 | // Check if it's a structure |
||
| 193 | View Code Duplication | if ($victimName !== '') { |
|
| 194 | if ($rawValue >= $kmGroup['bigKill']) { |
||
| 195 | $channelID = $kmGroup['bigKillChannel']; |
||
| 196 | $msg = "@here \n :warning:***Expensive Killmail***:warning: \n **{$killTime}**\n\n**{$shipName}** worth **{$totalValue} ISK** flown by **{$victimName}** of (***{$victimCorpName}|{$victimAllianceName}***) killed in {$systemName}\nhttps://zkillboard.com/kill/{$killID}/"; |
||
| 197 | } elseif ($rawValue <= $kmGroup['bigKill']) { |
||
| 198 | $msg = "**{$killTime}**\n\n**{$shipName}** worth **{$totalValue} ISK** flown by **{$victimName}** of (***{$victimCorpName}|{$victimAllianceName}***) killed in {$systemName}\nhttps://zkillboard.com/kill/{$killID}/"; |
||
| 199 | } |
||
| 200 | } elseif ($victimName === '') { |
||
| 201 | $msg = "**{$killTime}**\n\n**{$shipName}** worth **{$totalValue} ISK** owned by (***{$victimCorpName}|{$victimAllianceName}***) killed in {$systemName}\nhttps://zkillboard.com/kill/{$killID}/"; |
||
| 202 | } |
||
| 203 | |||
| 204 | if (null === $msg) { // Make sure it's always set. |
||
| 205 | return null; |
||
| 206 | } |
||
| 207 | queueMessage($msg, $channelID, $this->guild); |
||
| 208 | $this->logger->addInfo("Killmails: Mail {$killID} queued."); |
||
| 209 | setPermCache("{$kmGroup['name']}newestKillmailID", $killID); |
||
| 210 | break; |
||
| 211 | } |
||
| 212 | } |
||
| 213 | } |
||
| 214 | } |
||
| 215 |
Loading history...
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.