setAvatar::onMessage() - Code Metrics - shibdib/Dramiel - Measure and Improve Code Quality continuously with Scrutinizer

setAvatar::onMessage() B
last analyzed 2017-11-21 19:00 UTC

↳ Parent: setAvatar

Complexity

Conditions	6
Paths	6

Size

Total Lines	51
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	6
eloc	40
nc	6
nop	2
dl	0
loc	51
rs	8.6588
c	0
b	0
f	0

How to fix Long Method

<?php
/**
 * The MIT License (MIT)
 *
 * Copyright (c) 2016 Robert Sardinia
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

use Discord\Parts\User\Client;

/**
 * @property  message
 */
class setAvatar
namespace YourVendor;

class YourClass { }
{
    public $config;
    public $discord;
    public $logger;
    public $message;

    /**
     * @param $config
     * @param $discord
     * @param $logger
     */
    public function init($config, $discord, $logger)
    {
        $this->config = $config;
        $this->discord = $discord;
        $this->logger = $logger;
    }

    /**
     * @param $msgData
     * @param $message
     * @return null
     */
    public function onMessage($msgData, $message)
    {
        $this->message = $message;

        $message = $msgData['message']['message'];

        $data = command($message, $this->information()['trigger'], $this->config['bot']['trigger']);
        if (isset($data['trigger'])) {

            //Admin Check
            $userID = $msgData['message']['fromID'];
            $adminRoles = $this->config['bot']['adminRoles'];
            $adminRoles = array_map('strtolower', $adminRoles);
            $id = $this->config['bot']['guild'];
            $guild = $this->discord->guilds->get('id', $id);
            $member = $guild->members->get('id', $userID);
            $roles = $member->roles;
            foreach ($roles as $role) {
                if (in_array(strtolower($role->name), $adminRoles, true)) {
                    $avatarURL = strtolower((string)$data['messageString']);
                    $ch = curl_init($avatarURL);
                    if (substr($avatarURL, -4) === '.jpg') {
                        $fp = fopen('/tmp/avatar.jpg', 'wb');
                        $dir = '/tmp/avatar.jpg';
                    } elseif (substr($avatarURL, -4) === '.png') {
                        $fp = fopen('/tmp/avatar.png', 'wb');
                        $dir = '/tmp/avatar.png';
                    } else {
                        return $this->message->reply('Invalid URL. Make sure the URL links directly to a JPG or PNG.');
                    }
                    curl_setopt($ch, CURLOPT_FILE, $fp);
                    curl_setopt($ch, CURLOPT_HEADER, 0);
                    curl_exec($ch);
                    curl_close($ch);
                    fclose($fp);
                    $this->discord->setAvatar($dir);
                    $this->discord->save();

                    $msg = 'New avatar set';
                    $this->logger->addInfo("setGame: Bot avatar changed to {$avatarURL} by {$msgData['message']['from']}");
                    $this->message->reply($msg);
                    return null;
                }
            }
            $this->logger->addInfo("setGame: {$msgData['message']['from']} attempted to change the bot's avatar.");
            $msg = ':bangbang: You do not have the necessary roles to issue this command :bangbang:';
            $this->message->reply($msg);
            return null;
        }
        return null;
    }

    /**
     * @return array
     */
    public function information()

    {
        return array(
            'name' => 'avatar',
            'trigger' => array($this->config['bot']['trigger'] . 'avatar'),
            'information' => 'Changes the bots avatar (!avatar url) **(Admin Role Required)**'
        );
    }

}


1		<?php
2		/**
3		* The MIT License (MIT)
4		*
5		* Copyright (c) 2016 Robert Sardinia
6		*
7		* Permission is hereby granted, free of charge, to any person obtaining a copy
8		* of this software and associated documentation files (the "Software"), to deal
9		* in the Software without restriction, including without limitation the rights
10		* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
11		* copies of the Software, and to permit persons to whom the Software is
12		* furnished to do so, subject to the following conditions:
13		*
14		* The above copyright notice and this permission notice shall be included in all
15		* copies or substantial portions of the Software.
16		*
17		* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
18		* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
19		* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
20		* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
21		* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
22		* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
23		* SOFTWARE.
24		*/
25
26		use Discord\Parts\User\Client;
27
28		/**
29		* @property message
30		*/
31		class setAvatar
		0 ignored issues – show Coding Style Compatibility introduced 2017-01-12 19:55 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
32		{
33		public $config;
34		public $discord;
35		public $logger;
36		public $message;
37
38		/**
39		* @param $config
40		* @param $discord
41		* @param $logger
42		*/
43		public function init($config, $discord, $logger)
44		{
45		$this->config = $config;
46		$this->discord = $discord;
47		$this->logger = $logger;
48		}
49
50		/**
51		* @param $msgData
52		* @param $message
53		* @return null
54		*/
55		public function onMessage($msgData, $message)
56		{
57		$this->message = $message;
58
59		$message = $msgData['message']['message'];
60
61		$data = command($message, $this->information()['trigger'], $this->config['bot']['trigger']);
62		if (isset($data['trigger'])) {
63
64		//Admin Check
65		$userID = $msgData['message']['fromID'];
66		$adminRoles = $this->config['bot']['adminRoles'];
67		$adminRoles = array_map('strtolower', $adminRoles);
68		$id = $this->config['bot']['guild'];
69		$guild = $this->discord->guilds->get('id', $id);
70		$member = $guild->members->get('id', $userID);
71		$roles = $member->roles;
72		foreach ($roles as $role) {
73		if (in_array(strtolower($role->name), $adminRoles, true)) {
74		$avatarURL = strtolower((string)$data['messageString']);
75		$ch = curl_init($avatarURL);
76		if (substr($avatarURL, -4) === '.jpg') {
77		$fp = fopen('/tmp/avatar.jpg', 'wb');
78		$dir = '/tmp/avatar.jpg';
79		} elseif (substr($avatarURL, -4) === '.png') {
80		$fp = fopen('/tmp/avatar.png', 'wb');
81		$dir = '/tmp/avatar.png';
82		} else {
83		return $this->message->reply('Invalid URL. Make sure the URL links directly to a JPG or PNG.');
84		}
85		curl_setopt($ch, CURLOPT_FILE, $fp);
86		curl_setopt($ch, CURLOPT_HEADER, 0);
87		curl_exec($ch);
88		curl_close($ch);
89		fclose($fp);
90		$this->discord->setAvatar($dir);
91		$this->discord->save();
92
93		$msg = 'New avatar set';
94		$this->logger->addInfo("setGame: Bot avatar changed to {$avatarURL} by {$msgData['message']['from']}");
95		$this->message->reply($msg);
96		return null;
97		}
98		}
99		$this->logger->addInfo("setGame: {$msgData['message']['from']} attempted to change the bot's avatar.");
100		$msg = ':bangbang: You do not have the necessary roles to issue this command :bangbang:';
101		$this->message->reply($msg);
102		return null;
103		}
104		return null;
105		}
106
107		/**
108		* @return array
109		*/
110	View Code Duplication	public function information()
		0 ignored issues – show Duplication introduced 2017-08-09 18:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
111		{
112		return array(
113		'name' => 'avatar',
114		'trigger' => array($this->config['bot']['trigger'] . 'avatar'),
115		'information' => 'Changes the bots avatar (!avatar url) (Admin Role Required)'
116		);
117		}
118
119		}
120

shibdib / Dramiel

setAvatar::onMessage() B last analyzed 2017-11-21 19:00 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

setAvatar::onMessage() B
last analyzed 2017-11-21 19:00 UTC