getKillmailsOld - Code Metrics - shibdib/Dramiel - Measure and Improve Code Quality continuously with Scrutinizer

getKillmailsOld B
last analyzed 2017-11-21 19:00 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	223
Duplicated Lines	21.52 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
dl	48
loc	223
rs	8.5454
c	0
b	0
f	0
wmc	49
lcom	1
cbo	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	init()	10	10	1
B	tick()	5	23	5
F	getKM()	25	107	32
C	getBigKM()	8	61	11

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like getKillmailsOld often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use getKillmailsOld, and based on these observations, apply Extract Interface, too.

<?php
/**
 * The MIT License (MIT)
 *
 * Copyright (c) 2016 Robert Sardinia
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

use discord\discord;

/**
 * Class getKillmails
 */
class getKillmailsOld
namespace YourVendor;

class YourClass { }
{
    public $config;
    public $db;
    public $discord;
    public $channelConfig;
    public $lastCheck = 0;
    public $logger;
    public $groupConfig;

    /**
     * @param $config
     * @param $discord
     * @param $logger
     */
    public function init($config, $discord, $logger)

    {
        $this->config = $config;
        $this->discord = $discord;
        $this->logger = $logger;
        $this->groupConfig = $config['plugins']['getKillmails']['groupConfig'];
        $this->guild = $config['bot']['guild'];
class MyClass { }

$x = new MyClass();
$x->foo = true;
        //Refresh check at bot start
        setPermCache('killmailCheck', time() - 5);
    }

    /**
     *
     */
    public function tick()
    {
        // What was the servers last reported state
        $lastStatus = getPermCache('serverState');
        if ($lastStatus === 'online') {
            $lastChecked = getPermCache('killmailCheck');
            if ($lastChecked <= time()) {
                //check if user is still using the old config
                if (null === $this->groupConfig) {

                    $this->logger->addError('Killmails: UPDATE YOUR CONFIG TO RECEIVE KILLMAILS');
                    setPermCache('killmailCheck', time() + 600);
                    return null;
                }
                $this->logger->addInfo('Killmails: Checking for new killmails.');
                $this->getKM();
                setPermCache('killmailCheck', time() + 600);
                if (@$this->config['plugins']['getKillmails']['bigKills']['shareBigKills'] === 'true') {
                    $this->logger->addInfo('Killmails: Checking for 10b+ kills.');
                    $this->getBigKM();
                }
            }
        }
    }

    private function getKM()
    {
        foreach ($this->groupConfig as $kmGroup) {
            $SavedKillID = getPermCache("{$kmGroup['name']}newestKillmailID");
            //check if start id is greater than current id and if it is set
            if (null !== $SavedKillID && preg_match('/[a-z]/i', $SavedKillID)) {
                getStartMail($kmGroup);
                $SavedKillID = getPermCache("{$kmGroup['name']}newestKillmailID");
            }
            if ($kmGroup['startMail'] > $SavedKillID || null === $SavedKillID) {
                $SavedKillID = $kmGroup['startMail'];
            }
            if ((string)$kmGroup['allianceID'] === '0' & $kmGroup['lossMails'] === 'true') {
// Returns always int(0).
return 0 === $foo & 4;
return (0 === $foo) & 4;

// More likely intended return: true/false
return 0 === ($foo & 4);
                $url = "https://zkillboard.com/api/corporationID/{$kmGroup['corpID']}/no-attackers/no-items/orderDirection/asc/pastSeconds/10800/";
            }
            if ((string)$kmGroup['allianceID'] === '0' & $kmGroup['lossMails'] === 'false') {
// Returns always int(0).
return 0 === $foo & 4;
return (0 === $foo) & 4;

// More likely intended return: true/false
return 0 === ($foo & 4);
                $url = "https://zkillboard.com/api/corporationID/{$kmGroup['corpID']}/no-attackers/no-items/kills/orderDirection/asc/pastSeconds/10800/";
            }
            if ((string)$kmGroup['allianceID'] !== '0' & $kmGroup['lossMails'] === 'true') {
// Returns always int(0).
return 0 === $foo & 4;
return (0 === $foo) & 4;

// More likely intended return: true/false
return 0 === ($foo & 4);
                $url = "https://zkillboard.com/api/allianceID/{$kmGroup['allianceID']}/no-attackers/no-items/orderDirection/asc/pastSeconds/10800/";
            }
            if ((string)$kmGroup['allianceID'] !== '0' & $kmGroup['lossMails'] === 'false') {
// Returns always int(0).
return 0 === $foo & 4;
return (0 === $foo) & 4;

// More likely intended return: true/false
return 0 === ($foo & 4);
                $url = "https://zkillboard.com/api/allianceID/{$kmGroup['allianceID']}/no-attackers/no-items/kills/orderDirection/asc/pastSeconds/10800/";
            }

            if (!isset($url)) { // Make sure it's always set.
                $this->logger->addInfo('Killmails: ERROR - Ensure your config file is setup correctly for killmails.');
                return null;
            }

            $kills = json_decode(downloadData($url), true);
//            $i = 0;

            if (isset($kills)) {
                foreach ($kills as $kill) {
 //                   if ($i < 10) {

                        //if big kill isn't set, disable it
                        if (!array_key_exists('bigKill', $kmGroup)) {
                            $kmGroup['bigKill'] = 99999999999999999999999999;
                        }
                        $killID = $kill['killID'];
                        if ($killID <= $SavedKillID) {
//                            $i++;
                            continue;
                        }
                        $channelID = $kmGroup['channel'];
                        $solarSystemID = $kill['solarSystemID'];
                        $systemName = systemName($solarSystemID);
                        $killTime = $kill['killTime'];
                        $victimAllianceName = '';
                    if ($kill['victim']['allianceName'] !== null && $kill['victim']['allianceName'] !== '') {

                            $victimAllianceName = "|{$kill['victim']['allianceName']}";
                        }
                        $victimName = $kill['victim']['characterName'];
                        $victimCorpName = $kill['victim']['corporationName'];
                        $victimShipID = $kill['victim']['shipTypeID'];
                        $shipName = apiTypeName($victimShipID);
                        $rawValue = $kill['zkb']['totalValue'];
                        //Check if killmail meets minimum value and if it meets lost minimum value
                        if (isset($kmGroup['minimumValue']) && isset($kmGroup['minimumlossValue'])) {
                            if ($rawValue < $kmGroup['minimumValue']) {
                                if ($kill['victim']['corporationID'] == $kmGroup['corpID'] && $rawValue > $kmGroup['minimumlossValue'] ||
                                $kill['victim']['allianceID'] == $kmGroup['allianceID'] && $rawValue > $kmGroup['minimumlossValue'])
                                {
                                    $this->logger->addInfo("Killmails: Mail {$killID} posted because it meet minimum loss value required.");
                                } else {
                                    $this->logger->addInfo("Killmails: Mail {$killID} ignored for not meeting the minimum value required.");
                                    setPermCache("{$kmGroup['name']}newestKillmailID", $killID);
                                    continue;
                                }
                            }
                        }
                        $totalValue = number_format($kill['zkb']['totalValue']);
                        // Check if it's a structure
                        if ($victimName !== '') {

                            if ($kmGroup['bigKill'] != null && $rawValue >= $kmGroup['bigKill']) {
                                $channelID = $kmGroup['bigKillChannel'];
                                $msg = "@here \n :warning:***Expensive Killmail***:warning: \n **{$killTime}**\n\n**{$shipName}** worth **{$totalValue} ISK** flown by **{$victimName}** of (***{$victimCorpName}|{$victimAllianceName}***) killed in {$systemName}\nhttps://zkillboard.com/kill/{$killID}/";
                            } elseif ($kmGroup['bigKill'] == null || $rawValue <= $kmGroup['bigKill']) {
                                $msg = "**{$killTime}**\n\n**{$shipName}** worth **{$totalValue} ISK** flown by **{$victimName}** of (***{$victimCorpName}|{$victimAllianceName}***) killed in {$systemName}\nhttps://zkillboard.com/kill/{$killID}/";
                            }
                        } elseif ($victimName === '') {
                            $msg = "**{$killTime}**\n\n**{$shipName}** worth **{$totalValue} ISK** owned by (***{$victimCorpName}|{$victimAllianceName}***) killed in {$systemName}\nhttps://zkillboard.com/kill/{$killID}/";
                        }

                        if (!isset($msg)) { // Make sure it's always set.
                            return null;
                        }
                        queueMessage($msg, $channelID, $this->guild);
                        $this->logger->addInfo("Killmails: Mail {$killID} queued.");

//                        $i++;

/*                    } else {
                        $updatedID = getPermCache("{$kmGroup['name']}newestKillmailID");
                        $this->logger->addInfo("Killmails: Kill posting cap reached, newest kill id for {$kmGroup['name']} is {$updatedID}");
                        break;
                    }*/
                }
                if (!isset($killID)) {
                    $killID = $SavedKillID;
                }
                setPermCache("{$kmGroup['name']}newestKillmailID", $killID);
            }
            $updatedID = getPermCache("{$kmGroup['name']}newestKillmailID");
            $this->logger->addInfo("Killmails: All kills posted, newest kill id for {$kmGroup['name']} is {$updatedID}");
            continue;
        }
    }

    private function getBigKM()
    {
        $oldID = getPermCache('bigKillNewestKillmailID');
        if (null === $oldID || preg_match('/[a-z]/i', $oldID)) {
            getStartBigMail();
            $oldID = getPermCache('bigKillNewestKillmailID');
        }

        $url = 'https://zkillboard.com/api/kills/orderDirection/desc/iskValue/10000000000/limit/10/';

        $kills = json_decode(downloadData($url), true);
        $i = 0;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (isset($kills)) {
            foreach ($kills as $kill) {
                $cacheID = getPermCache('bigKillNewestKillmailID');
 //               if ($i < 10) {

                    $killID = $kill['killID'];
                    //check if mail is old
                    if ((int)$killID <= (int)$oldID) {
                        continue;
                    }
                    //save highest killID for cache
                    if ($killID > $cacheID) {
                        setPermCache('bigKillNewestKillmailID', $killID);
                    }
                    $channelID = $this->config['plugins']['getKillmails']['bigKills']['bigKillChannel'];
                    $solarSystemID = $kill['solarSystemID'];
                    $systemName = systemName($solarSystemID);
                    $killTime = $kill['killTime'];
                $victimAllianceName = '';
                if ($kill['victim']['allianceName'] !== null && $kill['victim']['allianceName'] !== '') {

                    $victimAllianceName = "|{$kill['victim']['allianceName']}";
                }
                    $victimName = $kill['victim']['characterName'];
                    $victimCorpName = $kill['victim']['corporationName'];
                    $victimShipID = $kill['victim']['shipTypeID'];
                    $shipName = apiTypeName($victimShipID);
                    $totalValue = number_format($kill['zkb']['totalValue']);
                    // Check if it's a structure
                    if ($victimName !== '') {

                        $msg = "**10b+ Kill Reported**\n\n**{$killTime}**\n\n**{$shipName}** worth **{$totalValue} ISK** flown by **{$victimName}** of (***{$victimCorpName}|{$victimAllianceName}***) killed in {$systemName}\nhttps://zkillboard.com/kill/{$killID}/";
                    } else {
                        $msg = "**10b+ Kill Reported**\n\n**{$killTime}**\n\n**{$shipName}** worth **{$totalValue} ISK** owned by (***{$victimCorpName}|{$victimAllianceName}***) killed in {$systemName}\nhttps://zkillboard.com/kill/{$killID}/";
                    }
                    if (!isset($msg)) { // Make sure it's always set.
                        return null;
                    }
                    queueMessage($msg, $channelID, $this->guild);
                    $this->logger->addInfo("Killmails: Mail {$killID} queued.");

/*                    $i++;

                } else {
                    $cacheID = getPermCache('bigKillNewestKillmailID');
                    $this->logger->addInfo("Killmails: bigKill posting cap reached, newest kill id is {$cacheID}");
                    break;
                }*/
            }
        }
        $updatedID = getPermCache('bigKillNewestKillmailID');
        $this->logger->addInfo("Killmails: All bigKills posted, newest kill id is {$updatedID}");
    }
}


shibdib / Dramiel

getKillmailsOld B last analyzed 2017-11-21 19:00 UTC