Atipay::verify() - Code Metrics - Inspection of "Atipay" - shetabit/multipay - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#122)

unknown

created 2022-01-04 12:23 UTC

Atipay::verify() A

↳ Parent: Atipay

Complexity

Conditions	4
Paths	5

Size

Total Lines	35
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	24
c	1
b	0
f	0
nc	5
nop	0
dl	0
loc	35
rs	9.536

<?php
namespace Shetabit\Multipay\Drivers\Atipay;

use GuzzleHttp\Client;
use Shetabit\Multipay\Abstracts\Driver;
use Shetabit\Multipay\Exceptions\InvalidPaymentException;
use Shetabit\Multipay\Exceptions\PurchaseFailedException;
use Shetabit\Multipay\Contracts\ReceiptInterface;
use Shetabit\Multipay\Invoice;
use Shetabit\Multipay\Receipt;
use Shetabit\Multipay\RedirectionForm;
use Shetabit\Multipay\Request;

require_once 'Core/fn.atipay.php';

class Atipay extends Driver
{
    /**
     * Atipay Client.
     *
     * @var object
     */
    protected $client;

    /**
     * Invoice
     *
     * @var Invoice
     */
    protected $invoice;

    /**
     * Driver settings
     *
     * @var object
     */
    protected $settings;

    /**
     * Atipay constructor.
     * Construct the class with the relevant settings.
     *
     * @param Invoice $invoice
     * @param $settings
     */
    public function __construct(Invoice $invoice, $settings)
    {
        $this->invoice($invoice);
        $this->settings = (object) $settings;
        $this->client = new Client();
    }

    /**
     * Retrieve data from details using its name.
     *
     * @return string
     */
    private function extractDetails($name)
    {
        return empty($this->invoice->getDetails()[$name]) ? null : $this->invoice->getDetails()[$name];
    }

    /**
     * Purchase Invoice.
     *
     * @return string
     *
     * @throws PurchaseFailedException
     * @throws \GuzzleHttp\Exception\GuzzleException
     */
    public function purchase()
    {
        $amount = $this->invoice->getAmount();
        if ($this->settings->currency == 'T') { //convert amount to rial, payment gateways need rial
            $amount = $amount * 10;
        }
        
        $order_id = $this->invoice->getUuid();
        $mobile = $this->extractDetails('mobile');
        $description = $this->extractDetails('description');

        $apikey = $this->settings->apikey;
        $redirectUrl = $this->settings->callbackUrl;
        
        $token_params = array('apiKey'=>$apikey,
            'redirectUrl'=>$redirectUrl,
            'invoiceNumber'=>$order_id,
            'amount'=>$amount,
            'cellNumber'=>$mobile,
        );

        $r = fn_atipay_get_token($token_params);
        if ($r['success'] == 1) {
            $token = $r['token'];
            $this->invoice->transactionId($token);
            return $this->invoice->getTransactionId();
        } else {
            $error_message = $r['errorMessage'];
            throw new PurchaseFailedException($error_message);
        }
    }

    /**
     * Pay the Invoice
     *
     * @return RedirectionForm
     */
    public function pay(): RedirectionForm
    {
        $token = $this->invoice->getTransactionId();
        $payUrl = $this->settings->atipayRedirectGatewayUrl;
        return $this->redirectWithForm($payUrl, ['token'=>$token], 'POST');
    }

    /**
     * Verify payment
     *
     * @return ReceiptInterface
     *
     * @throws InvalidPaymentException
     * @throws \GuzzleHttp\Exception\GuzzleException
     */
    public function verify(): ReceiptInterface
    {
        $result = fn_check_callback_data($params);

        $payment_id = $params['reservationNumber'];

        if ($result['success'] == 1) { //will verify here
            $apiKey = $this->setting->apikey;

            $amount = $this->invoice->getAmount();
            if ($this->settings->currency == 'T') { //convert amount to rial, payment gateways need rial
                $amount = $amount * 10;
            }
            $verify_params = array('apiKey' => $apiKey,
                'referenceNumber' => $params['referenceNumber']
            );
            
            $r = fn_atipay_verify_payment($verify_params, $amount);
            if ($r['success'] == 0) { //veriy failed
                $error_message = $r['errorMessage'];
                throw new InvalidPaymentException($error_message);
            } else { //success
                $receipt =  $this->createReceipt($data['referenceNumber']);

                $receipt->detail([
                    'referenceNo' => $params['referenceNumber'],
                    'rrn' => Request::input('rrn'),
                    'pan' => $params['maskedPan']
                ]);

                return $receipt;
            }
        } else {
            $error_message = $result['error'];
            throw new InvalidPaymentException($error_message);
        }


        return $this->createReceipt($body['transId']);
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }

    /**
     * Generate the payment's receipt
     *
     * @param $referenceId
     *
     * @return Receipt
     */
    protected function createReceipt($referenceId)
    {
        $receipt = new Receipt('Atipay', $referenceId);

        return $receipt;
    }
}


1			<?php
2			namespace Shetabit\Multipay\Drivers\Atipay;
3
4			use GuzzleHttp\Client;
5			use Shetabit\Multipay\Abstracts\Driver;
6			use Shetabit\Multipay\Exceptions\InvalidPaymentException;
7			use Shetabit\Multipay\Exceptions\PurchaseFailedException;
8			use Shetabit\Multipay\Contracts\ReceiptInterface;
9			use Shetabit\Multipay\Invoice;
10			use Shetabit\Multipay\Receipt;
11			use Shetabit\Multipay\RedirectionForm;
12			use Shetabit\Multipay\Request;
13
14			require_once 'Core/fn.atipay.php';
15
16			class Atipay extends Driver
17			{
18			/**
19			* Atipay Client.
20			*
21			* @var object
22			*/
23			protected $client;
24
25			/**
26			* Invoice
27			*
28			* @var Invoice
29			*/
30			protected $invoice;
31
32			/**
33			* Driver settings
34			*
35			* @var object
36			*/
37			protected $settings;
38
39			/**
40			* Atipay constructor.
41			* Construct the class with the relevant settings.
42			*
43			* @param Invoice $invoice
44			* @param $settings
45			*/
46			public function __construct(Invoice $invoice, $settings)
47			{
48			$this->invoice($invoice);
49			$this->settings = (object) $settings;
50			$this->client = new Client();
51			}
52
53			/**
54			* Retrieve data from details using its name.
55			*
56			* @return string
57			*/
58			private function extractDetails($name)
59			{
60			return empty($this->invoice->getDetails()[$name]) ? null : $this->invoice->getDetails()[$name];
61			}
62
63			/**
64			* Purchase Invoice.
65			*
66			* @return string
67			*
68			* @throws PurchaseFailedException
69			* @throws \GuzzleHttp\Exception\GuzzleException
70			*/
71			public function purchase()
72			{
73			$amount = $this->invoice->getAmount();
74			if ($this->settings->currency == 'T') { //convert amount to rial, payment gateways need rial
75			$amount = $amount * 10;
76			}
77
78			$order_id = $this->invoice->getUuid();
79			$mobile = $this->extractDetails('mobile');
80			$description = $this->extractDetails('description');
			0 ignored issues – show Unused Code introduced 2022-01-04 09:32 UTC by Report Bug Copy Issue Report The assignment to `$description` is dead and can be removed. Loading history...
81			$apikey = $this->settings->apikey;
82			$redirectUrl = $this->settings->callbackUrl;
83
84			$token_params = array('apiKey'=>$apikey,
85			'redirectUrl'=>$redirectUrl,
86			'invoiceNumber'=>$order_id,
87			'amount'=>$amount,
88			'cellNumber'=>$mobile,
89			);
90
91			$r = fn_atipay_get_token($token_params);
92			if ($r['success'] == 1) {
93			$token = $r['token'];
94			$this->invoice->transactionId($token);
95			return $this->invoice->getTransactionId();
96			} else {
97			$error_message = $r['errorMessage'];
98			throw new PurchaseFailedException($error_message);
99			}
100			}
101
102			/**
103			* Pay the Invoice
104			*
105			* @return RedirectionForm
106			*/
107			public function pay(): RedirectionForm
108			{
109			$token = $this->invoice->getTransactionId();
110			$payUrl = $this->settings->atipayRedirectGatewayUrl;
111			return $this->redirectWithForm($payUrl, ['token'=>$token], 'POST');
112			}
113
114			/**
115			* Verify payment
116			*
117			* @return ReceiptInterface
118			*
119			* @throws InvalidPaymentException
120			* @throws \GuzzleHttp\Exception\GuzzleException
121			*/
122			public function verify(): ReceiptInterface
123			{
124			$result = fn_check_callback_data($params);
			0 ignored issues – show Comprehensibility Best Practice introduced 2022-01-04 09:32 UTC by Report Bug Copy Issue Report The variable `$params` does not exist. Did you maybe mean `$verify_params`? Loading history...
125			$payment_id = $params['reservationNumber'];
			0 ignored issues – show Unused Code introduced 2022-01-04 09:32 UTC by Report Bug Copy Issue Report The assignment to `$payment_id` is dead and can be removed. Loading history...
126			if ($result['success'] == 1) { //will verify here
127			$apiKey = $this->setting->apikey;
			0 ignored issues – show Bug introduced 2022-01-04 09:32 UTC by Report Bug Copy Issue Report The property `setting` does not exist on `Shetabit\Multipay\Drivers\Atipay\Atipay`. Did you mean `settings`? Loading history...
128			$amount = $this->invoice->getAmount();
129			if ($this->settings->currency == 'T') { //convert amount to rial, payment gateways need rial
130			$amount = $amount * 10;
131			}
132			$verify_params = array('apiKey' => $apiKey,
133			'referenceNumber' => $params['referenceNumber']
134			);
135
136			$r = fn_atipay_verify_payment($verify_params, $amount);
137			if ($r['success'] == 0) { //veriy failed
138			$error_message = $r['errorMessage'];
139			throw new InvalidPaymentException($error_message);
140			} else { //success
141			$receipt = $this->createReceipt($data['referenceNumber']);
			0 ignored issues – show Comprehensibility Best Practice introduced 2022-01-04 09:32 UTC by Report Bug Copy Issue Report The variable `$data` seems to be never defined. Loading history...
142			$receipt->detail([
143			'referenceNo' => $params['referenceNumber'],
144			'rrn' => Request::input('rrn'),
145			'pan' => $params['maskedPan']
146			]);
147
148			return $receipt;
149			}
150			} else {
151			$error_message = $result['error'];
152			throw new InvalidPaymentException($error_message);
153			}
154
155
156			return $this->createReceipt($body['transId']);
			0 ignored issues – show Unused Code introduced 2022-01-04 09:32 UTC by Report Bug Copy Issue Report `return $this->createReceipt($body['transId'])` is not reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
157			}
158
159			/**
160			* Generate the payment's receipt
161			*
162			* @param $referenceId
163			*
164			* @return Receipt
165			*/
166			protected function createReceipt($referenceId)
167			{
168			$receipt = new Receipt('Atipay', $referenceId);
169
170			return $receipt;
171			}
172			}
173

shetabit / multipay

Pull Request — master (#122)

Atipay::verify() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like