sheadawson /
silverstripe-blocks
| Conditions | 10 |
| Paths | 96 |
| Total Lines | 90 |
| Code Lines | 59 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 31 | public function __construct($canAdd = true, $canEdit = true, $canDelete = true, $editableRows = false, $aboveOrBelow = false) |
||
| 32 | { |
||
| 33 | parent::__construct(); |
||
| 34 | |||
| 35 | $this->blockManager = Injector::inst()->get('BlockManager'); |
||
| 36 | $controllerClass = Controller::curr()->class; |
||
| 37 | // Get available Areas (for page) or all in case of ModelAdmin |
||
| 38 | if ($controllerClass == 'CMSPageEditController') { |
||
| 39 | $currentPage = Controller::curr()->currentPage(); |
||
| 40 | $areasFieldSource = $this->blockManager->getAreasForPageType($currentPage->ClassName); |
||
| 41 | } else { |
||
| 42 | $areasFieldSource = $this->blockManager->getAreasForTheme(); |
||
| 43 | } |
||
| 44 | |||
| 45 | // EditableColumns only makes sense on Saveable parenst (eg Page), or inline changes won't be saved |
||
| 46 | if ($editableRows) { |
||
| 47 | $this->addComponent($editable = new GridFieldEditableColumns()); |
||
| 48 | $displayfields = array( |
||
| 49 | 'TypeForGridfield' => array('title' => _t('Block.BlockType', 'Block Type'), 'field' => 'LiteralField'), |
||
| 50 | 'Title' => array('title' => _t('Block.Title', 'Title'), 'field' => 'ReadonlyField'), |
||
| 51 | 'BlockArea' => array( |
||
| 52 | 'title' => _t('Block.BlockArea', 'Block Area').' |
||
| 53 | ', |
||
| 54 | // the s prevent wrapping of dropdowns |
||
| 55 | 'callback' => function () use ($areasFieldSource) { |
||
| 56 | $areasField = DropdownField::create('BlockArea', 'Block Area', $areasFieldSource); |
||
| 57 | if (count($areasFieldSource) > 1) { |
||
| 58 | $areasField->setHasEmptyDefault(true); |
||
| 59 | } |
||
| 60 | return $areasField; |
||
| 61 | }, |
||
| 62 | ), |
||
| 63 | 'isPublishedIcon' => array('title' => _t('Block.IsPublishedField', 'Published'), 'field' => 'LiteralField'), |
||
| 64 | 'UsageListAsString' => array('title' => _t('Block.UsageListAsString', 'Used on'), 'field' => 'LiteralField'), |
||
| 65 | ); |
||
| 66 | |||
| 67 | if ($aboveOrBelow) { |
||
| 68 | $displayfields['AboveOrBelow'] = array( |
||
| 69 | 'title' => _t('GridFieldConfigBlockManager.AboveOrBelow', 'Above or Below'), |
||
| 70 | 'callback' => function () { |
||
| 71 | return DropdownField::create('AboveOrBelow', _t('GridFieldConfigBlockManager.AboveOrBelow', 'Above or Below'), BlockSet::config()->get('above_or_below_options')); |
||
| 72 | }, |
||
| 73 | ); |
||
| 74 | } |
||
| 75 | $editable->setDisplayFields($displayfields); |
||
| 76 | } else { |
||
| 77 | $this->addComponent($dcols = new GridFieldDataColumns()); |
||
| 78 | |||
| 79 | $displayfields = array( |
||
| 80 | 'TypeForGridfield' => array('title' => _t('Block.BlockType', 'Block Type'), 'field' => 'LiteralField'), |
||
| 81 | 'Title' => _t('Block.Title', 'Title'), |
||
| 82 | 'BlockArea' => _t('Block.BlockArea', 'Block Area'), |
||
| 83 | 'isPublishedIcon' => array('title' => _t('Block.IsPublishedField', 'Published'), 'field' => 'LiteralField'), |
||
| 84 | 'UsageListAsString' => _t('Block.UsageListAsString', 'Used on'), |
||
| 85 | ); |
||
| 86 | $dcols->setDisplayFields($displayfields); |
||
| 87 | $dcols->setFieldCasting(array('UsageListAsString' => 'HTMLText->Raw')); |
||
| 88 | } |
||
| 89 | |||
| 90 | $this->addComponent(new GridFieldButtonRow('before')); |
||
| 91 | $this->addComponent(new GridFieldToolbarHeader()); |
||
| 92 | $this->addComponent(new GridFieldDetailForm()); |
||
| 93 | $this->addComponent($sort = new GridFieldSortableHeader()); |
||
| 94 | $this->addComponent($filter = new GridFieldFilterHeader()); |
||
| 95 | $this->addComponent(new GridFieldDetailForm()); |
||
| 96 | if ($controllerClass == 'BlockAdmin' && class_exists('GridFieldCopyButton')) { |
||
| 97 | $this->addComponent(new GridFieldCopyButton()); |
||
| 98 | } |
||
| 99 | |||
| 100 | $filter->setThrowExceptionOnBadDataType(false); |
||
| 101 | $sort->setThrowExceptionOnBadDataType(false); |
||
| 102 | |||
| 103 | if ($canAdd) { |
||
| 104 | $multiClass = new GridFieldAddNewMultiClass(); |
||
| 105 | $classes = $this->blockManager->getBlockClasses(); |
||
| 106 | $multiClass->setClasses($classes); |
||
| 107 | $this->addComponent($multiClass); |
||
| 108 | //$this->addComponent(new GridFieldAddNewButton()); |
||
|
|
|||
| 109 | } |
||
| 110 | |||
| 111 | if ($canEdit) { |
||
| 112 | $this->addComponent(new GridFieldEditButton()); |
||
| 113 | } |
||
| 114 | |||
| 115 | if ($canDelete) { |
||
| 116 | $this->addComponent(new GridFieldDeleteAction(true)); |
||
| 117 | } |
||
| 118 | |||
| 119 | return $this; |
||
| 120 | } |
||
| 121 | |||
| 153 |
Loading history...
Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.
The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.
This check looks for comments that seem to be mostly valid code and reports them.